Skip to content

Commit a243212

Browse files
committed
address autocomplete will populate sublocality with sublocality, sublocality_level_1, etc. depending on what is available; utm parameters preserved when /run endpoint used
1 parent 6467ddb commit a243212

File tree

8 files changed

+75
-13
lines changed

8 files changed

+75
-13
lines changed

CHANGELOG.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,16 @@
11
# Change Log
22

3+
## [1.5.16] - 2024-10-16
4+
5+
### Changed
6+
- The `address autocomplete` will now populate the `.sublocality`
7+
field with `sublocality`, `sublocality_level_1`,
8+
`sublocality_level_2`, whichever is first available.
9+
- URL parameters `utm_source`, `utm_medium`, `utm_campaign`,
10+
`utm_term`, and `utm_content` will be preserved when analytics is
11+
configured and the `/run` endpoint is used.
12+
- Upgraded Pandoc to version 3.5.11 (system upgrade required).
13+
314
## [1.5.15] - 2024-10-13
415

516
### Fixed

Docker/run-postgresql.sh

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,10 @@ if [[ $PGVERSION == 16* ]]; then
4343
PGVERSION=16
4444
fi
4545

46+
if [[ $PGVERSION == 17* ]]; then
47+
PGVERSION=17
48+
fi
49+
4650
chown -R postgres:postgres /etc/postgresql
4751
chown -R postgres:postgres /var/lib/postgresql
4852
chown -R postgres:postgres /var/run/postgresql

docassemble_webapp/docassemble/webapp/server.py

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6734,6 +6734,13 @@ def update_current_info_with_session_info(the_current_info, session_info):
67346734
the_current_info.update({'session': user_code, 'encrypted': encrypted})
67356735

67366736

6737+
def remove_i_from_dict(the_dict):
6738+
the_dict = copy.copy(the_dict)
6739+
if 'i' in the_dict:
6740+
del the_dict['i']
6741+
return the_dict
6742+
6743+
67376744
@app.route(index_path, methods=['POST', 'GET'])
67386745
def index(action_argument=None, refer=None):
67396746
# if refer is None and request.method == 'GET':
@@ -8753,19 +8760,19 @@ def index(action_argument=None, refer=None):
87538760
if refer is None:
87548761
location_bar = url_for('index', **index_params)
87558762
elif refer[0] in ('start', 'run'):
8756-
location_bar = url_for('run_interview_in_package', package=refer[1], filename=refer[2])
8763+
location_bar = url_for('run_interview_in_package', package=refer[1], filename=refer[2], **remove_i_from_dict(index_params))
87578764
page_sep = "#/"
87588765
elif refer[0] in ('start_dispatch', 'run_dispatch'):
8759-
location_bar = url_for('run_interview', dispatch=refer[1])
8766+
location_bar = url_for('run_interview', dispatch=refer[1], **remove_i_from_dict(index_params))
87608767
page_sep = "#/"
87618768
elif refer[0] in ('start_directory', 'run_directory'):
8762-
location_bar = url_for('run_interview_in_package_directory', package=refer[1], directory=refer[2], filename=refer[3])
8769+
location_bar = url_for('run_interview_in_package_directory', package=refer[1], directory=refer[2], filename=refer[3], **remove_i_from_dict(index_params))
87638770
page_sep = "#/"
87648771
else:
87658772
location_bar = None
87668773
for k, v in daconfig['dispatch'].items():
87678774
if v == yaml_filename:
8768-
location_bar = url_for('run_interview', dispatch=k)
8775+
location_bar = url_for('run_interview', dispatch=k, **remove_i_from_dict(index_params))
87698776
page_sep = "#/"
87708777
break
87718778
if location_bar is None:

docassemble_webapp/docassemble/webapp/static/app/app.js

Lines changed: 45 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -345,12 +345,12 @@ function daInitAutocomplete(info) {
345345
var opts = info[i][1];
346346
daAutocomplete[id] = new google.maps.places.Autocomplete(
347347
document.getElementById(id),
348-
opts
348+
opts,
349349
);
350350
google.maps.event.addListener(
351351
daAutocomplete[id],
352352
"place_changed",
353-
daFillInAddressFor(id)
353+
daFillInAddressFor(id),
354354
);
355355
}
356356
}, timePeriod);
@@ -414,7 +414,7 @@ function daAddMarker(map, marker_info, show_marker) {
414414
marker = new google.maps.Marker({
415415
position: new google.maps.LatLng(
416416
marker_info.latitude,
417-
marker_info.longitude
417+
marker_info.longitude,
418418
),
419419
map: map.map,
420420
icon: marker_info.icon,
@@ -428,7 +428,7 @@ function daAddMarker(map, marker_info, show_marker) {
428428
map.infowindow.setContent(info);
429429
map.infowindow.open(map.map, marker);
430430
};
431-
})(marker, marker_info.info)
431+
})(marker, marker_info.info),
432432
);
433433
}
434434
if (show_marker) {
@@ -531,7 +531,7 @@ function daFillInAddress(origId) {
531531
var val = place.address_components[i][componentForm[addressType]];
532532
if (typeof val != "undefined") {
533533
document.getElementById(
534-
id_for_part[componentTrans[addressType]]
534+
id_for_part[componentTrans[addressType]],
535535
).value = val;
536536
toChange.push("#" + id_for_part[componentTrans[addressType]]);
537537
}
@@ -598,6 +598,46 @@ function daFillInAddress(origId) {
598598
savedValues["administrative_area_level_3"];
599599
}
600600
}
601+
if (
602+
typeof id_for_part["sublocality"] != "undefined" &&
603+
document.getElementById(id_for_part["sublocality"]) != null
604+
) {
605+
if (
606+
document.getElementById(id_for_part["sublocality"]).value == "" &&
607+
typeof savedValues["sublocality_level_1"] != "undefined"
608+
) {
609+
document.getElementById(id_for_part["sublocality"]).value =
610+
savedValues["sublocality_level_1"];
611+
}
612+
if (
613+
document.getElementById(id_for_part["sublocality"]).value == "" &&
614+
typeof savedValues["sublocality_level_2"] != "undefined"
615+
) {
616+
document.getElementById(id_for_part["sublocality"]).value =
617+
savedValues["sublocality_level_2"];
618+
}
619+
if (
620+
document.getElementById(id_for_part["sublocality"]).value == "" &&
621+
typeof savedValues["sublocality_level_3"] != "undefined"
622+
) {
623+
document.getElementById(id_for_part["sublocality"]).value =
624+
savedValues["sublocality_level_3"];
625+
}
626+
if (
627+
document.getElementById(id_for_part["sublocality"]).value == "" &&
628+
typeof savedValues["sublocality_level_4"] != "undefined"
629+
) {
630+
document.getElementById(id_for_part["sublocality"]).value =
631+
savedValues["sublocality_level_4"];
632+
}
633+
if (
634+
document.getElementById(id_for_part["sublocality"]).value == "" &&
635+
typeof savedValues["sublocality_level_5"] != "undefined"
636+
) {
637+
document.getElementById(id_for_part["sublocality"]).value =
638+
savedValues["sublocality_level_5"];
639+
}
640+
}
601641
if (
602642
place.adr_address &&
603643
typeof id_for_part["adr_address"] != "undefined" &&

docassemble_webapp/docassemble/webapp/static/app/app.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docassemble_webapp/docassemble/webapp/static/app/bundle.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docassemble_webapp/docassemble/webapp/static/app/bundlenojquery.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docassemble_webapp/docassemble/webapp/static/app/bundlewrapjquery.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)