Switch to conventional naming for JSON-parsed structs

Konstantin Semenov · Konstantin Semenov · commit 7942a104cb6a · 2023-03-03T18:18:54.000Z
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -2,19 +2,19 @@ name: Sonar Scan
 on:
   push:
     branches:
-      - main
+    - main
   pull_request:
-    types: [opened, synchronize, reopened]
+    types: [ opened, synchronize, reopened ]
 jobs:
   sonarcloud:
     name: SonarCloud
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-        with:
-          fetch-depth: 0  # Shallow clones should be disabled for a better relevancy of analysis
-      - name: SonarCloud Scan
-        uses: SonarSource/sonarcloud-github-action@master
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}  # Needed to get PR information, if any
-          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+    - uses: actions/checkout@v3
+      with:
+        fetch-depth: 0  # Shallow clones should be disabled for a better relevancy of analysis
+    - name: SonarCloud Scan
+      uses: SonarSource/sonarcloud-github-action@master
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}  # Needed to get PR information, if any
+        SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
diff --git a/Radar/App Data Objects/AppDataConverter.swift b/Radar/App Data Objects/AppDataConverter.swift
@@ -6,24 +6,24 @@ class AppDataConverter {
     static func convert(pipelines concoursePipelines: [ConcoursePipeline], jobs concourseJobs: [ConcourseJob], url: URL, teamName: String) -> Team {
         let indexedJobs = sortConcourseJobs(jobs: concourseJobs, teamName: teamName)
         var pipelineCollection = [Pipeline]()
-        for concoursePipeline in concoursePipelines.filter({ !$0.archived && ($0.team_name == teamName) }) {
+        for concoursePipeline in concoursePipelines.filter({ !$0.isArchived && ($0.teamName == teamName) }) {
             var pipelineJobs = [Job]()
             if let jobCollection = indexedJobs[concoursePipeline.id] {
                 for j in jobCollection {
                     pipelineJobs.append(extractJob(j))
                 }
             }
-            pipelineCollection.append(Pipeline(id: concoursePipeline.id, name: concoursePipeline.name, paused: concoursePipeline.paused, public: concoursePipeline.public, concourseUrl: url, teamName: teamName, jobs: pipelineJobs))
+            pipelineCollection.append(Pipeline(id: concoursePipeline.id, name: concoursePipeline.name, isPaused: concoursePipeline.isPaused, isPublic: concoursePipeline.isPublic, concourseUrl: url, teamName: teamName, jobs: pipelineJobs))
         }
         return Team(concourseUrl: url, teamName: teamName, pipelines: pipelineCollection, error: nil)
     }
 
     private static func extractJob(_ job: ConcourseJob) -> Job {
         Job(id: job.id,
                 name: job.name,
-                transitionBuild: extractBuild(job.transition_build),
-                finishedBuild: extractBuild(job.finished_build),
-                nextBuild: extractBuild(job.next_build)
+                transitionBuild: extractBuild(job.transitionBuild),
+                finishedBuild: extractBuild(job.finishedBuild),
+                nextBuild: extractBuild(job.nextBuild)
         )
     }
 
@@ -35,17 +35,17 @@ class AppDataConverter {
                 id: concourseBuild.id,
                 name: concourseBuild.name,
                 status: buildStatus,
-                startTime: Date(timeIntervalSince1970: Double(concourseBuild.start_time)),
-                endTime: Date(timeIntervalSince1970: Double(concourseBuild.end_time)))
+                startTime: Date(timeIntervalSince1970: Double(concourseBuild.startTime)),
+                endTime: Date(timeIntervalSince1970: Double(concourseBuild.endTime)))
     }
 
     private static func sortConcourseJobs(jobs: [ConcourseJob], teamName: String) -> [Int: [ConcourseJob]] {
         var result = [Int: [ConcourseJob]]()
-        for job in jobs.filter({ $0.team_name == teamName }) {
-            if result[job.pipeline_id] == nil {
-                result[job.pipeline_id] = [ConcourseJob]()
+        for job in jobs.filter({ $0.teamName == teamName }) {
+            if result[job.pipelineId] == nil {
+                result[job.pipelineId] = [ConcourseJob]()
             }
-            result[job.pipeline_id]?.append(job)
+            result[job.pipelineId]?.append(job)
         }
         return result
     }
diff --git a/Radar/App Data Objects/Job.swift b/Radar/App Data Objects/Job.swift
@@ -11,7 +11,7 @@ struct Job {
         case succeeded
         case unknown
 
-        static func <(lhs: Job.Status, rhs: Job.Status) -> Bool {
+        static func < (lhs: Job.Status, rhs: Job.Status) -> Bool {
             lhs.comparisonValue < rhs.comparisonValue
         }
 
diff --git a/Radar/App Data Objects/Pipeline.swift b/Radar/App Data Objects/Pipeline.swift
@@ -5,8 +5,8 @@ import Foundation
 struct Pipeline: Identifiable {
     let id: Int
     let name: String
-    let paused: Bool
-    let `public`: Bool
+    let isPaused: Bool
+    let isPublic: Bool
     let concourseUrl: URL
     let teamName: String
 
@@ -18,7 +18,7 @@ struct Pipeline: Identifiable {
     }
 
     var statusIcon: Icon {
-        if paused {
+        if isPaused {
             return .paused
         }
         if jobs.isEmpty {
diff --git a/Radar/ConcourseJob.swift b/Radar/ConcourseJob.swift
@@ -3,15 +3,25 @@
 import Foundation
 
 struct ConcourseBuild: Codable {
+    enum CodingKeys: String, CodingKey {
+        case id, name, status
+        case startTime = "start_time"
+        case endTime = "end_time"
+        case teamName = "team_name"
+        case pipelineId = "pipeline_id"
+        case pipelineName = "pipeline_name"
+        case jobName = "job_name"
+    }
+
     var id: Int
     var name: String
     var status: String
-    var start_time: Int
-    var end_time: Int
-    var team_name: String
-    var pipeline_id: Int
-    var pipeline_name: String
-    var job_name: String
+    var startTime: Int
+    var endTime: Int
+    var teamName: String
+    var pipelineId: Int
+    var pipelineName: String
+    var jobName: String
 }
 
 struct JobInput: Codable {
@@ -22,13 +32,22 @@ struct JobInput: Codable {
 }
 
 struct ConcourseJob: Codable, Identifiable {
+    enum CodingKeys: String, CodingKey {
+        case id, name, teamName, inputs
+        case pipelineId = "pipeline_id"
+        case pipelineName = "pipeline_name"
+        case finishedBuild = "finished_build"
+        case transitionBuild = "transition_build"
+        case nextBuild = "next_build"
+    }
+
     var id: Int
     var name: String
-    var team_name: String
-    var pipeline_id: Int
-    var pipeline_name: String
-    var finished_build: ConcourseBuild?
-    var transition_build: ConcourseBuild?
-    var next_build: ConcourseBuild?
+    var teamName: String
+    var pipelineId: Int
+    var pipelineName: String
+    var finishedBuild: ConcourseBuild?
+    var transitionBuild: ConcourseBuild?
+    var nextBuild: ConcourseBuild?
     var inputs: [JobInput]?
 }
diff --git a/Radar/ConcoursePipeline.swift b/Radar/ConcoursePipeline.swift
@@ -8,12 +8,21 @@ struct PipelineGroup: Codable {
 }
 
 struct ConcoursePipeline: Codable {
+    enum CodingKeys: String, CodingKey {
+        case id, name, groups
+        case isPaused = "paused"
+        case isArchived = "archived"
+        case isPublic = "public"
+        case teamName = "team_name"
+        case lastUpdated = "last_updated"
+    }
+
     var id: Int
     var name: String
-    var paused: Bool
-    var archived: Bool
-    var `public`: Bool
+    var isPaused: Bool
+    var isArchived: Bool
+    var isPublic: Bool
     var groups: [PipelineGroup]?
-    var team_name: String
-    var last_updated: Int?
+    var teamName: String
+    var lastUpdated: Int?
 }
diff --git a/Radar/UI/ConcourseMenu.swift b/Radar/UI/ConcourseMenu.swift
@@ -82,11 +82,11 @@ fileprivate func fullConcourseData() -> ConcourseData {
     let data = ConcourseData()
     data.concourseUrl = "http://localhost/"
     data.team = Team(concourseUrl: URL(string: "http://localhost")!, teamName: "test-team", pipelines: [
-        Pipeline(id: 1, name: "pipeline-name", paused: false, public: false, concourseUrl: URL(string: "http://localhost")!, teamName: "test-team", jobs: [
+        Pipeline(id: 1, name: "pipeline-name", isPaused: false, isPublic: false, concourseUrl: URL(string: "http://localhost")!, teamName: "test-team", jobs: [
             Job(id: 1, name: "test-job", transitionBuild: nil, finishedBuild: Build(id: 1, name: "234", status: .succeeded,
                     startTime: Date(timeIntervalSince1970: 298347), endTime: Date(timeIntervalSince1970: 948559)), nextBuild: nil)
         ]),
-        Pipeline(id: 2, name: "pipeline-two", paused: false, public: false, concourseUrl: URL(string: "http://localhost")!, teamName: "test-team", jobs: [
+        Pipeline(id: 2, name: "pipeline-two", isPaused: false, isPublic: false, concourseUrl: URL(string: "http://localhost")!, teamName: "test-team", jobs: [
             Job(id: 21, name: "another-test-job", transitionBuild: nil,
                 finishedBuild: nil,
                 nextBuild: Build(id: 213, name: "29873", status: .started,
diff --git a/Radar/UI/PipelineView.swift b/Radar/UI/PipelineView.swift
@@ -22,7 +22,7 @@ struct PipelineView: View {
 
 struct PipelineView_Previews: PreviewProvider {
     static var previews: some View {
-        PipelineView(pipeline: Pipeline(id: 1, name: "pipeline-name", paused: false, public: false, concourseUrl: URL(string: "http://localhost")!, teamName: "preview-team", jobs: [
+        PipelineView(pipeline: Pipeline(id: 1, name: "pipeline-name", isPaused: false, isPublic: false, concourseUrl: URL(string: "http://localhost")!, teamName: "preview-team", jobs: [
             Job(id: 1, name: "", transitionBuild: nil, finishedBuild: Build(id: 1, name: "", status: .succeeded, startTime: Date(), endTime: Date()), nextBuild: nil)
         ]))
     }
diff --git a/RadarTests/AppDataConverterSpec.swift b/RadarTests/AppDataConverterSpec.swift
@@ -17,42 +17,42 @@ class AppDataConverterSpec: QuickSpec {
         }
         
         it("includes the pipelines and jobs") {
-            let pipeline = ConcoursePipeline(id: 1, name: "test-pipeline", paused: false, archived: false, public: false, team_name: self.teamName)
-            let successfulBuild = ConcourseBuild(id: 1, name: "1", status: "succeeded", start_time: 23894, end_time: 30983, team_name: self.teamName, pipeline_id: 1, pipeline_name: "test-pipeline", job_name: "test-job")
+            let pipeline = ConcoursePipeline(id: 1, name: "test-pipeline", isPaused: false, isArchived: false, isPublic: false, teamName: self.teamName)
+            let successfulBuild = ConcourseBuild(id: 1, name: "1", status: "succeeded", startTime: 23894, endTime: 30983, teamName: self.teamName, pipelineId: 1, pipelineName: "test-pipeline", jobName: "test-job")
 
-            let job = ConcourseJob(id: 1, name: "test-job", team_name: self.teamName, pipeline_id: 1, pipeline_name: "test-pipeline", finished_build: successfulBuild)
+            let job = ConcourseJob(id: 1, name: "test-job", teamName: self.teamName, pipelineId: 1, pipelineName: "test-pipeline", finishedBuild: successfulBuild)
             
             let team = AppDataConverter.convert(pipelines: [pipeline], jobs: [job], url: self.url, teamName: self.teamName)
             expect(team.pipelines).to(haveCount(1))
             expect(team.pipelines.first!.jobs).to(haveCount(1))
         }
 
         it("omits archived pipelines") {
-            let pipeline = ConcoursePipeline(id: 1, name: "test-pipeline", paused: false, archived: true, public: false, team_name: self.teamName)
+            let pipeline = ConcoursePipeline(id: 1, name: "test-pipeline", isPaused: false, isArchived: true, isPublic: false, teamName: self.teamName)
             let team = AppDataConverter.convert(pipelines: [pipeline], jobs: [], url: self.url, teamName: self.teamName)
             expect(team.pipelines).to(beEmpty())
         }
 
         it("assigns the attributes to pipeline") {
-            let concoursePipeline = ConcoursePipeline(id: 1, name: "test-pipeline", paused: false, archived: false, public: false, team_name: self.teamName)
+            let concoursePipeline = ConcoursePipeline(id: 1, name: "test-pipeline", isPaused: false, isArchived: false, isPublic: false, teamName: self.teamName)
 
             let team = AppDataConverter.convert(pipelines: [concoursePipeline], jobs: [], url: self.url, teamName: self.teamName)
             let pipeline = team.pipelines.first!
             expect(pipeline.id).to(equal(1))
             expect(pipeline.name).to(equal("test-pipeline"))
-            expect(pipeline.paused).to(beFalse())
-            expect(pipeline.public).to(beFalse())
+            expect(pipeline.isPaused).to(beFalse())
+            expect(pipeline.isPublic).to(beFalse())
             expect(pipeline.concourseUrl).to(equal(self.url))
             expect(pipeline.teamName).to(equal(self.teamName))
         }
 
         it("assigns the attributes to the job") {
-            let concoursePipeline = ConcoursePipeline(id: 1, name: "test-pipeline", paused: false, archived: false, public: false, team_name: self.teamName)
-            let transitionBuild = ConcourseBuild(id: 1, name: "1", status: "succeeded", start_time: 23894, end_time: 30983, team_name: self.teamName, pipeline_id: 1, pipeline_name: "test-pipeline", job_name: "test-job")
-            let finishedBuild = ConcourseBuild(id: 12, name: "12", status: "succeeded", start_time: 52834, end_time: 85465, team_name: self.teamName, pipeline_id: 1, pipeline_name: "test-pipeline", job_name: "test-job")
-            let nextBuild = ConcourseBuild(id: 13, name: "13", status: "started", start_time: 49764, end_time: 46546, team_name: self.teamName, pipeline_id: 1, pipeline_name: "test-pipeline", job_name: "test-job")
+            let concoursePipeline = ConcoursePipeline(id: 1, name: "test-pipeline", isPaused: false, isArchived: false, isPublic: false, teamName: self.teamName)
+            let transitionBuild = ConcourseBuild(id: 1, name: "1", status: "succeeded", startTime: 23894, endTime: 30983, teamName: self.teamName, pipelineId: 1, pipelineName: "test-pipeline", jobName: "test-job")
+            let finishedBuild = ConcourseBuild(id: 12, name: "12", status: "succeeded", startTime: 52834, endTime: 85465, teamName: self.teamName, pipelineId: 1, pipelineName: "test-pipeline", jobName: "test-job")
+            let nextBuild = ConcourseBuild(id: 13, name: "13", status: "started", startTime: 49764, endTime: 46546, teamName: self.teamName, pipelineId: 1, pipelineName: "test-pipeline", jobName: "test-job")
 
-            let concourseJob = ConcourseJob(id: 1, name: "test-job", team_name: self.teamName, pipeline_id: 1, pipeline_name: "test-pipeline", finished_build: finishedBuild, transition_build: transitionBuild, next_build: nextBuild)
+            let concourseJob = ConcourseJob(id: 1, name: "test-job", teamName: self.teamName, pipelineId: 1, pipelineName: "test-pipeline", finishedBuild: finishedBuild, transitionBuild: transitionBuild, nextBuild: nextBuild)
 
             let team = AppDataConverter.convert(pipelines: [concoursePipeline], jobs: [concourseJob], url: self.url, teamName: self.teamName)
             let job = team.pipelines.first!.jobs.first!
@@ -64,12 +64,12 @@ class AppDataConverterSpec: QuickSpec {
         }
 
         it("assigns the attributes to the builds") {
-            let concoursePipeline = ConcoursePipeline(id: 1, name: "test-pipeline", paused: false, archived: false, public: false, team_name: self.teamName)
-            let tBuild = ConcourseBuild(id: 1, name: "1", status: "succeeded", start_time: 23894, end_time: 30983, team_name: self.teamName, pipeline_id: 1, pipeline_name: "test-pipeline", job_name: "test-job")
-            let fBuild = ConcourseBuild(id: 12, name: "12", status: "succeeded", start_time: 52834, end_time: 85465, team_name: self.teamName, pipeline_id: 1, pipeline_name: "test-pipeline", job_name: "test-job")
-            let nBuild = ConcourseBuild(id: 13, name: "13", status: "started", start_time: 49764, end_time: 46546, team_name: self.teamName, pipeline_id: 1, pipeline_name: "test-pipeline", job_name: "test-job")
+            let concoursePipeline = ConcoursePipeline(id: 1, name: "test-pipeline", isPaused: false, isArchived: false, isPublic: false, teamName: self.teamName)
+            let tBuild = ConcourseBuild(id: 1, name: "1", status: "succeeded", startTime: 23894, endTime: 30983, teamName: self.teamName, pipelineId: 1, pipelineName: "test-pipeline", jobName: "test-job")
+            let fBuild = ConcourseBuild(id: 12, name: "12", status: "succeeded", startTime: 52834, endTime: 85465, teamName: self.teamName, pipelineId: 1, pipelineName: "test-pipeline", jobName: "test-job")
+            let nBuild = ConcourseBuild(id: 13, name: "13", status: "started", startTime: 49764, endTime: 46546, teamName: self.teamName, pipelineId: 1, pipelineName: "test-pipeline", jobName: "test-job")
 
-            let concourseJob = ConcourseJob(id: 1, name: "test-job", team_name: self.teamName, pipeline_id: 1, pipeline_name: "test-pipeline", finished_build: fBuild, transition_build: tBuild, next_build: nBuild)
+            let concourseJob = ConcourseJob(id: 1, name: "test-job", teamName: self.teamName, pipelineId: 1, pipelineName: "test-pipeline", finishedBuild: fBuild, transitionBuild: tBuild, nextBuild: nBuild)
 
             let team = AppDataConverter.convert(pipelines: [concoursePipeline], jobs: [concourseJob], url: self.url, teamName: self.teamName)
             let job = team.pipelines.first!.jobs.first!
@@ -99,11 +99,11 @@ class AppDataConverterSpec: QuickSpec {
 
         it("includes only pipelines from the indicated team") {
             let pipelines = [
-                ConcoursePipeline(id: 1, name: "name-1", paused: false, archived: false, public: false, groups: nil, team_name: "test-team", last_updated: nil),
-                ConcoursePipeline(id: 1, name: "name-1", paused: false, archived: false, public: false, groups: nil, team_name: "not-test-team", last_updated: nil),
-                ConcoursePipeline(id: 1, name: "name-1", paused: false, archived: false, public: false, groups: nil, team_name: "not-test-team", last_updated: nil),
-                ConcoursePipeline(id: 1, name: "name-1", paused: false, archived: false, public: false, groups: nil, team_name: "another-test-team", last_updated: nil),
-                ConcoursePipeline(id: 1, name: "name-1", paused: false, archived: false, public: false, groups: nil, team_name: "test-team", last_updated: nil),
+                ConcoursePipeline(id: 1, name: "name-1", isPaused: false, isArchived: false, isPublic: false, groups: nil, teamName: "test-team", lastUpdated: nil),
+                ConcoursePipeline(id: 1, name: "name-1", isPaused: false, isArchived: false, isPublic: false, groups: nil, teamName: "not-test-team", lastUpdated: nil),
+                ConcoursePipeline(id: 1, name: "name-1", isPaused: false, isArchived: false, isPublic: false, groups: nil, teamName: "not-test-team", lastUpdated: nil),
+                ConcoursePipeline(id: 1, name: "name-1", isPaused: false, isArchived: false, isPublic: false, groups: nil, teamName: "another-test-team", lastUpdated: nil),
+                ConcoursePipeline(id: 1, name: "name-1", isPaused: false, isArchived: false, isPublic: false, groups: nil, teamName: "test-team", lastUpdated: nil),
             ]
 
             let team = AppDataConverter.convert(pipelines: pipelines, jobs: [], url: URL(string: "http://localhost")!, teamName: "test-team")
diff --git a/RadarTests/PipelineSpec.swift b/RadarTests/PipelineSpec.swift
diff --git a/RadarTests/TeamSpec.swift b/RadarTests/TeamSpec.swift

Original file line number	Diff line number	Diff line change
`@@ -6,24 +6,24 @@ class AppDataConverter {`
`6`	`6`	`static func convert(pipelines concoursePipelines: [ConcoursePipeline], jobs concourseJobs: [ConcourseJob], url: URL, teamName: String) -> Team {`
`7`	`7`	`let indexedJobs = sortConcourseJobs(jobs: concourseJobs, teamName: teamName)`
`8`	`8`	`var pipelineCollection = [Pipeline]()`
`9`		`- for concoursePipeline in concoursePipelines.filter({ !$0.archived && ($0.team_name == teamName) }) {`
	`9`	`+ for concoursePipeline in concoursePipelines.filter({ !$0.isArchived && ($0.teamName == teamName) }) {`
`10`	`10`	`var pipelineJobs = [Job]()`
`11`	`11`	`if let jobCollection = indexedJobs[concoursePipeline.id] {`
`12`	`12`	`for j in jobCollection {`
`13`	`13`	`pipelineJobs.append(extractJob(j))`
`14`	`14`	`}`
`15`	`15`	`}`
`16`		`- pipelineCollection.append(Pipeline(id: concoursePipeline.id, name: concoursePipeline.name, paused: concoursePipeline.paused, public: concoursePipeline.public, concourseUrl: url, teamName: teamName, jobs: pipelineJobs))`
	`16`	`+ pipelineCollection.append(Pipeline(id: concoursePipeline.id, name: concoursePipeline.name, isPaused: concoursePipeline.isPaused, isPublic: concoursePipeline.isPublic, concourseUrl: url, teamName: teamName, jobs: pipelineJobs))`
`17`	`17`	`}`
`18`	`18`	`return Team(concourseUrl: url, teamName: teamName, pipelines: pipelineCollection, error: nil)`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`private static func extractJob(_ job: ConcourseJob) -> Job {`
`22`	`22`	`Job(id: job.id,`
`23`	`23`	`name: job.name,`
`24`		`- transitionBuild: extractBuild(job.transition_build),`
`25`		`- finishedBuild: extractBuild(job.finished_build),`
`26`		`- nextBuild: extractBuild(job.next_build)`
	`24`	`+ transitionBuild: extractBuild(job.transitionBuild),`
	`25`	`+ finishedBuild: extractBuild(job.finishedBuild),`
	`26`	`+ nextBuild: extractBuild(job.nextBuild)`
`27`	`27`	`)`
`28`	`28`	`}`
`29`	`29`
`@@ -35,17 +35,17 @@ class AppDataConverter {`
`35`	`35`	`id: concourseBuild.id,`
`36`	`36`	`name: concourseBuild.name,`
`37`	`37`	`status: buildStatus,`
`38`		`- startTime: Date(timeIntervalSince1970: Double(concourseBuild.start_time)),`
`39`		`- endTime: Date(timeIntervalSince1970: Double(concourseBuild.end_time)))`
	`38`	`+ startTime: Date(timeIntervalSince1970: Double(concourseBuild.startTime)),`
	`39`	`+ endTime: Date(timeIntervalSince1970: Double(concourseBuild.endTime)))`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`private static func sortConcourseJobs(jobs: [ConcourseJob], teamName: String) -> [Int: [ConcourseJob]] {`
`43`	`43`	`var result = [Int: [ConcourseJob]]()`
`44`		`- for job in jobs.filter({ $0.team_name == teamName }) {`
`45`		`- if result[job.pipeline_id] == nil {`
`46`		`- result[job.pipeline_id] = [ConcourseJob]()`
	`44`	`+ for job in jobs.filter({ $0.teamName == teamName }) {`
	`45`	`+ if result[job.pipelineId] == nil {`
	`46`	`+ result[job.pipelineId] = [ConcourseJob]()`
`47`	`47`	`}`
`48`		`- result[job.pipeline_id]?.append(job)`
	`48`	`+ result[job.pipelineId]?.append(job)`
`49`	`49`	`}`
`50`	`50`	`return result`
`51`	`51`	`}`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ struct Job {`
`11`	`11`	`case succeeded`
`12`	`12`	`case unknown`
`13`	`13`
`14`		`- static func <(lhs: Job.Status, rhs: Job.Status) -> Bool {`
	`14`	`+ static func < (lhs: Job.Status, rhs: Job.Status) -> Bool {`
`15`	`15`	`lhs.comparisonValue < rhs.comparisonValue`
`16`	`16`	`}`
`17`	`17`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ struct PipelineView: View {`
`22`	`22`
`23`	`23`	`struct PipelineView_Previews: PreviewProvider {`
`24`	`24`	`static var previews: some View {`
`25`		`- PipelineView(pipeline: Pipeline(id: 1, name: "pipeline-name", paused: false, public: false, concourseUrl: URL(string: "http://localhost")!, teamName: "preview-team", jobs: [`
	`25`	`+ PipelineView(pipeline: Pipeline(id: 1, name: "pipeline-name", isPaused: false, isPublic: false, concourseUrl: URL(string: "http://localhost")!, teamName: "preview-team", jobs: [`
`26`	`26`	`Job(id: 1, name: "", transitionBuild: nil, finishedBuild: Build(id: 1, name: "", status: .succeeded, startTime: Date(), endTime: Date()), nextBuild: nil)`
`27`	`27`	`]))`
`28`	`28`	`}`