(#1341) Add early break in the thumbnail strategies process

Author: jibedoubleve

src/Infra/Lanceur.Infra.Win32/Services/ThumbnailService.cs

@@ -89,7 +89,11 @@ async Task RunStrategy(AliasQueryResult alias)
         {
             foreach (var strategy in _orderedThumbnailStrategies)
             {
-                try { await strategy.UpdateThumbnailAsync(alias, _cts.Token); }
+                try
+                {
+                    var isResolved = await strategy.UpdateThumbnailAsync(alias, _cts.Token);
+                    if (isResolved) { break; }
+                }
                 catch (OperationCanceledException ex)
                 {
                     _logger.LogDebug(ex, "Cancellation requested during thumbnail update of {AliasName}", alias.Name);

src/Infra/Lanceur.Infra.Win32/Thumbnails/IThumbnailStrategy.cs

@@ -23,11 +23,15 @@ public interface IThumbnailStrategy
 
     /// <summary>
     ///     Updates the thumbnail associated with the specified alias.
-    ///     If the thumbnail is already cached, the update may be skipped.
     /// </summary>
     /// <param name="alias">The alias whose thumbnail needs to be updated.</param>
     /// <param name="cancellationToken">A token to cancel the asynchronous operation.</param>
-    Task UpdateThumbnailAsync(AliasQueryResult alias, CancellationToken cancellationToken);
+    /// <returns>
+    ///     <c>true</c> if the thumbnail was resolved (already cached or successfully fetched),
+    ///     allowing the caller to skip remaining strategies; <c>false</c> if this strategy
+    ///     could not resolve the thumbnail and the next strategy should be tried.
+    /// </returns>
+    Task<bool> UpdateThumbnailAsync(AliasQueryResult alias, CancellationToken cancellationToken);
 
     #endregion
 }

src/Infra/Lanceur.Infra.Win32/Thumbnails/Strategies/FavIconAppThumbnailStrategy.cs

@@ -33,14 +33,15 @@ IAliasManagementService aliasManagementService
 
     #region Methods
 
-    protected override async Task UpdateThumbnailCoreAsync(AliasQueryResult alias, CancellationToken cancellationToken)
+    /// <inheritdoc/>
+    protected override async Task<bool> UpdateThumbnailCoreAsync(AliasQueryResult alias, CancellationToken cancellationToken)
     {
         var thumbnail = await _favIconService.UpdateFaviconAsync(
             alias,
             _ => alias.ResolveThumbnailAbsolutePath(),
             cancellationToken
         );
-        if (thumbnail.IsNullOrEmpty()) { return; }
+        if (thumbnail.IsNullOrEmpty()) { return false; }
 
         _logger.LogInformation(
             "Updating for alias {Alias} favicon from {Thumbnail} to {FavIconPath}",
@@ -51,6 +52,7 @@ protected override async Task UpdateThumbnailCoreAsync(AliasQueryResult alias, C
 
         alias.Thumbnail = thumbnail;
         _aliasManagementService.UpdateThumbnail(alias);
+        return true;
     }
 
     #endregion

src/Infra/Lanceur.Infra.Win32/Thumbnails/Strategies/PackagedAppThumbnailStrategy.cs

@@ -40,23 +40,25 @@ ILogger<PackagedAppThumbnailStrategy> logger
 
     #region Methods
 
-    protected override async Task UpdateThumbnailCoreAsync(AliasQueryResult alias, CancellationToken cancellationToken)
+    /// <inheritdoc/>
+    protected override async Task<bool> UpdateThumbnailCoreAsync(AliasQueryResult alias, CancellationToken cancellationToken)
     {
-        if (!alias.IsPackagedApplication()) { return; }
+        if (!alias.IsPackagedApplication()) { return false; }
 
         var app = await _packagedAppSearchService.GetByInstalledDirectoryAsync(alias.FileName!);
         var response = app.FirstOrDefault();
 
         if (response is null)
         {
             _logger.LogTrace("Failed to download the thumbnail for alias {Name}.", alias.Name);
-            return;
+            return true;
         }
 
         var thumbnailAbsolutePath = alias.ResolveThumbnailAbsolutePath();
         response.Logo.LocalPath.CopyToImageRepository(thumbnailAbsolutePath);
         alias.Thumbnail = thumbnailAbsolutePath;
         _aliasManagementService.UpdateThumbnail(alias);
+        return true;
     }
 
     #endregion

src/Infra/Lanceur.Infra.Win32/Thumbnails/Strategies/SteamLibraryAppThumbnailStrategy.cs

@@ -72,9 +72,9 @@ private async Task<bool> SaveThumbnailAsync(HttpResponseMessage response, string
     }
 
     /// <inheritdoc />
-    protected override async Task UpdateThumbnailCoreAsync(AliasQueryResult alias, CancellationToken cancellationToken)
+    protected override async Task<bool> UpdateThumbnailCoreAsync(AliasQueryResult alias, CancellationToken cancellationToken)
     {
-        if (!alias.IsSteamGame()) { return; }
+        if (!alias.IsSteamGame()) { return false; }
 
         var url = GetThumbnailUrl(alias.GetSteamId());
         using var response =
@@ -86,16 +86,16 @@ protected override async Task UpdateThumbnailCoreAsync(AliasQueryResult alias, C
             url
         );
 
-        if (response.StatusCode != HttpStatusCode.OK) { return; }
+        if (response.StatusCode != HttpStatusCode.OK) { return true; }
 
         var thumbnail = alias.ResolveThumbnailAbsolutePath();
 
-        if (!File.Exists(thumbnail) && !await SaveThumbnailAsync(response, thumbnail)) { return; }
+        if (!File.Exists(thumbnail) && !await SaveThumbnailAsync(response, thumbnail)) { return  true; }
 
         alias.Thumbnail = thumbnail;
         _aliasManagementService.UpdateThumbnail(alias);
 
-        return;
+        return true;
 
         string GetThumbnailUrl(int appId) =>
             $"https://cdn.akamai.steamstatic.com/steam/apps/{appId}/capsule_sm_120.jpg";

src/Infra/Lanceur.Infra.Win32/Thumbnails/Strategies/Win32AppThumbnailStrategy.cs

@@ -44,21 +44,23 @@ ILogger<Win32AppThumbnailStrategy> logger
 
     #region Methods
 
-    protected override async Task UpdateThumbnailCoreAsync(AliasQueryResult alias, CancellationToken cancellationToken)
+    /// <inheritdoc/>
+    protected override async Task<bool> UpdateThumbnailCoreAsync(AliasQueryResult alias, CancellationToken cancellationToken)
     {
         var imageSource = await _staThreadRunner.RunAsync(
             () => _win32ThumbnailService.GetThumbnail(alias.FileName!),
             cancellationToken
         );
         if (imageSource is null)
         {
-            _logger.LogTrace("Failed to download the thumbnail for alias {Name}.", alias.Name);
-            return;
+            _logger.LogTrace("Failed to fetch the thumbnail in disk for alias {Name}.", alias.Name);
+            return false;
         }
 
         alias.Thumbnail = alias.ResolveThumbnailAbsolutePath();
         imageSource.CopyToImageRepository(alias.Thumbnail);
         _aliasManagementService.UpdateThumbnail(alias);
+        return true;
     }
 
     #endregion

src/Infra/Lanceur.Infra.Win32/Thumbnails/ThumbnailStrategy.cs

@@ -38,10 +38,15 @@ public abstract class ThumbnailStrategy : IThumbnailStrategy
     /// </remarks>
     /// <param name="alias">The alias for which to update the thumbnail.</param>
     /// <param name="cancellationToken">Token to cancel the operation.</param>
-    protected abstract Task UpdateThumbnailCoreAsync(AliasQueryResult alias, CancellationToken cancellationToken);
+    /// <returns>
+    ///     <c>true</c> if the thumbnail was resolved (already cached or successfully fetched),
+    ///     allowing the caller to skip remaining strategies; <c>false</c> if this strategy
+    ///     could not resolve the thumbnail and the next strategy should be tried.
+    /// </returns>
+    protected abstract Task<bool> UpdateThumbnailCoreAsync(AliasQueryResult alias, CancellationToken cancellationToken);
 
     /// <inheritdoc />
-    public async Task UpdateThumbnailAsync(AliasQueryResult alias, CancellationToken cancellationToken)
+    public async Task<bool> UpdateThumbnailAsync(AliasQueryResult alias, CancellationToken cancellationToken)
     {
         _logger.LogTrace("Executing thumbnail strategy {Strategy} for alias {Alias}",
             GetType().FullName,
@@ -55,7 +60,7 @@ public async Task UpdateThumbnailAsync(AliasQueryResult alias, CancellationToken
                 alias.Name,
                 alias.Thumbnail
             );
-            return;
+            return true;
         }
 
         if (ResolveCachePathExists(out var path))
@@ -66,18 +71,16 @@ public async Task UpdateThumbnailAsync(AliasQueryResult alias, CancellationToken
                 path
             );
             alias.Thumbnail ??=  path;
-            return;
+            return true;
         }
 
         if (alias.FileName is null)
         {
             _logger.LogInformation("Alias {Alias} does not have a file name.", alias.Name);
-            return;
+            return true;
         }
 
-        await UpdateThumbnailCoreAsync(alias, cancellationToken);
-
-        return;
+        return await UpdateThumbnailCoreAsync(alias, cancellationToken);
 
         bool ResolveCachePathExists(out string path)
         {