Undeprecate DataValue.copy

Unlike some other Value subtypes, DataValue doesn't expose its private
data with a data() or similar method.

Author: jim-easterbrook

src/interface/value.i

@@ -495,6 +495,9 @@ VALUE_SUBCLASS(Exiv2::LangAltValue, LangAltValue)
 VALUE_SUBCLASS(Exiv2::XmpArrayValue, XmpArrayValue)
 VALUE_SUBCLASS(Exiv2::XmpTextValue, XmpTextValue)
 
+// Undeprecate DataValue::copy - it's the only way to get the data
+EXCEPTION(Exiv2::DataValue::copy)
+
 // Allow access to Exiv2::StringValueBase and Exiv2::XmpTextValue raw data
 %define RAW_STRING_DATA(class)
 RETURN_VIEW(const char* data, arg1->value_.size(), PyBUF_READ, class##::data)

src/swig-0_27_7/value_wrap.cxx

@@ -8722,8 +8722,6 @@ SWIGINTERN PyObject *_wrap_DataValue_copy(PyObject *self, PyObject *args) {
     }
   }
   {
-    PyErr_WarnEx(PyExc_DeprecationWarning,
-      "Python scripts should not need to call ""Exiv2::DataValue::copy", 1);
     try {
       result = (long)((Exiv2::DataValue const *)arg1)->copy(arg2,arg3);
     }

src/swig-0_28_5/value_wrap.cxx

@@ -8757,8 +8757,6 @@ SWIGINTERN PyObject *_wrap_DataValue_copy(PyObject *self, PyObject *args) {
     }
   }
   {
-    PyErr_WarnEx(PyExc_DeprecationWarning,
-      "Python scripts should not need to call ""Exiv2::DataValue::copy", 1);
     try {
       result = ((Exiv2::DataValue const *)arg1)->copy(arg2,arg3);
     }

tests/test_value.py

@@ -42,9 +42,13 @@ def do_common_tests(self, value, type_id, string, data, sequence=None):
         self.assertIsInstance(result, type(value))
         self.assertEqual(str(result), str(value))
         result = bytearray(len(data))
-        with self.assertWarns(DeprecationWarning):
-            self.assertEqual(
-                value.copy(result, exiv2.ByteOrder.littleEndian), len(result))
+        if type_id in (exiv2.TypeId.undefined, exiv2.TypeId.unsignedByte):
+            self.assertEqual(value.copy(
+                result, exiv2.ByteOrder.littleEndian), len(result))
+        else:
+            with self.assertWarns(DeprecationWarning):
+                self.assertEqual(value.copy(
+                    result, exiv2.ByteOrder.littleEndian), len(result))
         self.assertEqual(result, data)
         if sequence:
             self.check_result(value.count(), int, len(sequence))
@@ -322,8 +326,7 @@ def test_XmpTextValue(self):
     def test_DataValue(self):
         def check_data(value, data):
             copy = bytearray(len(data))
-            with self.assertWarns(DeprecationWarning):
-                self.assertEqual(value.copy(copy), len(data))
+            self.assertEqual(value.copy(copy), len(data))
             self.assertEqual(copy, data)
 
         data = bytes(random.choices(range(256), k=128))