Enable localisation in Windows builds

Author: jim-easterbrook

.github/workflows/build-windows-27.yml

@@ -8,6 +8,19 @@ jobs:
       - name: Check out repository code
         uses: actions/checkout@v4
 
+      - name: Fetch Gettext
+        run: >
+          c:\msys64\usr\bin\wget.exe -nv
+          https://github.com/mlocati/gettext-iconv-windows/releases/download/v0.21-v1.16/gettext0.21-iconv1.16-shared-64.zip
+          -O gettext.zip
+
+      - name: Extract Gettext
+        shell: bash
+        run: |
+          mkdir gettext
+          cd gettext
+          unzip ../gettext.zip
+
       - name: Fetch Exiv2 source
         run: >
           c:\msys64\usr\bin\wget.exe -nv
@@ -19,13 +32,19 @@ jobs:
         run: |
           tar -xzf exiv2.tar.gz
           mv exiv2-0.27.7-Source libexiv2
+          # tweaks to allow NLS
+          rm libexiv2/cmake/FindIconv.cmake
+          echo -e "24a25\n>         self.requires('libgettext/0.21')" |
+          c:/msys64/usr/bin/patch.exe libexiv2/conanfile.py
 
       - name: Build wheels
         uses: pypa/[email protected]
         env:
           CIBW_ARCHS: auto64
           CIBW_SKIP: pp3*
-          CIBW_ENVIRONMENT: EXIV2_ROOT=libexiv2/build-msvc/install
+          CIBW_ENVIRONMENT: |
+            EXIV2_ROOT=libexiv2/build-msvc/install
+            PATH="$PATH;$(pwd)\\gettext\\bin"
           CIBW_TEST_COMMAND: >
             python -m exiv2 -v &&
             python -m unittest discover {project}/tests -v
@@ -34,16 +53,17 @@ jobs:
             cd libexiv2 &&
             conan install . -of build-msvc -if build-msvc -o unitTests=False
             -o iconv=True -o webready=True -b missing &&
-            cmake -B build-msvc -DCMAKE_BUILD_TYPE=Release
-            -DCMAKE_INSTALL_PREFIX=build-msvc/install
-            -DEXIV2_ENABLE_WIN_UNICODE=ON
-            -DEXIV2_BUILD_SAMPLES=OFF
-            -DEXIV2_BUILD_EXIV2_COMMAND=OFF
-            -DEXIV2_ENABLE_BMFF=ON
-            -DEXIV2_ENABLE_NLS=OFF
-            -DEXIV2_ENABLE_VIDEO=ON
-            -DEXIV2_ENABLE_WEBREADY=ON
-            -DCMAKE_CXX_STANDARD=98
+            cmake -B build-msvc
+            -D CMAKE_BUILD_TYPE=Release
+            -D CMAKE_INSTALL_PREFIX=build-msvc/install
+            -D EXIV2_ENABLE_WIN_UNICODE=ON
+            -D EXIV2_BUILD_SAMPLES=OFF
+            -D EXIV2_BUILD_EXIV2_COMMAND=OFF
+            -D EXIV2_ENABLE_BMFF=ON
+            -D EXIV2_ENABLE_NLS=ON
+            -D EXIV2_ENABLE_VIDEO=ON
+            -D EXIV2_ENABLE_WEBREADY=ON
+            -D CMAKE_CXX_STANDARD=98
             -G "Visual Studio 16 2019" -A x64 &&
             cmake --build build-msvc --config Release &&
             cmake --install build-msvc --config Release

.github/workflows/build-windows-28.yml

@@ -8,6 +8,19 @@ jobs:
       - name: Check out repository code
         uses: actions/checkout@v4
 
+      - name: Fetch Gettext
+        run: >
+          c:\msys64\usr\bin\wget.exe -nv
+          https://github.com/mlocati/gettext-iconv-windows/releases/download/v0.21-v1.16/gettext0.21-iconv1.16-shared-64.zip
+          -O gettext.zip
+
+      - name: Extract Gettext
+        shell: bash
+        run: |
+          mkdir gettext
+          cd gettext
+          unzip ../gettext.zip
+
       - name: Fetch Exiv2 source
         run: >
           c:\msys64\usr\bin\wget.exe -nv
@@ -19,13 +32,18 @@ jobs:
         run: |
           tar -xzf exiv2.tar.gz
           mv exiv2-0.28.1 libexiv2
+          # tweaks to allow NLS
+          echo -e "24a25\n>         self.requires('libgettext/0.21')" |
+          c:/msys64/usr/bin/patch.exe libexiv2/conanfile.py
 
       - name: Build wheels
         uses: pypa/[email protected]
         env:
           CIBW_ARCHS: auto64
           CIBW_SKIP: pp3*
-          CIBW_ENVIRONMENT: EXIV2_ROOT=libexiv2/build-msvc/install
+          CIBW_ENVIRONMENT: |
+            EXIV2_ROOT=libexiv2/build-msvc/install
+            PATH="$PATH;$(pwd)\\gettext\\bin"
           CIBW_TEST_COMMAND: >
             python -m exiv2 -v &&
             python -m unittest discover {project}/tests -v
@@ -37,6 +55,7 @@ jobs:
             -D EXIV2_BUILD_SAMPLES=OFF
             -D EXIV2_BUILD_EXIV2_COMMAND=OFF
             -D EXIV2_BUILD_UNIT_TESTS=OFF
+            -D EXIV2_ENABLE_NLS=ON
             -G "Visual Studio 16 2019" &&
             cmake --build build-msvc --config Release &&
             cmake --install build-msvc --config Release &&