Skip to content

Commit 8065d5c

Browse files
MINOR: Making sure log appender is closed in ShareConsumerImplTest.java::testFailConstructor (apache#20514)
Similarly to what was done for AsyncKafkaConsumerTest::testFailConstructor, [here](apache#20491) Reviewers: Lianet Magrans <[email protected]>, Chia-Ping Tsai <[email protected]>
1 parent 45b96cb commit 8065d5c

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImplTest.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -213,18 +213,19 @@ public void testFailConstructor() {
213213
props.put(ConsumerConfig.METRIC_REPORTER_CLASSES_CONFIG, "an.invalid.class");
214214
final ConsumerConfig config = new ConsumerConfig(props);
215215

216-
LogCaptureAppender appender = LogCaptureAppender.createAndRegister();
217-
KafkaException ce = assertThrows(
216+
try (LogCaptureAppender appender = LogCaptureAppender.createAndRegister()) {
217+
KafkaException ce = assertThrows(
218218
KafkaException.class,
219219
() -> newConsumer(config));
220-
assertTrue(ce.getMessage().contains("Failed to construct Kafka share consumer"), "Unexpected exception message: " + ce.getMessage());
221-
assertTrue(ce.getCause().getMessage().contains("Class an.invalid.class cannot be found"), "Unexpected cause: " + ce.getCause());
220+
assertTrue(ce.getMessage().contains("Failed to construct Kafka share consumer"), "Unexpected exception message: " + ce.getMessage());
221+
assertTrue(ce.getCause().getMessage().contains("Class an.invalid.class cannot be found"), "Unexpected cause: " + ce.getCause());
222222

223-
boolean npeLogged = appender.getEvents().stream()
223+
boolean npeLogged = appender.getEvents().stream()
224224
.flatMap(event -> event.getThrowableInfo().stream())
225225
.anyMatch(str -> str.contains("NullPointerException"));
226226

227-
assertFalse(npeLogged, "Unexpected NullPointerException during consumer construction");
227+
assertFalse(npeLogged, "Unexpected NullPointerException during consumer construction");
228+
}
228229
}
229230

230231
@Test

0 commit comments

Comments
 (0)