Skip to content

Commit 6802ecb

Browse files
authored
Merge pull request #33 from jimjam-slam:fix-importcleanup
Cleanup old OJS injection code
2 parents 2ef67b8 + 6e06a00 commit 6802ecb

File tree

4 files changed

+11
-24
lines changed

4 files changed

+11
-24
lines changed

NEWS.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## quarto-svelte 2.0.1
2+
3+
- Improvement: extraneous OJS import code is removed from bootstrapping script
4+
15
## quarto-svelte 2.0.0
26

37
- Rename Sverto to quarto-svelte

_extensions/quarto-svelte/_extension.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
title: quarto-svelte
22
author: James Goldie
3-
version: 2.0.0
3+
version: 2.0.1
44
quarto-version: ">=1.5.46"
55
contributes:
66
filters:

_extensions/quarto-svelte/quarto-svelte.lua

Lines changed: 2 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -36,28 +36,7 @@ function inject_svelte_and_compile(m)
3636
-- either add text to start of body (and return nil), or return a rawblock
3737
-- %s: compiled svelte js path
3838
-- %s: obj_name
39-
local svelte_js_import_template = [[
40-
<script type="module">
41-
42-
// when the doc is ready, find quarto's ojs and inject svelte import
43-
document.addEventListener("DOMContentLoaded", () => {
44-
45-
import("%s").then(svelteModule => {
46-
47-
const ojsModule = window._ojs?.ojsConnector?.mainModule
48-
if (ojsModule === undefined) {
49-
console.error("Quarto OJS module not found")
50-
}
51-
52-
// TODO - check to see if there's already a variable with that name
53-
const quartoSvelteImport = ojsModule?.variable()
54-
quartoSvelteImport?.define("%s", svelteModule)
55-
56-
})
57-
58-
})
59-
</script>
60-
]]
39+
local svelte_js_import_template = '<script src="%s" type="module"></script>'
6140

6241
-- abort if quarto-svelte.use is not a string or a list of MetaInlines
6342
local quarto_svelte_use = util.get_svelte_paths_from_meta(m)
@@ -80,7 +59,7 @@ function inject_svelte_and_compile(m)
8059

8160
-- ... and inject the ojs init code for it
8261
local svelte_insert = string.format(svelte_js_import_template,
83-
web_path, obj_name)
62+
web_path)
8463
quarto.doc.include_text("before-body", svelte_insert)
8564

8665
-- finally, if we're rendering a single doc (not in a project),

docs/news.qmd

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@ title: News
33
date: last-modified
44
---
55

6+
## quarto-svelte 2.0.1
7+
8+
- Improvement: extraneous OJS import code is removed from bootstrapping script
9+
610
## quarto-svelte 2.0.0
711

812
- Rename Sverto to quarto-svelte

0 commit comments

Comments
 (0)