MB-54666: Move StorageProperties from kvstore.h to ep_types.h

Change-Id: Icb8464b22ecac9188eec5e58d061967fb33eedde
Reviewed-on: https://review.couchbase.org/c/kv_engine/+/184634
Well-Formed: Restriction Checker
Tested-by: Build Bot <[email protected]>
Reviewed-by: Trond Norbye <[email protected]>

Author: paolococchi

engines/ep/src/ep_types.h

@@ -291,6 +291,77 @@ enum class VBucketStatsDetailLevel {
     Full, // All the vbucket stats
 };
 
+/**
+ * Properties of the storage layer.
+ */
+class StorageProperties {
+public:
+    enum class ByIdScan : bool { Yes, No };
+
+    /**
+     * Will the KVStore de-dupe items such that only the highest seqno for any
+     * given key in a single flush batch is persisted?
+     */
+    enum class AutomaticDeduplication : bool { Yes, No };
+
+    /**
+     * Will the KVStore count items in the prepare namespace (and update the
+     * values appropriately in the vbstate)
+     */
+    enum class PrepareCounting : bool { Yes, No };
+
+    /**
+     * Will the KVStore make callbacks with stale (superseded) items during
+     * compaction?
+     */
+    enum class CompactionStaleItemCallbacks : bool { Yes, No };
+
+    /**
+     * Does the KVStore support history retention (suitable for change streams)
+     */
+    enum class HistoryRetentionAvailable : bool { Yes, No };
+
+    StorageProperties(ByIdScan byIdScan,
+                      AutomaticDeduplication automaticDeduplication,
+                      PrepareCounting prepareCounting,
+                      CompactionStaleItemCallbacks compactionStaleItemCallbacks,
+                      HistoryRetentionAvailable historyRetentionAvailable)
+        : byIdScan(byIdScan),
+          automaticDeduplication(automaticDeduplication),
+          prepareCounting(prepareCounting),
+          compactionStaleItemCallbacks(compactionStaleItemCallbacks),
+          historyRetentionAvailable(historyRetentionAvailable) {
+    }
+
+    bool hasByIdScan() const {
+        return byIdScan == ByIdScan::Yes;
+    }
+
+    bool hasAutomaticDeduplication() const {
+        return automaticDeduplication == AutomaticDeduplication::Yes;
+    }
+
+    bool hasPrepareCounting() const {
+        return prepareCounting == PrepareCounting::Yes;
+    }
+
+    bool hasCompactionStaleItemCallbacks() const {
+        return compactionStaleItemCallbacks ==
+               CompactionStaleItemCallbacks::Yes;
+    }
+
+    bool canRetainHistory() const {
+        return historyRetentionAvailable == HistoryRetentionAvailable::Yes;
+    }
+
+private:
+    ByIdScan byIdScan;
+    AutomaticDeduplication automaticDeduplication;
+    PrepareCounting prepareCounting;
+    CompactionStaleItemCallbacks compactionStaleItemCallbacks;
+    HistoryRetentionAvailable historyRetentionAvailable;
+};
+
 namespace cb {
 
 /**

engines/ep/src/kvstore/kvstore.h

@@ -654,83 +654,6 @@ class KVStoreStats {
     }
 };
 
-/**
- * Properties of the storage layer.
- *
- * If concurrent filesystem access is possible, maxConcurrency() will
- * be greater than one.  One will need to determine whether more than
- * one writer is possible as well as whether more than one reader is
- * possible.
- */
-class StorageProperties {
-public:
-    enum class ByIdScan : bool { Yes, No };
-
-    /**
-     * Will the KVStore de-dupe items such that only the highest seqno for any
-     * given key in a single flush batch is persisted?
-     */
-    enum class AutomaticDeduplication : bool { Yes, No };
-
-    /**
-     * Will the KVStore count items in the prepare namespace (and update the
-     * values appropriately in the vbstate)
-     */
-    enum class PrepareCounting : bool { Yes, No };
-
-    /**
-     * Will the KVStore make callbacks with stale (superseded) items during
-     * compaction?
-     */
-    enum class CompactionStaleItemCallbacks : bool { Yes, No };
-
-    /**
-     * Does the KVStore support history retention (suitable for change streams)
-     */
-    enum class HistoryRetentionAvailable : bool { Yes, No };
-
-    StorageProperties(ByIdScan byIdScan,
-                      AutomaticDeduplication automaticDeduplication,
-                      PrepareCounting prepareCounting,
-                      CompactionStaleItemCallbacks compactionStaleItemCallbacks,
-                      HistoryRetentionAvailable historyRetentionAvailable)
-        : byIdScan(byIdScan),
-          automaticDeduplication(automaticDeduplication),
-          prepareCounting(prepareCounting),
-          compactionStaleItemCallbacks(compactionStaleItemCallbacks),
-          historyRetentionAvailable(historyRetentionAvailable) {
-    }
-
-    bool hasByIdScan() const {
-        return byIdScan == ByIdScan::Yes;
-    }
-
-    bool hasAutomaticDeduplication() const {
-        return automaticDeduplication == AutomaticDeduplication::Yes;
-    }
-
-    bool hasPrepareCounting() const {
-        return prepareCounting == PrepareCounting::Yes;
-    }
-
-    bool hasCompactionStaleItemCallbacks() const {
-        return compactionStaleItemCallbacks ==
-               CompactionStaleItemCallbacks::Yes;
-    }
-
-    bool canRetainHistory() const {
-        return historyRetentionAvailable == HistoryRetentionAvailable::Yes;
-    }
-
-private:
-    ByIdScan byIdScan;
-    AutomaticDeduplication automaticDeduplication;
-    PrepareCounting prepareCounting;
-    CompactionStaleItemCallbacks compactionStaleItemCallbacks;
-    HistoryRetentionAvailable historyRetentionAvailable;
-};
-
-
 /**
  * Base class for some KVStores that implements common functionality.
  */