MB-54516: Construct VB::Manifest using KVStore derived history value

In the KVStore driven constructor, the meta.canDeduplicate value is
the correct value to use.

Change-Id: Id7fe3f7bf79be2fb2116951f14c9aa0e0adca52a
Reviewed-on: https://review.couchbase.org/c/kv_engine/+/184800
Well-Formed: Restriction Checker
Tested-by: Jim Walker <[email protected]>
Reviewed-by: Paolo Cocchi <[email protected]>

Author: jimwwalker

engines/ep/src/collections/vbucket_manifest.cc

@@ -56,7 +56,7 @@ Manifest::Manifest(std::shared_ptr<Manager> manager,
         addNewCollectionEntry({meta.sid, meta.cid},
                               meta.name,
                               meta.maxTtl,
-                              bucketManifest->getCanDeduplicate(meta.cid),
+                              meta.canDeduplicate,
                               e.startSeqno);
     }
 }

engines/ep/tests/module_tests/collections/collections_kvstore_test.cc

@@ -300,6 +300,19 @@ TEST(CollectionsKVStoreTest, test_KVStore_comparison) {
     m2.scopes.push_back(
             OpenScope{0, Collections::ScopeMetaData{ScopeID{91}, "s91"}});
     EXPECT_NE(m1, m2);
+
+    m1 = m2;
+    EXPECT_EQ(m1, m2);
+    // Add a collection but check a different history state is noticed
+    auto c1 = Collections::CollectionMetaData{ScopeID{88},
+                                              CollectionID{102},
+                                              "c1",
+                                              {},
+                                              CanDeduplicate::Yes};
+    m1.collections.push_back(OpenCollection{0, c1});
+    c1.canDeduplicate = CanDeduplicate::No;
+    m2.collections.push_back(OpenCollection{0, c1});
+    EXPECT_NE(m1, m2);
 }
 
 TEST_P(CollectionsKVStoreTest, initial_meta) {
@@ -407,6 +420,13 @@ TEST_P(CollectionsKVStoreTest, create_and_modify_same_batch) {
     applyAndCheck(cm);
 }
 
+// Check that the history state persists and comes back
+TEST_P(CollectionsKVStoreTest, one_update_with_history) {
+    CollectionsManifest cm;
+    cm.add(CollectionEntry::vegetable, {}, true);
+    applyAndCheck(cm);
+}
+
 // Related to MB-44098 test that we fail to generate 'corrupt' collection or
 // scope metadata (i.e duplicate entries). This is not the sequence of steps
 // that lead to warmup failure seen in the MB, but tests that we can detect