MB-55199: Remove duplicate value_t docBody from MagmaRequest

The value is already referenced by the parent IORequest

Change-Id: Ia998980182795a6e741824bb478d474af9ac6d8d
Reviewed-on: https://review.couchbase.org/c/kv_engine/+/185328
Tested-by: Jim Walker <[email protected]>
Reviewed-by: Paolo Cocchi <[email protected]>

Author: jimwwalker

engines/ep/src/kvstore/magma-kvstore/magma-kvstore.cc

@@ -176,9 +176,7 @@ static bool isAbort(const Slice& keySlice, const Slice& metaSlice) {
 } // namespace magmakv
 
 MagmaRequest::MagmaRequest(queued_item it)
-    : IORequest(std::move(it)),
-      docMeta(magmakv::makeMetaData(*item).encode()),
-      docBody(item->getValue()) {
+    : IORequest(std::move(it)), docMeta(magmakv::makeMetaData(*item).encode()) {
 }
 
 std::string MagmaRequest::to_string() {

engines/ep/src/kvstore/magma-kvstore/magma-kvstore_iorequest.h

@@ -40,11 +40,11 @@ class MagmaRequest : public IORequest {
     }
 
     size_t getBodySize() const {
-        return docBody ? docBody->valueSize() : 0;
+        return getItem().getNBytes();
     }
 
     char* getBodyData() const {
-        return docBody ? const_cast<char*>(docBody->getData()) : nullptr;
+        return const_cast<char*>(getItem().getData());
     }
 
     void markOldItemAlive() {
@@ -71,7 +71,6 @@ class MagmaRequest : public IORequest {
 
 private:
     std::string docMeta;
-    value_t docBody;
 
     // Is there an old item which is alive? i.e. this item is replacing
     // a non-deleted item.