Skip to content

Commit 50a8f84

Browse files
authored
Update FAISS patch for RMM memory resource header migration (rapidsai#1566)
Updates FAISS patch for RMM memory resource header migration. xref: rapidsai/rmm#2141 Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Divye Gala (https://github.com/divyegala) URL: rapidsai#1566
1 parent 923da8d commit 50a8f84

File tree

3 files changed

+27
-11
lines changed

3 files changed

+27
-11
lines changed
Lines changed: 23 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,17 +11,33 @@ index c82c73e7d..b9100c272 100644
1111

1212
auto resImpl = prov->getResources();
1313
auto res = resImpl.get();
14+
diff --git a/faiss/gpu/GpuResources.h b/faiss/gpu/GpuResources.h
15+
index c0c851a89..61d9d4dbe 100644
16+
--- a/faiss/gpu/GpuResources.h
17+
+++ b/faiss/gpu/GpuResources.h
18+
@@ -33,7 +33,7 @@
19+
20+
#if defined USE_NVIDIA_CUVS
21+
#include <raft/core/device_resources.hpp>
22+
-#include <rmm/mr/device/device_memory_resource.hpp>
23+
+#include <rmm/mr/device_memory_resource.hpp>
24+
#endif
25+
26+
namespace faiss {
1427
diff --git a/faiss/gpu/StandardGpuResources.cpp b/faiss/gpu/StandardGpuResources.cpp
15-
index 649b7cb5c..765fdb3d0 100644
28+
index 649b7cb5c..622443044 100644
1629
--- a/faiss/gpu/StandardGpuResources.cpp
1730
+++ b/faiss/gpu/StandardGpuResources.cpp
18-
@@ -24,8 +24,8 @@
31+
@@ -23,9 +23,9 @@
32+
1933
#if defined USE_NVIDIA_CUVS
2034
#include <raft/core/device_resources.hpp>
21-
#include <rmm/mr/device/managed_memory_resource.hpp>
22-
+#include <rmm/mr/pinned_host_memory_resource.hpp>
23-
#include <rmm/mr/device/per_device_resource.hpp>
35+
-#include <rmm/mr/device/managed_memory_resource.hpp>
36+
-#include <rmm/mr/device/per_device_resource.hpp>
2437
-#include <rmm/mr/host/pinned_memory_resource.hpp>
38+
+#include <rmm/mr/managed_memory_resource.hpp>
39+
+#include <rmm/mr/per_device_resource.hpp>
40+
+#include <rmm/mr/pinned_host_memory_resource.hpp>
2541
#include <memory>
2642
#endif
2743

@@ -80,15 +96,15 @@ index 649b7cb5c..765fdb3d0 100644
8096
auto err = cudaFree(p);
8197
FAISS_ASSERT_FMT(
8298
diff --git a/faiss/gpu/StandardGpuResources.h b/faiss/gpu/StandardGpuResources.h
83-
index f23ca19d8..c43926fce 100644
99+
index f23ca19d8..3ba606606 100644
84100
--- a/faiss/gpu/StandardGpuResources.h
85101
+++ b/faiss/gpu/StandardGpuResources.h
86102
@@ -25,7 +25,8 @@
87103

88104
#if defined USE_NVIDIA_CUVS
89105
#include <raft/core/device_resources.hpp>
90106
-#include <rmm/mr/host/pinned_memory_resource.hpp>
91-
+#include <rmm/mr/device/device_memory_resource.hpp>
107+
+#include <rmm/mr/device_memory_resource.hpp>
92108
+#include <rmm/mr/pinned_host_memory_resource.hpp>
93109
#endif
94110

cpp/cmake/patches/faiss_override.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
"git_tag": "v1.12.0",
77
"patches" : [
88
{
9-
"file" : "${current_json_dir}/faiss.diff",
10-
"issue" : "Multiple fixes for cuVS compatibility",
9+
"file" : "${current_json_dir}/faiss-25.12.diff",
10+
"issue" : "Multiple fixes for cuVS and RMM compatibility",
1111
"fixed_in" : ""
1212
}
1313
]

examples/cpp/src/cagra_hnsw_ace_example.cu

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
#include <cuvs/neighbors/cagra.hpp>
1515
#include <cuvs/neighbors/hnsw.hpp>
1616

17-
#include <rmm/mr/device/device_memory_resource.hpp>
18-
#include <rmm/mr/device/pool_memory_resource.hpp>
17+
#include <rmm/mr/device_memory_resource.hpp>
18+
#include <rmm/mr/pool_memory_resource.hpp>
1919

2020
#include "common.cuh"
2121

0 commit comments

Comments
 (0)