Updated Accounts and Config Tests

- Added view model validation tests
- Added update and change password tests

Author: jioo

tests/Api/ClassData/InvalidConfigModels.cs

@@ -0,0 +1,81 @@
+using System.Collections;
+using System.Collections.Generic;
+using WebApi.Features.Config;
+
+namespace Test.Api.ClassData
+{
+    public class InvalidConfigModels : IEnumerable<object[]>
+    {
+        public IEnumerator<object[]> GetEnumerator()
+        {
+            
+            // error: Time In is required
+            yield return new object[] 
+            { 
+                new ConfigViewModel 
+                { 
+                    TimeIn = "",
+                    TimeOut = "17:00",
+                    GracePeriod = 10,
+                } 
+            };
+            
+            // error: Time Out is required
+            yield return new object[] 
+            { 
+                new ConfigViewModel 
+                { 
+                    TimeIn = "25:00",
+                    TimeOut = "",
+                    GracePeriod = 10,
+                } 
+            };
+
+            // error: Invalid TimeIn
+            yield return new object[] 
+            { 
+                new ConfigViewModel 
+                { 
+                    TimeIn = "25:00",
+                    TimeOut = "17:00",
+                    GracePeriod = 10,
+                } 
+            };
+
+            // error: Invalid TimeOut
+            yield return new object[] 
+            { 
+                new ConfigViewModel 
+                { 
+                    TimeIn = "09:00",
+                    TimeOut = "25:00",
+                    GracePeriod = 10,
+                }
+            };
+
+            // error: Invalid GracePeriod
+            yield return new object[] 
+            { 
+                new ConfigViewModel 
+                { 
+                    TimeIn = "09:00",
+                    TimeOut = "17:00",
+                    GracePeriod = 60,
+                }
+            };
+
+            // error: Invalid GracePeriod
+            yield return new object[] 
+            { 
+                new ConfigViewModel 
+                { 
+                    TimeIn = "09:00",
+                    TimeOut = "17:00",
+                    GracePeriod = -1,
+                }
+            };
+        }
+
+        IEnumerator IEnumerable.GetEnumerator() => GetEnumerator();
+    }
+}

tests/Api/IntegrationTests/AccountsTest.cs

@@ -1,9 +1,11 @@
 using System.Linq;
 using System.Net;
 using System.Net.Http;
+using System.Text;
 using System.Threading.Tasks;
 using Microsoft.AspNetCore.Identity;
 using Microsoft.EntityFrameworkCore;
+using Newtonsoft.Json;
 using Test.Api.ClassData;
 using Test.Api.Models;
 using Test.Api.Utils;
@@ -84,5 +86,135 @@ public async Task GivenInvalidModels_WhenPostRegisterRequest_ThenReturnBadReques
             // Assert
             Assert.Equal(HttpStatusCode.BadRequest, response.StatusCode);
         }
+
+        [Fact]
+        public async Task GivenEmployeeModel_WhenPutUpdatePasswordRequest_ThenReturnOk()
+        {
+            // Arrange
+            const string NEW_PASSWORD = "654321";
+
+            var model = _fixture.Context.Users.ToList().ElementAt(5);
+            var viewModel = new UpdatePasswordViewModel
+            {
+                UserName = model.UserName,
+                Password = NEW_PASSWORD,
+            };
+
+            // Act
+            var response = await _fixture.Client.PutAsJsonAsync($"{API_URL}/update-password", viewModel);
+
+            // Assert
+            response.EnsureSuccessStatusCode();
+
+            var assertLogin = await AuthExtensions.GetJwt(
+                _fixture, 
+                new LoginViewModel
+                {
+                    UserName = model.UserName,
+                    Password = NEW_PASSWORD,
+                }
+            );
+            Assert.NotEmpty(assertLogin);
+        }
+
+        [Theory]
+        [InlineData("", "valid_password")]
+        [InlineData("valid_username", "")]
+        [InlineData("invalid_username", "valid_password")]
+        // error: min length for password 6
+        [InlineData("valid_username", "12345")] 
+        public async Task GivenInvalidViewModels_WhenPutUpdatePasswordRequest_ThenReturnBadRequest(string username, string password)
+        {
+            // Arrange
+            var viewModel = new UpdatePasswordViewModel
+            {
+                UserName = username,
+                Password = password,
+            };
+
+            if (username == "valid_username")
+            {
+                var validUserName = _fixture.Context.Users.Last().UserName;
+                viewModel.UserName = validUserName;
+            }
+
+            // Act
+            var response = await _fixture.Client.PutAsJsonAsync($"{API_URL}/update-password", viewModel);
+
+            // Assert
+            Assert.Equal(HttpStatusCode.BadRequest, response.StatusCode);
+        }
+
+        [Fact]
+        public async Task GivenAuthByEmployee_WhenPutChangePasswordRequest_ThenReturnOk()
+        {
+            // Arrange
+            const string NEW_PASSWORD = "654321";
+            const string DEFAULT_PASSWORD = DefaultAdmin.Password;
+
+            var model = _fixture.Context.Users.Last();
+            var viewModel = await Task.Run(() => JsonConvert.SerializeObject(
+                new ChangePasswordViewModel
+                {
+                    OldPassword = DEFAULT_PASSWORD,
+                    NewPassword = NEW_PASSWORD,
+                }
+            ));
+
+            // Act
+            var request = new HttpRequestMessage(HttpMethod.Put, $"{API_URL}/change-password");
+            // Send request as Employee
+            request.Content = new StringContent(viewModel, Encoding.UTF8, "application/json");
+
+            await AuthExtensions.SetupRequestAuth(
+                request, 
+                _fixture, 
+                new LoginViewModel 
+                {   
+                    UserName = model.UserName,
+                    Password = DEFAULT_PASSWORD,
+                }
+            );
+
+            var response = await _fixture.Client.SendAsync(request);
+
+            // Assert
+            response.EnsureSuccessStatusCode();
+
+            var assertLogin = await AuthExtensions.GetJwt(
+                _fixture, 
+                new LoginViewModel
+                {
+                    UserName = model.UserName,
+                    Password = NEW_PASSWORD,
+                }
+            );
+            Assert.NotEmpty(assertLogin);
+        }
+
+        [Theory]
+        [InlineData("", "valid_password")]
+        [InlineData("valid_old_password", "")]
+        [InlineData("invalid_old_password", "valid_password")]
+        // error: min length for password 6
+        [InlineData("valid_old_password", "12345")] 
+        public async Task GivenInvalidModels_WhenPutChangePasswordRequest_ThenReturnBadRequest(string oldPassword, string newPassword)
+        {
+            // Arrange
+            var viewModel = new ChangePasswordViewModel
+            {
+                OldPassword = oldPassword,
+                NewPassword = newPassword,
+            };
+
+            if (oldPassword == "valid_old_password")
+                viewModel.OldPassword = DefaultAdmin.Password;
+            
+            // Act
+            var response = await _fixture.Client.PutAsJsonAsync($"{API_URL}/change-password", viewModel);
+
+            // Assert
+            Assert.Equal(HttpStatusCode.BadRequest, response.StatusCode);
+        }
     }
 }

tests/Api/IntegrationTests/ConfigTest.cs

@@ -1,7 +1,9 @@
 using System.Linq;
+using System.Net;
 using System.Net.Http;
 using System.Threading.Tasks;
 using Newtonsoft.Json;
+using Test.Api.ClassData;
 using Test.Api.Utils;
 using WebApi.Constants;
 using WebApi.Features.Auth;
@@ -53,7 +55,7 @@ public async Task PutRequest_ThenReturnOk()
             var model = _fixture.Context.Config.First();
             model.TimeIn = "09:30";
             model.TimeOut = "17:15";
-            model.GracePeriod = "5";
+            model.GracePeriod = 5;
 
             // Act
             var response = await _fixture.Client.PutAsJsonAsync(API_URL, model);
@@ -67,6 +69,15 @@ public async Task PutRequest_ThenReturnOk()
             Assert.Equal(updatedModel.GracePeriod, model.GracePeriod);
         }
 
-        // TODO: Add time validation in `ConfigViewModel`
+        [Theory]
+        [ClassData(typeof(InvalidConfigModels))]
+        public async Task GivenInvalidConfigModels_WhenPutRequest_ThenReutrnBadRequest(ConfigViewModel viewModel)
+        {
+            // Act
+            var response = await _fixture.Client.PutAsJsonAsync(API_URL, viewModel);
+
+            // Assert
+            Assert.Equal(HttpStatusCode.BadRequest, response.StatusCode);
+        }
     }
 }