Show available version

Author: jiuka

agent_based/jb_fls.py

@@ -59,9 +59,9 @@ def check_jb_fls(params, section):
         yield Result(state=State.WARN, summary='Not healthy %s' % section.get('health', 'Unknown'))
 
     yield Result(state=State.OK, summary='Version: %s' % section.get('currentVersion', 'Unknown'))
-    if section.get('updateAvailable', 'False') != 'False' and params.get('updateAvailable', 1):
+    if section.get('updateAvailable', 'False') != 'False' and params.get('updateAvailable', 1) is not None:
         updateAvailableStatus = State(params.get('updateAvailable', 1))
-        yield Result(state=updateAvailableStatus, summary='update available')
+        yield Result(state=updateAvailableStatus, summary='update available to %s' % section.get('latestVersion', 'Unknown'))
 
     for line in section.get('connection', []):
         state = State.OK if line[1] == 'OK' else State.CRIT

tests/unit/cmk/base/plugins/agent_based/test_jb_fls.py

@@ -94,7 +94,7 @@ def test_discovery_jb_fls(section, result):
         [
             Result(state=State.OK, summary='Server: fooBar https://host:1212/ '),
             Result(state=State.OK, summary='Version: 1.2.3'),
-            Result(state=State.WARN, summary='update available'),
+            Result(state=State.WARN, summary='update available to 1.2.4'),
             Result(state=State.OK, notice='Connection to https://account.jetbrains.com is OK'),
             Result(state=State.OK, summary='Last call home: 21 minutes 0 seconds'),
             Metric('age', 1260),