Skip to content

Commit 8b62fec

Browse files
committed
add component owner for aws sampler, run lint
1 parent 2006f5d commit 8b62fec

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

.github/component_owners.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,9 @@ components:
3232
propagator/opentelemetry-propagator-aws-xray:
3333
- NathanielRN
3434

35+
sampler/opentelemetry-sampler-aws-xray:
36+
- jj22ee
37+
3538
sdk-extension/opentelemetry-sdk-extension-aws:
3639
- NathanielRN
3740
- Kausik-A

sampler/opentelemetry-sampler-aws-xray/src/opentelemetry/samplers/aws/_sampling_rule_applier.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ def __init__(
3535
statistics: Optional[_SamplingStatisticsDocument] = None,
3636
target: Optional[_SamplingTarget] = None,
3737
):
38-
self.__client_id = client_id
38+
self.__client_id = client_id # pylint: disable=W0238
3939
self._clock = clock
4040
self.sampling_rule = sampling_rule
4141

sampler/opentelemetry-sampler-aws-xray/src/opentelemetry/samplers/aws/aws_xray_remote_sampler.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ def __init__(
130130
)
131131
polling_interval = DEFAULT_RULES_POLLING_INTERVAL_SECONDS
132132

133-
self.__client_id = self.__generate_client_id()
133+
self.__client_id = self.__generate_client_id() # pylint: disable=W0238
134134
self._clock = _Clock()
135135
self.__xray_client = _AwsXRaySamplingClient(
136136
endpoint, log_level=log_level
@@ -140,12 +140,12 @@ def __init__(
140140
self.__rule_polling_jitter = random.uniform(0.0, 5.0)
141141

142142
if resource is not None:
143-
self.__resource = resource
143+
self.__resource = resource # pylint: disable=W0238
144144
else:
145145
_logger.warning(
146146
"OTel Resource provided is `None`. Defaulting to empty resource"
147147
)
148-
self.__resource = Resource.get_empty()
148+
self.__resource = Resource.get_empty() # pylint: disable=W0238
149149

150150
# Schedule the next rule poll now
151151
# Python Timers only run once, so they need to be recreated for every poll
@@ -180,7 +180,7 @@ def get_description(self) -> str:
180180
return description
181181

182182
def __get_and_update_sampling_rules(self) -> None:
183-
sampling_rules = self.__xray_client.get_sampling_rules() # noqa: F841
183+
sampling_rules = self.__xray_client.get_sampling_rules() # pylint: disable=W0612 # noqa: F841
184184
# (TODO) update rules cache with sampling rules
185185

186186
def __start_sampling_rule_poller(self) -> None:

0 commit comments

Comments
 (0)