remove unused clock and client_id

Author: jj22ee

sdk-extension/opentelemetry-sdk-extension-aws/src/opentelemetry/sdk/extension/aws/trace/sampler/_sampling_rule.py

@@ -18,6 +18,7 @@
 
 from __future__ import annotations
 
+
 # Disable snake_case naming style so this class can match the sampling rules response from X-Ray
 # pylint: disable=invalid-name
 class _SamplingRule:

sdk-extension/opentelemetry-sdk-extension-aws/src/opentelemetry/sdk/extension/aws/trace/sampler/aws_xray_remote_sampler.py

@@ -31,7 +31,6 @@
     DEFAULT_SAMPLING_PROXY_ENDPOINT,
     _AwsXRaySamplingClient,
 )
-from opentelemetry.sdk.extension.aws.trace.sampler._clock import _Clock
 from opentelemetry.sdk.resources import Resource
 from opentelemetry.sdk.trace.sampling import (
     Decision,
@@ -137,8 +136,6 @@ def __init__(
             )
             polling_interval = DEFAULT_RULES_POLLING_INTERVAL_SECONDS
 
-        self.__client_id = self.__generate_client_id()  # pylint: disable=W0238
-        self._clock = _Clock()
         self.__xray_client = _AwsXRaySamplingClient(
             endpoint, log_level=log_level
         )
@@ -201,10 +198,3 @@ def __start_sampling_rule_poller(self) -> None:
         )
         self._rules_timer.daemon = True
         self._rules_timer.start()
-
-    def __generate_client_id(self) -> str:
-        hex_chars = "0123456789abcdef"
-        client_id_array: list[str] = []
-        for _ in range(0, 24):
-            client_id_array.append(random.choice(hex_chars))
-        return "".join(client_id_array)

sdk-extension/opentelemetry-sdk-extension-aws/tests/trace/sampler/test_aws_xray_remote_sampler.py

@@ -104,10 +104,6 @@ def test_create_remote_sampler_with_empty_resource(
         self.assertIsNotNone(
             self.rs._root._root._InternalAwsXRayRemoteSampler__resource
         )
-        self.assertTrue(
-            len(self.rs._root._root._InternalAwsXRayRemoteSampler__client_id),
-            24,
-        )
 
     @patch(
         "opentelemetry.sdk.extension.aws.trace.sampler._aws_xray_sampling_client._AwsXRaySamplingClient.get_sampling_rules",
@@ -198,7 +194,7 @@ def test_create_remote_sampler_with_all_fields_populated(
         "opentelemetry.sdk.extension.aws.trace.sampler._aws_xray_sampling_client._AwsXRaySamplingClient.get_sampling_rules",
         return_value=None,
     )
-    def test_get_description(self, sdf) -> str:
+    def test_get_description(self, mocked_get_sampling_rules) -> str:
         self.rs: _AwsXRayRemoteSampler = _AwsXRayRemoteSampler(
             resource=Resource.create({"service.name": "dummy_name"})
         )