Allow instanceof to pattern matching cleanup to check inner ifs (eclipse-jdt#2108)

- fix PatternMatchingForInstanceofFixCore to continue parsing inner
  ifs
- add new tests to CleanUpTest16
- fixes eclipse-jdt#2105

Author: jjohnstn

org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/fix/PatternMatchingForInstanceofFixCore.java

@@ -220,7 +220,7 @@ public boolean visit(CastExpression node) {
 
 					if (collector.hasResult()) {
 						fResult.add(collector.build());
-						return false;
+						return true;
 					}
 				}
 				return true;

org.eclipse.jdt.ui.tests/ui/org/eclipse/jdt/ui/tests/quickfix/CleanUpTest16.java

@@ -631,6 +631,29 @@ public int foo7(Object o) {
 					String s = (String)o;
 					return !(o instanceof String) ? 0 : ((String)o).length();
 				}
+				public int foo8(Object x, Object y, boolean b) {
+					if (b || !(x instanceof String) || ((String)x).length() > 3) {
+						if (y instanceof Double) {
+							Double d = (Double)y;
+							System.out.println(d.isNaN());
+						}
+						return 7;
+					}
+					String s = (String)x;
+					return s.length();
+				}
+				public int foo9(Object x, Object y, boolean b) {
+					if (b || !(x instanceof String) || ((String)x).length() > 3) {
+						if (!(y instanceof Double)) {
+							return 6;
+						}
+						Double d = (Double)y;
+						System.out.println(d.isNaN());
+						return 7;
+					}
+					String s = (String)x;
+					return s.length();
+				}
 			}
 			""";
 		ICompilationUnit cu= pack.createCompilationUnit("E.java", given, false, null);
@@ -712,6 +735,25 @@ public int foo7(Object o) {
 						}
 						return !(o instanceof String s2) ? 0 : s2.length();
 					}
+					public int foo8(Object x, Object y, boolean b) {
+						if (b || !(x instanceof String s) || s.length() > 3) {
+							if (y instanceof Double d) {
+								System.out.println(d.isNaN());
+							}
+							return 7;
+						}
+						return s.length();
+					}
+					public int foo9(Object x, Object y, boolean b) {
+						if (b || !(x instanceof String s) || s.length() > 3) {
+							if (!(y instanceof Double d)) {
+								return 6;
+							}
+							System.out.println(d.isNaN());
+							return 7;
+						}
+						return s.length();
+					}
 				}
 				""";