Remove obsolete specification of hover images (eclipse-jdt#2189)

HeikoKlare · web-flow · commit 877c999fdc68 · 2025-04-29T12:52:28.000-04:00
Specifying hover images that are the same as the usual enabled-version
images is unnecessary and the usage of different hover images has been
obsolete for quite some time in Eclipse platform.

This change removes remaining specifications of hover images.
diff --git a/org.eclipse.jdt.astview/src/org/eclipse/jdt/astview/ASTViewImages.java b/org.eclipse.jdt.astview/src/org/eclipse/jdt/astview/ASTViewImages.java
@@ -15,15 +15,15 @@
 
 import java.net.URL;
 
+import org.osgi.framework.Bundle;
+
 import org.eclipse.core.runtime.FileLocator;
 import org.eclipse.core.runtime.IPath;
 import org.eclipse.core.runtime.Path;
 
 import org.eclipse.jface.action.IAction;
 import org.eclipse.jface.resource.ImageDescriptor;
 
-import org.osgi.framework.Bundle;
-
 public class ASTViewImages {
 
 	private static final IPath ICONS_PATH= new Path("$nl$/icons"); //$NON-NLS-1$
@@ -47,7 +47,6 @@ public static void setImageDescriptors(IAction action, String type) {
 
 		id= create("e", type); //$NON-NLS-1$
 		if (id != null) {
-			action.setHoverImageDescriptor(id);
 			action.setImageDescriptor(id);
 		} else {
 			action.setImageDescriptor(ImageDescriptor.getMissingImageDescriptor());
diff --git a/org.eclipse.jdt.junit/src/org/eclipse/jdt/internal/junit/ui/CompareResultsAction.java b/org.eclipse.jdt.junit/src/org/eclipse/jdt/internal/junit/ui/CompareResultsAction.java
@@ -32,7 +32,6 @@ public CompareResultsAction(FailureTrace view) {
 		setToolTipText(JUnitMessages.CompareResultsAction_tooltip);
 
 		setDisabledImageDescriptor(JUnitPlugin.getImageDescriptor("dlcl16/compare.png"));  //$NON-NLS-1$
-		setHoverImageDescriptor(JUnitPlugin.getImageDescriptor("elcl16/compare.svg"));  //$NON-NLS-1$
 		setImageDescriptor(JUnitPlugin.getImageDescriptor("elcl16/compare.svg"));  //$NON-NLS-1$
 		//PlatformUI.getWorkbench().getHelpSystem().setHelp(this, IJUnitHelpContextIds.ENABLEFILTER_ACTION);
 		fView= view;
diff --git a/org.eclipse.jdt.junit/src/org/eclipse/jdt/internal/junit/ui/EnableStackFilterAction.java b/org.eclipse.jdt.junit/src/org/eclipse/jdt/internal/junit/ui/EnableStackFilterAction.java
@@ -33,7 +33,6 @@ public EnableStackFilterAction(FailureTrace view) {
 		setToolTipText(JUnitMessages.EnableStackFilterAction_action_tooltip);
 
 		setDisabledImageDescriptor(JUnitPlugin.getImageDescriptor("dlcl16/cfilter.png")); //$NON-NLS-1$
-		setHoverImageDescriptor(JUnitPlugin.getImageDescriptor("elcl16/cfilter.svg")); //$NON-NLS-1$
 		setImageDescriptor(JUnitPlugin.getImageDescriptor("elcl16/cfilter.svg")); //$NON-NLS-1$
 		PlatformUI.getWorkbench().getHelpSystem().setHelp(this, IJUnitHelpContextIds.ENABLEFILTER_ACTION);
 
diff --git a/org.eclipse.jdt.junit/src/org/eclipse/jdt/internal/junit/ui/JUnitPlugin.java b/org.eclipse.jdt.junit/src/org/eclipse/jdt/internal/junit/ui/JUnitPlugin.java
@@ -153,7 +153,6 @@ private static void setImageDescriptors(IAction action, String type, String relP
 			action.setDisabledImageDescriptor(id);
 
 		ImageDescriptor descriptor= createImageDescriptor("e" + type, relPath, true); //$NON-NLS-1$
-		action.setHoverImageDescriptor(descriptor);
 		action.setImageDescriptor(descriptor);
 	}
 
diff --git a/org.eclipse.jdt.junit/src/org/eclipse/jdt/internal/junit/ui/ScrollLockAction.java b/org.eclipse.jdt.junit/src/org/eclipse/jdt/internal/junit/ui/ScrollLockAction.java
@@ -30,7 +30,6 @@ public ScrollLockAction(TestRunnerViewPart viewer) {
 		fRunnerViewPart= viewer;
 		setToolTipText(JUnitMessages.ScrollLockAction_action_tooltip);
 		setDisabledImageDescriptor(JUnitPlugin.getImageDescriptor("dlcl16/lock.png")); //$NON-NLS-1$
-		setHoverImageDescriptor(JUnitPlugin.getImageDescriptor("elcl16/lock.svg")); //$NON-NLS-1$
 		setImageDescriptor(JUnitPlugin.getImageDescriptor("elcl16/lock.svg")); //$NON-NLS-1$
 		PlatformUI.getWorkbench().getHelpSystem().setHelp(
 			this,
diff --git a/org.eclipse.jdt.junit/src/org/eclipse/jdt/internal/junit/ui/ShowNextFailureAction.java b/org.eclipse.jdt.junit/src/org/eclipse/jdt/internal/junit/ui/ShowNextFailureAction.java
@@ -22,7 +22,6 @@ class ShowNextFailureAction extends Action {
 	public ShowNextFailureAction(TestRunnerViewPart part) {
 		super(JUnitMessages.ShowNextFailureAction_label);
 		setDisabledImageDescriptor(JUnitPlugin.getImageDescriptor("dlcl16/select_next.png")); //$NON-NLS-1$
-		setHoverImageDescriptor(JUnitPlugin.getImageDescriptor("elcl16/select_next.svg")); //$NON-NLS-1$
 		setImageDescriptor(JUnitPlugin.getImageDescriptor("elcl16/select_next.svg")); //$NON-NLS-1$
 		setToolTipText(JUnitMessages.ShowNextFailureAction_tooltip);
 		fPart= part;
diff --git a/org.eclipse.jdt.junit/src/org/eclipse/jdt/internal/junit/ui/ShowPreviousFailureAction.java b/org.eclipse.jdt.junit/src/org/eclipse/jdt/internal/junit/ui/ShowPreviousFailureAction.java
@@ -22,7 +22,6 @@ class ShowPreviousFailureAction extends Action {
 	public ShowPreviousFailureAction(TestRunnerViewPart part) {
 		super(JUnitMessages.ShowPreviousFailureAction_label);
 		setDisabledImageDescriptor(JUnitPlugin.getImageDescriptor("dlcl16/select_prev.png")); //$NON-NLS-1$
-		setHoverImageDescriptor(JUnitPlugin.getImageDescriptor("elcl16/select_prev.svg")); //$NON-NLS-1$
 		setImageDescriptor(JUnitPlugin.getImageDescriptor("elcl16/select_prev.svg")); //$NON-NLS-1$
 		setToolTipText(JUnitMessages.ShowPreviousFailureAction_tooltip);
 		fPart= part;
diff --git a/org.eclipse.jdt.junit/src/org/eclipse/jdt/internal/junit/ui/ShowStackTraceInConsoleViewAction.java b/org.eclipse.jdt.junit/src/org/eclipse/jdt/internal/junit/ui/ShowStackTraceInConsoleViewAction.java
@@ -35,7 +35,6 @@ public ShowStackTraceInConsoleViewAction(FailureTrace view) {
 		setDescription(JUnitMessages.ShowStackTraceInConsoleViewAction_description);
 		setToolTipText(JUnitMessages.ShowStackTraceInConsoleViewAction_tooltip);
 
-		setHoverImageDescriptor(JUnitPlugin.getImageDescriptor("elcl16/open_console.svg")); //$NON-NLS-1$
 		setImageDescriptor(JUnitPlugin.getImageDescriptor("elcl16/open_console.svg")); //$NON-NLS-1$
 
 		fView= view;
diff --git a/org.eclipse.jdt.ui/ui refactoring/org/eclipse/jdt/internal/ui/refactoring/reorg/CopyToClipboardAction.java b/org.eclipse.jdt.ui/ui refactoring/org/eclipse/jdt/internal/ui/refactoring/reorg/CopyToClipboardAction.java
@@ -79,7 +79,6 @@ public CopyToClipboardAction(IWorkbenchSite site, Clipboard clipboard) {
 		ISharedImages workbenchImages= getWorkbenchSharedImages();
 		setDisabledImageDescriptor(workbenchImages.getImageDescriptor(ISharedImages.IMG_TOOL_COPY_DISABLED));
 		setImageDescriptor(workbenchImages.getImageDescriptor(ISharedImages.IMG_TOOL_COPY));
-		setHoverImageDescriptor(workbenchImages.getImageDescriptor(ISharedImages.IMG_TOOL_COPY));
 		update(getSelection());
 
 		PlatformUI.getWorkbench().getHelpSystem().setHelp(this, IJavaHelpContextIds.COPY_ACTION);
diff --git a/org.eclipse.jdt.ui/ui refactoring/org/eclipse/jdt/internal/ui/refactoring/reorg/CutAction.java b/org.eclipse.jdt.ui/ui refactoring/org/eclipse/jdt/internal/ui/refactoring/reorg/CutAction.java
@@ -46,7 +46,6 @@ public CutAction(IWorkbenchSite site) {
 		ISharedImages workbenchImages= ISharedImages.get();
 		setDisabledImageDescriptor(workbenchImages.getImageDescriptor(ISharedImages.IMG_TOOL_CUT_DISABLED));
 		setImageDescriptor(workbenchImages.getImageDescriptor(ISharedImages.IMG_TOOL_CUT));
-		setHoverImageDescriptor(workbenchImages.getImageDescriptor(ISharedImages.IMG_TOOL_CUT));
 
 		PlatformUI.getWorkbench().getHelpSystem().setHelp(this, IJavaHelpContextIds.CUT_ACTION);
 	}
diff --git a/org.eclipse.jdt.ui/ui refactoring/org/eclipse/jdt/internal/ui/refactoring/reorg/DeleteAction.java b/org.eclipse.jdt.ui/ui refactoring/org/eclipse/jdt/internal/ui/refactoring/reorg/DeleteAction.java
@@ -13,14 +13,13 @@
  *******************************************************************************/
 package org.eclipse.jdt.internal.ui.refactoring.reorg;
 
+import java.text.MessageFormat;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collections;
 import java.util.Iterator;
 import java.util.List;
 
-import java.text.MessageFormat;
-
 import org.eclipse.swt.widgets.Button;
 import org.eclipse.swt.widgets.Composite;
 
@@ -81,7 +80,6 @@ public DeleteAction(IWorkbenchSite site) {
 		ISharedImages workbenchImages= ISharedImages.get();
 		setDisabledImageDescriptor(workbenchImages.getImageDescriptor(ISharedImages.IMG_TOOL_DELETE_DISABLED));
 		setImageDescriptor(workbenchImages.getImageDescriptor(ISharedImages.IMG_TOOL_DELETE));
-		setHoverImageDescriptor(workbenchImages.getImageDescriptor(ISharedImages.IMG_TOOL_DELETE));
 
 		PlatformUI.getWorkbench().getHelpSystem().setHelp(this, IJavaHelpContextIds.DELETE_ACTION);
 	}
diff --git a/org.eclipse.jdt.ui/ui refactoring/org/eclipse/jdt/internal/ui/refactoring/reorg/PasteAction.java b/org.eclipse.jdt.ui/ui refactoring/org/eclipse/jdt/internal/ui/refactoring/reorg/PasteAction.java
@@ -195,7 +195,6 @@ public PasteAction(IWorkbenchSite site, Clipboard clipboard) {
 		ISharedImages workbenchImages= ISharedImages.get();
 		setDisabledImageDescriptor(workbenchImages.getImageDescriptor(ISharedImages.IMG_TOOL_PASTE_DISABLED));
 		setImageDescriptor(workbenchImages.getImageDescriptor(ISharedImages.IMG_TOOL_PASTE));
-		setHoverImageDescriptor(workbenchImages.getImageDescriptor(ISharedImages.IMG_TOOL_PASTE));
 
 		PlatformUI.getWorkbench().getHelpSystem().setHelp(this, IJavaHelpContextIds.PASTE_ACTION);
 	}
diff --git a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/JavaPluginImages.java b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/JavaPluginImages.java
@@ -707,14 +707,7 @@ private static void setImageDescriptors(IAction action, String type, String relP
 		if (id != null)
 			action.setDisabledImageDescriptor(id);
 
-		/*
-		 * id= create("c" + type, relPath, false); //$NON-NLS-1$
-		 * if (id != null)
-		 * 		action.setHoverImageDescriptor(id);
-		 */
-
 		ImageDescriptor descriptor= create("e" + type, relPath, true); //$NON-NLS-1$
-		action.setHoverImageDescriptor(descriptor);
 		action.setImageDescriptor(descriptor);
 	}
 
diff --git a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/callhierarchy/RemoveFromViewAction.java b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/callhierarchy/RemoveFromViewAction.java
@@ -62,7 +62,6 @@ public RemoveFromViewAction(CallHierarchyViewPart part, CallHierarchyViewer view
 		ISharedImages workbenchImages= ISharedImages.get();
 		setDisabledImageDescriptor(workbenchImages.getImageDescriptor(ISharedImages.IMG_ELCL_REMOVE_DISABLED));
 		setImageDescriptor(workbenchImages.getImageDescriptor(ISharedImages.IMG_ELCL_REMOVE));
-		setHoverImageDescriptor(workbenchImages.getImageDescriptor(ISharedImages.IMG_ELCL_REMOVE));
 	}
 
 	/**
diff --git a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/compare/JavaCompareUtilities.java b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/compare/JavaCompareUtilities.java
@@ -355,7 +355,6 @@ static void initAction(IAction a, ResourceBundle bundle, String prefix) {
 			id= JavaCompareUtilities.getImageDescriptor(ePath);
 			if (id != null) {
 				a.setImageDescriptor(id);
-				a.setHoverImageDescriptor(id);
 			}
 		}
 	}
diff --git a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/infoviews/CopyToClipboardAction.java b/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/infoviews/CopyToClipboardAction.java
@@ -47,7 +47,6 @@ public CopyToClipboardAction(IWorkbenchSite site) {
 		ISharedImages workbenchImages= ISharedImages.get();
 		setDisabledImageDescriptor(workbenchImages.getImageDescriptor(ISharedImages.IMG_TOOL_COPY_DISABLED));
 		setImageDescriptor(workbenchImages.getImageDescriptor(ISharedImages.IMG_TOOL_COPY));
-		setHoverImageDescriptor(workbenchImages.getImageDescriptor(ISharedImages.IMG_TOOL_COPY));
 
 		PlatformUI.getWorkbench().getHelpSystem().setHelp(this, IAbstractTextEditorHelpContextIds.COPY_ACTION);
 

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,6 @@ private static void setImageDescriptors(IAction action, String type, String relP`
`153`	`153`	`action.setDisabledImageDescriptor(id);`
`154`	`154`
`155`	`155`	`ImageDescriptor descriptor= createImageDescriptor("e" + type, relPath, true); //$NON-NLS-1$`
`156`		`- action.setHoverImageDescriptor(descriptor);`
`157`	`156`	`action.setImageDescriptor(descriptor);`
`158`	`157`	`}`
`159`	`158`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,6 @@ public CutAction(IWorkbenchSite site) {`
`46`	`46`	`ISharedImages workbenchImages= ISharedImages.get();`
`47`	`47`	`setDisabledImageDescriptor(workbenchImages.getImageDescriptor(ISharedImages.IMG_TOOL_CUT_DISABLED));`
`48`	`48`	`setImageDescriptor(workbenchImages.getImageDescriptor(ISharedImages.IMG_TOOL_CUT));`
`49`		`- setHoverImageDescriptor(workbenchImages.getImageDescriptor(ISharedImages.IMG_TOOL_CUT));`
`50`	`49`
`51`	`50`	`PlatformUI.getWorkbench().getHelpSystem().setHelp(this, IJavaHelpContextIds.CUT_ACTION);`
`52`	`51`	`}`