Memory fixes and turn off asan

Fixed another memory leak, got rid of free_bookmarks() because I can
just use nob_da_free(). Turned address sanitizer back off because I
don't know how to fix the last two memory leaks.

Author: jjwatt

nob.c

@@ -22,7 +22,8 @@ bool build_wdc_lib(Nob_Cmd *cmd) {
 	nob_da_free(source_paths);
 	return true;
     }
-    nob_cmd_append(cmd, "cc", "-Wall", "-Wextra","-fsanitize=address", "-g", "-c", src_path, "-o", bin_path);
+    /* nob_cmd_append(cmd, "cc", "-Wall", "-Wextra","-fsanitize=address", "-g", "-c", src_path, "-o", bin_path); */
+    nob_cmd_append(cmd, "cc", "-Wall", "-Wextra", "-g", "-c", src_path, "-o", bin_path);
     if (!nob_cmd_run_sync_and_reset(cmd)) return false;
     /* Create static lib */
     nob_cmd_append(cmd, "ar", "rcs", BUILD_FOLDER"libwdc.a", bin_path);
@@ -47,7 +48,8 @@ bool build_wdc_main(Nob_Cmd *cmd) {
 	return true;
     }
     /* Link static library with main */
-    nob_cmd_append(cmd, "cc", "-Wall", "-Wextra", "-fsanitize=address", "-g", src_path, "-o", bin_path, "-L"BUILD_FOLDER, "-lwdc");
+    /* nob_cmd_append(cmd, "cc", "-Wall", "-Wextra", "-fsanitize=address", "-g", src_path, "-o", bin_path, "-L"BUILD_FOLDER, "-lwdc"); */
+    nob_cmd_append(cmd, "cc", "-Wall", "-Wextra", "-g", src_path, "-o", bin_path, "-L"BUILD_FOLDER, "-lwdc");
     if (!nob_cmd_run_sync_and_reset(cmd)) return false;
     nob_da_free(source_paths);
     return true;
@@ -59,7 +61,8 @@ bool build_and_run_test(Nob_Cmd *cmd, const char *test_name) {
     const char *src_path = nob_temp_sprintf("%s%s.c", TESTS_FOLDER, test_name);
 
     build_wdc_lib(cmd);
-    nob_cmd_append(cmd, "cc", "-Wall", "-Wextra", "-fsanitize=address", "-g", src_path, "-o", bin_path, "-L"BUILD_FOLDER, "-lwdc");
+    /* nob_cmd_append(cmd, "cc", "-Wall", "-Wextra", "-fsanitize=address", "-g", src_path, "-o", bin_path, "-L"BUILD_FOLDER, "-lwdc"); */
+    nob_cmd_append(cmd, "cc", "-Wall", "-Wextra", "-g", src_path, "-o", bin_path, "-L"BUILD_FOLDER, "-lwdc");
     if (!nob_cmd_run_sync_and_reset(cmd)) return false;
     nob_cmd_append(cmd, bin_path);
     if (!nob_cmd_run_sync_and_reset(cmd)) return false;

src/wdc.c

@@ -111,13 +111,6 @@ Bookmarks get_bookmarks(void) {
     return bookmarks;
 }
 
-int free_bookmarks(Bookmarks bookmarks) {
-    for (size_t i = 0; i < bookmarks.count; i++) {
-	nob_sb_free(bookmarks.items[i]);
-    }
-    return 0;
-}
-
 /**
  * @brief Get bookmarks in reverse order
  *
@@ -166,7 +159,7 @@ int list_bookmarks(void) {
  * @details Pop the top bookmark and write the rest back to the file.
  * @return The bookmark path
  */
-const char *pop(void) {
+char *pop(void) {
     Bookmarks bookmarks = get_bookmarks_reversed();
     char *popped_path = NULL;
     if (bookmarks.items == NULL || bookmarks.count == 0) {
@@ -188,8 +181,8 @@ const char *pop(void) {
     int result = nob_write_entire_file(bookmark_path.items, bookmarks_sb.items, bookmarks_sb.count);
     popped_path = strndup(bm_sv.data, bm_sv.count);
     nob_sb_free(bookmark_path);
-    nob_da_free(bookmarks);
     nob_sb_free(bookmarks_sb);
+    nob_da_free(bookmarks);
     if (!result) {
 	return NULL;
     }

src/wdc.h

@@ -19,10 +19,9 @@ FILE *open_bookmark_file(const char *mode);
 void add_to_file(const char *name, const char *cwd_path, FILE *bookmark_file);
 int add(const char *name);
 Bookmarks get_bookmarks(void);
-int free_bookmarks(Bookmarks bookmarks);
 Bookmarks get_bookmarks_reversed(void);
 int list_bookmarks(void);
 char *find(const char *name);
-const char *pop(void);
+char *pop(void);
 
 #endif

tests/test_add_and_get_bookmarks.c

@@ -15,7 +15,7 @@ TEST add_should_add_to_file(void) {
     printf("bookmark: %s\n", bms.items[0].items);
     rmdir(temp_path);
     nob_temp_rewind(mark);
-    free_bookmarks(bms);
+    nob_da_free(bms);
     PASS();
 }
 
@@ -29,10 +29,11 @@ TEST pop_should_pop_entry(void) {
     // Add again so there's two
     ASSERT_EQ(0, add("test"));
     ASSERT_EQ(0, add("test"));
-    const char *bm = pop();
+    char *bm = pop();
     printf("pop path: %s\n", temp_path);
     printf("*bm: %s\n", bm);
     // TODO: assert on something
+    free(bm);
     rmdir(temp_path);
     nob_temp_rewind(mark);
     PASS();