Identify and document unfinished functionality (#171)

Scanned the codebase for comments and code paths indicating incomplete features or future work.
- Added explicit TODO comments to `DownloadService`, `DuplicateService`, `QueryParser`, `Importer`, `Endpoints`, and `DownloaderFactory`.
- Updated `TASKS.md` to track these new actionable items, including handling additional import types, subscription logic, and downloader error handling.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

Author: google-labs-jules[bot]

Octans.Client/Endpoints.cs

@@ -102,7 +102,11 @@ private static void MapInfrastructureEndpoints(WebApplication app)
     {
         app
             .MapPost("/subscriptions",
-                () => { throw new NotImplementedException("Subscription endpoint not yet implemented"); })
+                () =>
+                {
+                    // TODO: Implement subscription processing logic.
+                    throw new NotImplementedException("Subscription endpoint not yet implemented");
+                })
             .WithName("SubmitSubscription")
             .WithDescription("Submits a subscription request for automated queries");
 

Octans.Core/Downloads/DownloadService.cs

@@ -90,7 +90,7 @@ public Task PauseDownloadAsync(Guid id)
         logger.LogInformation("Pausing download");
 
         // TODO: Implement true pause/resume logic.
-        // For now, we'll implement pause as cancel since we don't support resuming partial downloads
+        // TODO: Implement true pause/resume logic. For now, pause is implemented as cancel since we don't support resuming partial downloads.
         CancelDownloadToken(id);
         stateService.UpdateState(id, DownloadState.Paused);
 

Octans.Core/Downloads/Downloaders/DownloaderFactory.cs

@@ -41,6 +41,7 @@ public virtual async Task<List<Downloader>> GetDownloaders()
 
             if (downloader is null)
             {
+                // TODO: Handle specific creation exceptions or surface errors to UI.
                 // exception on creation
                 continue;
             }

Octans.Core/Duplicates/DuplicateService.cs

@@ -178,7 +178,8 @@ public async Task Resolve(int candidateId, DuplicateResolution resolution, int?
             await fileDeleter.ProcessDeletion(new[] { deleteId });
 
             // We don't save a DuplicateDecision if one is deleted, because the pair is broken.
-            // Or maybe we should? If we delete B, and reimport B later, it will be a new HashItem (new ID? No, same ID if not hard deleted).
+            // TODO: Determine if we should handle re-import of deleted duplicates.
+            // If we delete B, and reimport B later, it will be a new HashItem (new ID? No, same ID if not hard deleted).
             // ReimportChecker reactivates existing hash.
             // So if we delete B, B.DeletedAt is set.
             // If B is reimported, B.DeletedAt is cleared.

Octans.Core/Importing/Importer.cs

@@ -85,6 +85,7 @@ private async Task<ImportItemResult> ImportIndividualItem(ImportRequest request,
         {
             ImportType.File => file.GetRawBytes(item),
             ImportType.RawUrl => simple.GetRawBytes(item),
+            // TODO: Implement additional import types.
             _ => throw new InvalidOperationException("Import type not supported")
         };
 

Octans.Core/Querying/QueryParser.cs

@@ -44,6 +44,7 @@ private SystemPredicate ParseSystemPredicate(RawQuery query)
             "inbox" => new RepositoryPredicate { Repository = RepositoryType.Inbox },
             "archive" => new RepositoryPredicate { Repository = RepositoryType.Archive },
             "trash" => new RepositoryPredicate { Repository = RepositoryType.Trash },
+            // TODO: Implement remaining system predicates.
             _ => throw new NotImplementedException($"System predicate '{query.Query}' is not supported.")
         };
     }

TASKS.md

@@ -27,12 +27,14 @@ Network.
     - **Task:** Implement "Post" Import tab.
     - **Task:** Implement "Gallery" Import tab.
     - **Task:** Implement "Watchable" Import tab.
+    - **Task:** Implement additional import types in `Importer.cs`.
 
 - [ ] **Layout & Navigation**
     - **Task:** Implement Status Bar in Layout (to show progress, etc.).
 
 - [ ] **Subscriptions**
     - **Task:** Implement Subscription API endpoints (`Octans.Client/Endpoints.cs`).
+    - **Task:** Implement subscription processing logic (TODO in `Octans.Client/Endpoints.cs`).
 
 ## 3. Extensibility
 
@@ -47,6 +49,7 @@ Network.
     - Ensure indexes exist on foreign keys in `TagParents`, `TagSiblings`.
     - Monitor search performance with large tag sets.
     - **Task:** Optimize `DuplicateService` comparison algorithm (currently O(N^2)). Use BK-tree or similar.
+    - **Task:** Determine if re-import of deleted duplicates should be handled in `DuplicateService`.
 
 - [ ] **Code Refactoring**
     - **Task:** Review `TagSibling` and `TagParent` 'Status' property necessity (Hydrus legacy).
@@ -56,6 +59,10 @@ Network.
 
 - [ ] **Integration Testing**
     - Add more integration tests for the full search pipeline with complex tag hierarchies.
+    - **Task:** Verify `QueryParser` handles all system predicates correctly.
+
+- [ ] **Error Handling**
+    - **Task:** Surface downloader creation errors to the UI in `DownloaderFactory`.
 
 ## Unsorted