truncate error messages for storage on workchunks (hapifhir#6717)

Author: TipzCM

hapi-fhir-docs/src/main/resources/ca/uhn/hapi/fhir/changelog/8_2_0/6716-batch-err-msg-length.yaml

@@ -0,0 +1,8 @@
+---
+type: fix
+issue: 6716
+jira: SMILE-9676
+title: "Fixed an issue that was caused by
+        batch jobs attempting to store error
+        messages exceeding 500 characters.
+"

hapi-fhir-jpaserver-base/src/main/java/ca/uhn/fhir/jpa/entity/Batch2WorkChunkEntity.java

@@ -188,7 +188,7 @@ public Batch2WorkChunkEntity(
 		myStartTime = theStartTime;
 		myUpdateTime = theUpdateTime;
 		myEndTime = theEndTime;
-		myErrorMessage = theErrorMessage;
+		setErrorMessage(theErrorMessage);
 		myErrorCount = theErrorCount;
 		myRecordsProcessed = theRecordsProcessed;
 		myWarningMessage = theWarningMessage;

hapi-fhir-jpaserver-test-utilities/src/test/java/ca/uhn/fhir/jpa/batch2/JpaJobPersistenceImplIT.java

@@ -3,19 +3,24 @@
 import ca.uhn.fhir.batch2.api.IJobPersistence;
 import ca.uhn.fhir.batch2.model.JobInstance;
 import ca.uhn.fhir.batch2.model.StatusEnum;
+import ca.uhn.fhir.batch2.model.WorkChunk;
 import ca.uhn.fhir.batch2.model.WorkChunkStatusEnum;
 import ca.uhn.fhir.jpa.dao.data.IBatch2WorkChunkRepository;
 import ca.uhn.fhir.jpa.entity.Batch2WorkChunkEntity;
 import ca.uhn.fhir.jpa.test.BaseJpaR4Test;
+import ca.uhn.fhir.jpa.util.RandomTextUtils;
 import org.junit.jupiter.api.Test;
 import org.springframework.beans.factory.annotation.Autowired;
 
 import java.time.Instant;
 import java.time.temporal.ChronoUnit;
 import java.util.Date;
 import java.util.List;
+import java.util.Optional;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 public class JpaJobPersistenceImplIT extends BaseJpaR4Test {
 
@@ -24,6 +29,38 @@ public class JpaJobPersistenceImplIT extends BaseJpaR4Test {
 	@Autowired
 	private IJobPersistence myJobPersistence;
 
+	@Test
+	public void createWorkChunk_withLongErrorMessage_shouldNotFail() {
+		// setup
+		String errorMessage = RandomTextUtils.newSecureRandomAlphaNumericString(700);
+
+		JobInstance jobInstance = new JobInstance();
+		jobInstance.setJobDefinitionId("job-def-id");
+		jobInstance.setStatus(StatusEnum.IN_PROGRESS);
+		jobInstance.setJobDefinitionVersion(1);
+		String instanceId = myJobPersistence.storeNewInstance(jobInstance);
+
+		WorkChunk chunk = new WorkChunk();
+		chunk.setId("id");
+		chunk.setInstanceId(instanceId);
+		chunk.setJobDefinitionId(jobInstance.getJobDefinitionId());
+		chunk.setJobDefinitionVersion(jobInstance.getJobDefinitionVersion());
+		chunk.setStatus(WorkChunkStatusEnum.FAILED);
+		chunk.setCreateTime(new Date());
+		chunk.setTargetStepId("step-id");
+		chunk.setErrorMessage(errorMessage);
+
+		// test
+		myJobPersistence.createWorkChunk(chunk);
+
+		// validate
+		Optional<Batch2WorkChunkEntity> savedOp = myWorkChunkRepository.findById("id");
+		assertTrue(savedOp.isPresent());
+		Batch2WorkChunkEntity saved = savedOp.get();
+		assertNotNull(saved.getErrorMessage());
+		assertTrue(errorMessage.startsWith(saved.getErrorMessage()));
+	}
+
 	@Test
 	public void onWorkChunkPollDelay_withValidData_updatesDeadlineAndPollAttemptCount() {
 		// setup