fix: address review comments for generation params

- Use MIN_STEPS/MAX_STEPS/MIN_GUIDANCE_SCALE/MAX_GUIDANCE_SCALE constants
  in @option decorators instead of hard-coded values
- Update test comment to reference correct line numbers (438-456)
- Remove unreachable fallback in model_config.get('true_cfg_scale', 4.0)
  since outer if guarantees key exists

Author: dobbyphus[bot]

src/oneiro/bot.py

@@ -359,16 +359,16 @@ async def on_raw_reaction_add(payload: discord.RawReactionActionEvent):
         int,
         description="Number of inference steps (default: model-specific)",
         required=False,
-        min_value=1,
-        max_value=100,
+        min_value=MIN_STEPS,
+        max_value=MAX_STEPS,
     )
     @option(
         "guidance_scale",
         float,
         description="CFG scale - prompt adherence (default: model-specific)",
         required=False,
-        min_value=0.0,
-        max_value=15.0,
+        min_value=MIN_GUIDANCE_SCALE,
+        max_value=MAX_GUIDANCE_SCALE,
     )
     @option(
         "lora",
@@ -441,7 +441,7 @@ async def dream(
 
         # Handle Qwen's true_cfg_scale
         if model_config.get("true_cfg_scale"):
-            model_guidance = model_config.get("true_cfg_scale", 4.0)
+            model_guidance = model_config["true_cfg_scale"]
 
         # Check for model-specific overrides set via /model command
         model_overrides = config.get("model_overrides", current_model, default={}) if config else {}
@@ -714,16 +714,16 @@ async def queue_status(ctx: discord.ApplicationContext):
         int,
         description="Override default steps for this model",
         required=False,
-        min_value=1,
-        max_value=100,
+        min_value=MIN_STEPS,
+        max_value=MAX_STEPS,
     )
     @option(
         "guidance_scale",
         float,
         description="Override default CFG scale for this model",
         required=False,
-        min_value=0.0,
-        max_value=15.0,
+        min_value=MIN_GUIDANCE_SCALE,
+        max_value=MAX_GUIDANCE_SCALE,
     )
     async def model_command(
         ctx: discord.ApplicationContext,

tests/test_dream_params.py

@@ -172,7 +172,7 @@ def test_qwen_true_cfg_scale_mapping(self):
         # Qwen should prefer true_cfg_scale
         guidance_scale = model_config.get("guidance_scale", 0.0)
         if model_config.get("true_cfg_scale"):
-            guidance_scale = model_config.get("true_cfg_scale", 4.0)
+            guidance_scale = model_config["true_cfg_scale"]
 
         assert guidance_scale == 1.3
 
@@ -185,12 +185,12 @@ def test_qwen_true_cfg_scale_with_model_override(self):
         }
         model_overrides = {"guidance_scale": 2.5}  # User set via /model command
 
-        # Simulate the logic from bot.py (lines 430-448):
+        # Simulate the logic from bot.py (lines 438-456):
         # 1. Start with model_config defaults
         model_guidance = model_config.get("guidance_scale", 0.0)
         # 2. Apply Qwen's true_cfg_scale if present
         if model_config.get("true_cfg_scale"):
-            model_guidance = model_config.get("true_cfg_scale", 4.0)
+            model_guidance = model_config["true_cfg_scale"]
         # 3. model_overrides takes priority if set
         if "guidance_scale" in model_overrides:
             model_guidance = model_overrides["guidance_scale"]
@@ -209,7 +209,7 @@ def test_qwen_true_cfg_scale_no_override(self):
 
         model_guidance = model_config.get("guidance_scale", 0.0)
         if model_config.get("true_cfg_scale"):
-            model_guidance = model_config.get("true_cfg_scale", 4.0)
+            model_guidance = model_config["true_cfg_scale"]
         if "guidance_scale" in model_overrides:
             model_guidance = model_overrides["guidance_scale"]