Merge pull request #43 from jkoelker/fix/issue-42-json-trailing-newline

fix: add trailing newline to generated JSON files

Author: jkoelker

src/oneiro/civitai.py

@@ -226,6 +226,7 @@ def _save_metadata(self) -> None:
         }
         with open(self.metadata_file, "w") as f:
             json.dump(data, f, indent=2)
+            f.write("\n")
 
     def get(self, sha256: str) -> Path | None:
         """Get cached file path by SHA256 hash."""

src/oneiro/config.py

@@ -129,6 +129,7 @@ def set(self, *keys: str, value: Any) -> None:
         self.state_path.parent.mkdir(parents=True, exist_ok=True)
         with open(self.state_path, "w") as f:
             json.dump(self._state, f, indent=2)
+            f.write("\n")
 
         print(f"State updated: {'.'.join(keys)} = {value}")
 

tests/test_civitai.py

@@ -290,6 +290,24 @@ def test_persistence(self, tmp_path):
 
         assert cache2.get("abc123") == test_file
 
+    def test_metadata_file_has_trailing_newline(self, tmp_path):
+        """Metadata file should end with a newline."""
+        cache = CivitaiCache(tmp_path)
+        test_file = tmp_path / "test.bin"
+        test_file.write_bytes(b"test content")
+
+        cache.add(
+            file_path=test_file,
+            sha256="abc123",
+            model_id=1,
+            version_id=2,
+            filename="test.bin",
+            size_kb=100,
+        )
+
+        content = cache.metadata_file.read_text()
+        assert content.endswith("\n"), "metadata.json should end with a newline"
+
     def test_total_size(self, tmp_path):
         """total_size_kb returns sum of all cached file sizes."""
         cache = CivitaiCache(tmp_path)

tests/test_config.py

@@ -212,6 +212,17 @@ def test_set_creates_parent_dirs(self, tmp_path):
         config.set("key", value="value")
         assert state.exists()
 
+    def test_set_writes_trailing_newline(self, tmp_path):
+        """Set writes state file with trailing newline."""
+        base = tmp_path / "config.toml"
+        state = tmp_path / "state.json"
+        base.write_text("")
+        config = Config(base, state_path=state)
+        config.load()
+        config.set("key", value="value")
+        content = state.read_text()
+        assert content.endswith("\n"), "state.json should end with a newline"
+
 
 class TestConfigDeepMerge:
     """Tests for Config._deep_merge()."""