Labeling Mismatch and Overlap in WMT_North_Atlantic.ipynb

[jetesdal]

I noticed a couple of issues with the masking() function in WMT_North_Atlantic.ipynb. The xr.concat() call currently includes ds_spna (the full region), followed by individual region masks (ds_lab, ds_nor, etc.), and assigns region labels:

ds_all = xr.concat([ds_spna, ds_lab, ds_nor, ds_irm, ds_nac], dim='region')
ds_all['regionname'] = xr.DataArray(['lab','spg','nor','irm','nac'], dims=['region'])

The full-region ds_spna is labeled as lab and the subsequent regions are shifted (e.g., ds_lab is labeled as spg, and so on)

Also, I think there is an overlap between the nor and irm masks (see attached map of grid count where >1 means the area is used more than once).

I believe I have a fix, but I’d like to check if that might already have been fixed in the MDTF?

[emaroon]

Thanks for catching this! I'm working on getting a fuller version of our POD than this quick notebook put together for MDTF, so I'll make sure to double-check for this issue as I go.