Skip to content

Commit 65abad1

Browse files
authored
fix(release.yaml, Installation.md): update plugin package naming conventions and installation instructions (#649)
1 parent a9d854e commit 65abad1

File tree

2 files changed

+12
-20
lines changed

2 files changed

+12
-20
lines changed

.github/workflows/release.yaml

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,6 @@ jobs:
5252
rm -rf scripts
5353
cp -a ../../scripts .
5454
helm plugin package . --sign --passphrase-file - --key "mail@jkroepke.de" --keyring ~/.gnupg/secring.gpg <<< "$GPG_PASSPHRASE"
55-
mv secrets-*.tgz helm-secrets.tgz
56-
mv secrets-*.tgz.prov helm-secrets.tgz.prov
5755
working-directory: plugins/helm-secrets-cli
5856
env:
5957
GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }}
@@ -63,8 +61,6 @@ jobs:
6361
rm -rf scripts
6462
cp -a ../../scripts .
6563
helm plugin package . --sign --passphrase-file - --key "mail@jkroepke.de" --keyring ~/.gnupg/secring.gpg <<< "$GPG_PASSPHRASE"
66-
mv secrets-getter-*.tgz helm-secrets-getter.tgz
67-
mv secrets-getter-*.tgz.prov helm-secrets-getter.tgz.prov
6864
working-directory: plugins/helm-secrets-getter
6965
env:
7066
GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }}
@@ -74,8 +70,6 @@ jobs:
7470
rm -rf scripts
7571
cp -a ../../scripts .
7672
helm plugin package . --sign --passphrase-file - --key "mail@jkroepke.de" --keyring ~/.gnupg/secring.gpg <<< "$GPG_PASSPHRASE"
77-
mv secrets-post-renderer-*.tgz helm-secrets-post-renderer.tgz
78-
mv secrets-post-renderer-*.tgz.prov helm-secrets-post-renderer.tgz.prov
7973
working-directory: plugins/helm-secrets-post-renderer
8074
env:
8175
GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }}
@@ -89,12 +83,12 @@ jobs:
8983
* https://github.com/jkroepke/helm-secrets/blob/${{ github.ref_name }}/CHANGELOG.md" \
9084
${{ contains(github.ref_name, 'rc') && '--prerelease' || '--latest' }} \
9185
helm-secrets.tar.gz \
92-
plugins/helm-secrets-cli/helm-secrets.tgz \
93-
plugins/helm-secrets-cli/helm-secrets.tgz.prov \
94-
plugins/helm-secrets-getter/helm-secrets-getter.tgz \
95-
plugins/helm-secrets-getter/helm-secrets-getter.tgz.prov \
96-
plugins/helm-secrets-post-renderer/helm-secrets-post-renderer.tgz \
97-
plugins/helm-secrets-post-renderer/helm-secrets-post-renderer.tgz.prov
86+
plugins/helm-secrets-cli/secrets.tgz \
87+
plugins/helm-secrets-cli/secrets.tgz.prov \
88+
plugins/helm-secrets-getter/secrets-getter.tgz \
89+
plugins/helm-secrets-getter/secrets-getter.tgz.prov \
90+
plugins/helm-secrets-post-renderer/secrets-post-renderer.tgz \
91+
plugins/helm-secrets-post-renderer/secrets-post-renderer.tgz.prov
9892
env:
9993
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
10094
docs:

docs/Installation.md

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,18 +23,16 @@ The `--version` flag is not supported in Helm 4, so you need to specify the exac
2323
Click [here](https://github.com/jkroepke/helm-secrets/releases/latest) for the latest version.
2424

2525
```bash
26-
helm plugin install https://github.com/jkroepke/helm-secrets/releases/download/v4.7.0/helm-secrets.tgz
27-
helm plugin install https://github.com/jkroepke/helm-secrets/releases/download/v4.7.0/helm-secrets-getter.tgz
28-
helm plugin install https://github.com/jkroepke/helm-secrets/releases/download/v4.7.0/helm-secrets-post-renderer.tgz
26+
helm plugin install https://github.com/jkroepke/helm-secrets/releases/download/v4.7.0/secrets.tgz
27+
helm plugin install https://github.com/jkroepke/helm-secrets/releases/download/v4.7.0/secrets-getter.tgz
28+
helm plugin install https://github.com/jkroepke/helm-secrets/releases/download/v4.7.0/secrets-post-renderer.tgz
2929
```
3030

3131
### Install latest version
3232

33-
```bash
34-
helm plugin install https://github.com/jkroepke/helm-secrets/releases/latest/download/helm-secrets.tgz
35-
helm plugin install https://github.com/jkroepke/helm-secrets/releases/latest/download/helm-secrets-getter.tgz
36-
helm plugin install https://github.com/jkroepke/helm-secrets/releases/latest/download/helm-secrets-post-renderer.tgz
37-
```
33+
Helm forces `<plugin-name>-<version>.tgz` naming convention for plugin packages.
34+
Therefore, to install the latest version,
35+
you need to fetch the latest version number first and then construct the download URLs accordingly.
3836

3937
## Helm 3
4038

0 commit comments

Comments
 (0)