Skip to content

Commit 97634e6

Browse files
Apply ruff/pygrep-hooks rule PGH003 (sigstore#1321)
PGH003 Use specific rule codes when ignoring type issues Signed-off-by: Dimitri Papadopoulos <[email protected]> Co-authored-by: William Woodruff <[email protected]>
1 parent 71a27c4 commit 97634e6

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

sigstore/_utils.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -187,10 +187,10 @@ def _sha256_streaming(io: IO[bytes]) -> bytes:
187187
# of systems in terms of minimizing syscall overhead.
188188
view = memoryview(bytearray(128 * 1024))
189189

190-
nbytes = io.readinto(view) # type: ignore
190+
nbytes = io.readinto(view) # type: ignore[attr-defined]
191191
while nbytes:
192192
sha256.update(view[:nbytes])
193-
nbytes = io.readinto(view) # type: ignore
193+
nbytes = io.readinto(view) # type: ignore[attr-defined]
194194

195195
return sha256.digest()
196196

@@ -242,15 +242,15 @@ def cert_is_ca(cert: Certificate) -> bool:
242242
"invalid X.509 certificate: non-critical BasicConstraints in CA"
243243
)
244244

245-
ca = basic_constraints.value.ca # type: ignore
245+
ca = basic_constraints.value.ca # type: ignore[attr-defined]
246246
except ExtensionNotFound:
247247
# No BasicConstrains means that this can't possibly be a CA.
248248
return False
249249

250250
key_cert_sign = False
251251
try:
252252
key_usage = cert.extensions.get_extension_for_oid(ExtensionOID.KEY_USAGE)
253-
key_cert_sign = key_usage.value.key_cert_sign # type: ignore
253+
key_cert_sign = key_usage.value.key_cert_sign # type: ignore[attr-defined]
254254
except ExtensionNotFound:
255255
raise VerificationError("invalid X.509 certificate: missing KeyUsage")
256256

@@ -322,7 +322,7 @@ def cert_is_leaf(cert: Certificate) -> bool:
322322
return False
323323

324324
key_usage = cert.extensions.get_extension_for_oid(ExtensionOID.KEY_USAGE)
325-
digital_signature = key_usage.value.digital_signature # type: ignore
325+
digital_signature = key_usage.value.digital_signature # type: ignore[attr-defined]
326326

327327
if not digital_signature:
328328
raise VerificationError(
@@ -337,6 +337,6 @@ def cert_is_leaf(cert: Certificate) -> bool:
337337
ExtensionOID.EXTENDED_KEY_USAGE
338338
)
339339

340-
return ExtendedKeyUsageOID.CODE_SIGNING in extended_key_usage.value # type: ignore
340+
return ExtendedKeyUsageOID.CODE_SIGNING in extended_key_usage.value # type: ignore[operator]
341341
except ExtensionNotFound:
342342
raise VerificationError("invalid X.509 certificate: missing ExtendedKeyUsage")

0 commit comments

Comments
 (0)