Merge pull request #857 from 0xSekar/issue-779-ErrorList-Response

Revert error response to format reported by Amazon in ProductPricing/V0 api

Author: jlevers

resources/metadata/modifications.json

@@ -149,6 +149,34 @@
           "value": false
         }
       ]
+    },
+    "product-pricing": {
+      "0": [
+        {
+          "comment": "Error Response from Amazon for GetOffersResponse is an array",
+          "action": "replace",
+          "path": "components.schemas.ErrorList.type",
+          "value": "array"
+        },
+        {
+          "comment": "Error Response from Amazon for GetOffersResponse is an array",
+          "action": "replace",
+          "path": "components.schemas.ErrorList.items",
+          "value": {
+            "$ref": "#/components/schemas/Error"
+          }
+        },
+        {
+          "comment": "Remove unneded objects from ErrorList",
+          "action": "delete",
+          "path": "components.schemas.ErrorList.properties"
+        },
+        {
+          "comment": "Remove unneded objects from ErrorList",
+          "action": "delete",
+          "path": "components.schemas.ErrorList.required"
+        }
+      ]
     }
   }
 }

resources/models/seller/product-pricing/v0.json

@@ -8090,19 +8090,10 @@
                 "description": "Information about the seller's feedback, including the percentage of positive feedback, and the total number of ratings received."
             },
             "ErrorList": {
-                "required": [
-                    "errors"
-                ],
-                "type": "object",
+                "type": "array",
                 "description": "A list of error responses returned when a request is unsuccessful.",
-                "properties": {
-                    "errors": {
-                        "type": "array",
-                        "description": "A list of error responses returned when a request is unsuccessful.",
-                        "items": {
-                            "$ref": "#/components/schemas/Error"
-                        }
-                    }
+                "items": {
+                    "$ref": "#/components/schemas/Error"
                 }
             },
             "DetailedShippingTimeType": {

src/Seller/ProductPricingV0/Responses/Errors.php

@@ -11,14 +11,16 @@
 namespace SellingPartnerApi\Seller\ProductPricingV0\Responses;
 
 use SellingPartnerApi\Response;
-use SellingPartnerApi\Seller\ProductPricingV0\Dto\ErrorList;
+use SellingPartnerApi\Seller\ProductPricingV0\Dto\Error;
 
 final class Errors extends Response
 {
+    protected static array $complexArrayTypes = ['errors' => Error::class];
+
     /**
-     * @param  ErrorList  $errors  A list of error responses returned when a request is unsuccessful.
+     * @param  Error[]  $errors  A list of error responses returned when a request is unsuccessful.
      */
     public function __construct(
-        public readonly ErrorList $errors,
+        public readonly array $errors,
     ) {}
 }

src/Seller/ProductPricingV0/Responses/GetOffersResponse.php

@@ -11,17 +11,19 @@
 namespace SellingPartnerApi\Seller\ProductPricingV0\Responses;
 
 use SellingPartnerApi\Response;
-use SellingPartnerApi\Seller\ProductPricingV0\Dto\ErrorList;
+use SellingPartnerApi\Seller\ProductPricingV0\Dto\Error;
 use SellingPartnerApi\Seller\ProductPricingV0\Dto\GetOffersResult;
 
 final class GetOffersResponse extends Response
 {
+    protected static array $complexArrayTypes = ['errors' => Error::class];
+
     /**
      * @param  ?GetOffersResult  $payload  The payload for the getListingOffers and getItemOffers operations.
-     * @param  ?ErrorList  $errors  A list of error responses returned when a request is unsuccessful.
+     * @param  Error[]|null  $errors  A list of error responses returned when a request is unsuccessful.
      */
     public function __construct(
         public readonly ?GetOffersResult $payload = null,
-        public readonly ?ErrorList $errors = null,
+        public readonly ?array $errors = null,
     ) {}
 }

src/Seller/ProductPricingV0/Responses/GetPricingResponse.php

@@ -11,19 +11,19 @@
 namespace SellingPartnerApi\Seller\ProductPricingV0\Responses;
 
 use SellingPartnerApi\Response;
-use SellingPartnerApi\Seller\ProductPricingV0\Dto\ErrorList;
+use SellingPartnerApi\Seller\ProductPricingV0\Dto\Error;
 use SellingPartnerApi\Seller\ProductPricingV0\Dto\Price;
 
 final class GetPricingResponse extends Response
 {
-    protected static array $complexArrayTypes = ['payload' => Price::class];
+    protected static array $complexArrayTypes = ['payload' => Price::class, 'errors' => Error::class];
 
     /**
      * @param  Price[]|null  $payload  The payload for the `getPricing` and `getCompetitivePricing` operations.
-     * @param  ?ErrorList  $errors  A list of error responses returned when a request is unsuccessful.
+     * @param  Error[]|null  $errors  A list of error responses returned when a request is unsuccessful.
      */
     public function __construct(
         public readonly ?array $payload = null,
-        public readonly ?ErrorList $errors = null,
+        public readonly ?array $errors = null,
     ) {}
 }