Merge pull request #1693 from jline/backport/jline-3.x/fix-jni-native-access-check-1689

fix: Skip JNI native access check on JDK < 24 (fixes #1689) [3.x backport]

Author: gnodet

terminal-jni/src/main/java/org/jline/terminal/impl/jni/JniTerminalProvider.java

@@ -71,13 +71,26 @@ public JniTerminalProvider() {
 
     /**
      * Checks that native access is enabled for this module.
-     * Uses reflection because {@code Module.isNativeAccessEnabled()} is only available on JDK 22+
-     * and {@code Class.getModule()} is only available on JDK 9+.
-     * On older JDKs, the check is skipped (no restrictions exist).
+     * JNI native access restrictions are only enforced from JDK 24+, so the check
+     * is skipped on earlier versions. Uses reflection because
+     * {@code Module.isNativeAccessEnabled()} is not available on all JDK versions.
      *
      * @throws UnsupportedOperationException if native access is not enabled
      */
     static void checkNativeAccess() {
+        // JNI native access restrictions are only enforced starting from JDK 24.
+        // Some JDK 21 builds (e.g. 21.0.10) backported Module.isNativeAccessEnabled(),
+        // but it returns false even though JNI works fine without --enable-native-access.
+        // See https://github.com/jline/jline3/issues/1689
+        try {
+            int version = Integer.parseInt(System.getProperty("java.specification.version"));
+            if (version < 24) {
+                return;
+            }
+        } catch (NumberFormatException e) {
+            // JDK 8 uses "1.8" format, which means JDK < 24
+            return;
+        }
         try {
             Method getModule = Class.class.getMethod("getModule");
             Object module = getModule.invoke(JniTerminalProvider.class);
@@ -88,7 +101,7 @@ static void checkNativeAccess() {
                         "Native access is not enabled for the current module: " + module);
             }
         } catch (NoSuchMethodException e) {
-            // JDK < 9 (no modules) or JDK < 22 (no isNativeAccessEnabled), no restrictions
+            // Method not available, no native access restrictions
         } catch (UnsupportedOperationException e) {
             throw e;
         } catch (ReflectiveOperationException e) {

terminal/src/main/java/org/jline/terminal/impl/exec/ExecTerminalProvider.java

@@ -693,13 +693,26 @@ public ProcessBuilder.Redirect newRedirectPipe(FileDescriptor fd) {
 
     /**
      * Checks that native access is enabled for this module.
-     * Uses reflection because {@code Module.isNativeAccessEnabled()} is only available on JDK 22+
-     * and {@code Class.getModule()} is only available on JDK 9+.
-     * On older JDKs, the check is skipped (no restrictions exist).
+     * JNI native access restrictions are only enforced from JDK 24+, so the check
+     * is skipped on earlier versions. Uses reflection because
+     * {@code Module.isNativeAccessEnabled()} is not available on all JDK versions.
      *
      * @throws UnsupportedOperationException if native access is not enabled
      */
     static void checkNativeAccess() {
+        // JNI native access restrictions are only enforced starting from JDK 24.
+        // Some JDK 21 builds (e.g. 21.0.10) backported Module.isNativeAccessEnabled(),
+        // but it returns false even though JNI works fine without --enable-native-access.
+        // See https://github.com/jline/jline3/issues/1689
+        try {
+            int version = Integer.parseInt(System.getProperty("java.specification.version"));
+            if (version < 24) {
+                return;
+            }
+        } catch (NumberFormatException e) {
+            // JDK 8 uses "1.8" format, which means JDK < 24
+            return;
+        }
         try {
             Method getModule = Class.class.getMethod("getModule");
             Object module = getModule.invoke(ExecTerminalProvider.class);
@@ -710,7 +723,7 @@ static void checkNativeAccess() {
                         "Native access is not enabled for the current module: " + module);
             }
         } catch (NoSuchMethodException e) {
-            // JDK < 9 (no modules) or JDK < 22 (no isNativeAccessEnabled), no restrictions
+            // Method not available, no native access restrictions
         } catch (UnsupportedOperationException e) {
             throw e;
         } catch (ReflectiveOperationException e) {