Merge pull request #1692 from jline/fix/jni-native-access-check-1689

fix: Skip JNI native access check on JDK < 24 (fixes #1689)

Author: gnodet

terminal-jni/src/main/java/org/jline/terminal/impl/jni/JniTerminalProvider.java

@@ -70,9 +70,9 @@ public JniTerminalProvider() {
 
     /**
      * Checks that native access is enabled for this module.
-     * Uses reflection because {@code Module.isNativeAccessEnabled()} is only available on JDK 22+
-     * (though GraalVM backported it to earlier versions).
-     * On JDKs without this method, the check is skipped (no restrictions exist).
+     * JNI native access restrictions are only enforced from JDK 24+, so the check
+     * is skipped on earlier versions. Uses reflection because
+     * {@code Module.isNativeAccessEnabled()} is not available on all JDK versions.
      * In GraalVM native images, the check is also skipped since native libraries
      * are handled at build time.
      *
@@ -84,6 +84,13 @@ static void checkNativeAccess() {
         if (System.getProperty("org.graalvm.nativeimage.imagecode") != null) {
             return;
         }
+        // JNI native access restrictions are only enforced starting from JDK 24.
+        // Some JDK 21 builds (e.g. 21.0.10) backported Module.isNativeAccessEnabled(),
+        // but it returns false even though JNI works fine without --enable-native-access.
+        // See https://github.com/jline/jline3/issues/1689
+        if (Runtime.version().feature() < 24) {
+            return;
+        }
         try {
             Method m = Module.class.getMethod("isNativeAccessEnabled");
             Boolean enabled = (Boolean) m.invoke(JniTerminalProvider.class.getModule());
@@ -92,7 +99,7 @@ static void checkNativeAccess() {
                         + JniTerminalProvider.class.getModule());
             }
         } catch (NoSuchMethodException e) {
-            // JDK < 22, no native access restrictions
+            // Method not available, no native access restrictions
         } catch (UnsupportedOperationException e) {
             throw e;
         } catch (ReflectiveOperationException e) {

terminal/src/main/java/org/jline/terminal/impl/exec/ExecTerminalProvider.java

@@ -623,12 +623,20 @@ public ProcessBuilder.Redirect newRedirectPipe(FileDescriptor fd) {
 
     /**
      * Checks that native access is enabled for this module.
-     * Uses reflection because {@code Module.isNativeAccessEnabled()} is only available on JDK 22+.
-     * On older JDKs, the check is skipped (no restrictions exist).
+     * JNI native access restrictions are only enforced from JDK 24+, so the check
+     * is skipped on earlier versions. Uses reflection because
+     * {@code Module.isNativeAccessEnabled()} is not available on all JDK versions.
      *
      * @throws UnsupportedOperationException if native access is not enabled
      */
     static void checkNativeAccess() {
+        // JNI native access restrictions are only enforced starting from JDK 24.
+        // Some JDK 21 builds (e.g. 21.0.10) backported Module.isNativeAccessEnabled(),
+        // but it returns false even though JNI works fine without --enable-native-access.
+        // See https://github.com/jline/jline3/issues/1689
+        if (Runtime.version().feature() < 24) {
+            return;
+        }
         try {
             Method m = Module.class.getMethod("isNativeAccessEnabled");
             Boolean enabled = (Boolean) m.invoke(ExecTerminalProvider.class.getModule());
@@ -637,7 +645,7 @@ static void checkNativeAccess() {
                         + ExecTerminalProvider.class.getModule());
             }
         } catch (NoSuchMethodException e) {
-            // JDK < 22, no native access restrictions
+            // Method not available, no native access restrictions
         } catch (UnsupportedOperationException e) {
             throw e;
         } catch (ReflectiveOperationException e) {