Changed inserting into table with trigger to work by default (microsoft#161)

Author: jmah8

README.md

@@ -204,23 +204,24 @@ Dictionary. Current available keys are:
             },
     ```
 
-- has_trigger
+- return_rows_bulk_insert
 
   Boolean. Sets if backend can return rows from bulk insert.
-  Default value is False which allows for the backend to
-  return rows from bulk insert.
+  Default value is False which doesn't allows for the backend to
+  return rows from bulk insert. Must be set to False if database
+  has tables with triggers to prevent errors when inserting.
 
   ```python
   # Examples
   "OPTIONS": {
-      # This database has triggers so set has_trigger to True
-      # to prevent errors related to returning rows from bulk insert
-      "has_trigger": True
+      # This database doesn't have any triggers so can use return
+      # rows from bulk insert feature
+      "return_rows_bulk_insert": True
   }
 
   "OPTIONS": {
-      # This database doesn't have any triggers so don't need to 
-      # add has_trigger since it is False by default
+      # This database has triggers so leave return_rows_bulk_insert as blank (False)
+      # to prevent errors related to inserting and returning rows from bulk insert
   }
   ```
 

mssql/base.py

@@ -424,10 +424,10 @@ def init_connection_state(self):
         datefirst = options.get('datefirst', 7)
         cursor.execute('SET DATEFORMAT ymd; SET DATEFIRST %s' % datefirst)
 
-        # If there are triggers set can_return_rows_from_bulk_insert to
-        # False to prevent errors when inserting. See issue #130
-        if (options.get('has_trigger', False)):
-            self.features_class.can_return_rows_from_bulk_insert = False
+        # Let user choose if driver can return rows from bulk insert since
+        # inserting into tables with triggers causes errors. See issue #130
+        if (options.get('return_rows_bulk_insert', False)):
+            self.features_class.can_return_rows_from_bulk_insert = True
 
         val = self.get_system_datetime()
         if isinstance(val, str):

mssql/features.py

@@ -12,7 +12,7 @@ class DatabaseFeatures(BaseDatabaseFeatures):
     can_introspect_small_integer_field = True
     can_return_columns_from_insert = True
     can_return_id_from_insert = True
-    can_return_rows_from_bulk_insert = True
+    can_return_rows_from_bulk_insert = False
     can_rollback_ddl = True
     can_use_chunked_reads = False
     for_update_after_from = True