Remove class IPC::Sender

Nothing remains besides a destructor.

-- Mark one class final when devirtualizing a destructor.

Change-Id: Ie62e751df24d60625a4493c8ad870446a7aa1d31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7056007
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Daniel Cheng <[email protected]>
Auto-Submit: Tom Sepez <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1532397}

Author: tsepez

ipc/BUILD.gn

@@ -39,7 +39,6 @@ component("ipc") {
       "ipc_message_pipe_reader.h",
       "ipc_mojo_bootstrap.cc",
       "ipc_mojo_bootstrap.h",
-      "ipc_sender.h",
       "ipc_sync_channel.cc",
       "ipc_sync_channel.h",
       "urgent_message_observer.h",

ipc/ipc_channel.h

@@ -24,7 +24,6 @@
 #include "ipc/ipc.mojom-forward.h"
 #include "ipc/ipc.mojom.h"
 #include "ipc/ipc_message_pipe_reader.h"
-#include "ipc/ipc_sender.h"
 #include "mojo/public/cpp/bindings/generic_pending_associated_receiver.h"
 #include "mojo/public/cpp/bindings/pending_associated_receiver.h"
 #include "mojo/public/cpp/bindings/scoped_interface_endpoint_handle.h"
@@ -48,9 +47,8 @@ class UrgentMessageObserver;
 
 // Channels are implemented using mojo message pipes.
 
-class COMPONENT_EXPORT(IPC) Channel
-    : public Sender,
-      public internal::MessagePipeReader::Delegate {
+class COMPONENT_EXPORT(IPC) Channel final
+    : public internal::MessagePipeReader::Delegate {
   // Security tests need access to the pipe handle.
   friend class ChannelTest;
 
@@ -126,7 +124,7 @@ class COMPONENT_EXPORT(IPC) Channel
       const scoped_refptr<base::SingleThreadTaskRunner>& ipc_task_runner,
       const scoped_refptr<base::SingleThreadTaskRunner>& proxy_task_runner);
 
-  ~Channel() override;
+  ~Channel();
 
   // Connect the pipe.  On the server side, this will initiate
   // waiting for connections.  On the client, it attempts to

ipc/ipc_channel_proxy.h

@@ -23,7 +23,6 @@
 #include "ipc/ipc.mojom.h"
 #include "ipc/ipc_channel.h"
 #include "ipc/ipc_listener.h"
-#include "ipc/ipc_sender.h"
 #include "mojo/public/cpp/bindings/associated_remote.h"
 #include "mojo/public/cpp/bindings/generic_pending_associated_receiver.h"
 #include "mojo/public/cpp/bindings/pending_associated_receiver.h"
@@ -69,7 +68,7 @@ class UrgentMessageObserver;
 // |channel_lifetime_lock_| is used to protect it. The locking overhead is only
 // paid if the underlying channel supports thread-safe |Send|.
 //
-class COMPONENT_EXPORT(IPC) ChannelProxy : public Sender {
+class COMPONENT_EXPORT(IPC) ChannelProxy {
  public:
   // Initializes a channel proxy.  The channel_handle and mode parameters are
   // passed directly to the underlying IPC::Channel.  The listener is called on
@@ -98,7 +97,7 @@ class COMPONENT_EXPORT(IPC) ChannelProxy : public Sender {
       const scoped_refptr<base::SingleThreadTaskRunner>& ipc_task_runner,
       const scoped_refptr<base::SingleThreadTaskRunner>& listener_task_runner);
 
-  ~ChannelProxy() override;
+  virtual ~ChannelProxy();
 
   // Initializes the channel proxy. Only call this once to initialize a channel
   // proxy that was not initialized in its constructor. If |create_pipe_now| is

ipc/ipc_perftest_util.h

@@ -24,7 +24,6 @@
 #include "ipc/ipc_channel_proxy.h"
 #include "ipc/ipc_listener.h"
 #include "ipc/ipc_message.h"
-#include "ipc/ipc_sender.h"
 #include "ipc/ipc_test.test-mojom.h"
 #include "mojo/public/cpp/bindings/receiver.h"
 #include "mojo/public/cpp/system/message_pipe.h"

ipc/ipc_sender.h

@@ -28,7 +28,6 @@
 #include "build/build_config.h"
 #include "ipc/ipc_listener.h"
 #include "ipc/ipc_message.h"
-#include "ipc/ipc_sender.h"
 #include "mojo/public/cpp/system/message_pipe.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ -38,7 +37,7 @@ namespace IPC {
 namespace {
 
 // Base class for a "process" with listener and IPC threads.
-class Worker : public Listener, public Sender {
+class Worker : public Listener {
  public:
   // Will create a channel without a name.
   Worker(Channel::Mode mode,
@@ -208,8 +207,6 @@ class Worker : public Listener, public Sender {
   bool is_shutdown_;
 };
 
-
-
 class IPCSyncChannelTest : public testing::Test {
  private:
   base::test::SingleThreadTaskEnvironment task_environment_;