Revert "Fix false positive on icmp ptr with samesign flag (AliveToolkit#1151)"

This reverts commit da0d731.

Author: jmciver

ir/instr.cpp

@@ -2771,19 +2771,7 @@ StateValue ICmp::toSMT(State &s) const {
   auto scalar = [&](const StateValue &a, const StateValue &b) -> StateValue {
     auto fn2 = [&](Cond c) { return fn(a.value, b.value, c); };
     auto v = cond != Any ? fn2(cond) : build_icmp_chain(cond_var(), fn2);
-    expr np = true;
-    if (flags & SameSign) {
-      if (isPtrCmp()) {
-        auto &m = s.getMemory();
-        Pointer lhs(m, a.value);
-        Pointer rhs(m, b.value);
-        m.observesAddr(lhs);
-        m.observesAddr(rhs);
-        np = lhs.getAddress().sign() == rhs.getAddress().sign();
-      } else {
-        np = a.value.sign() == b.value.sign();
-      }
-    }
+    auto np = flags & SameSign ? a.value.sign() == b.value.sign() : true;
     return { v.toBVBool(), a.non_poison && b.non_poison && np };
   };