fix: use go-cmp instead of deep equal

eddycharly · eddycharly · commit 182fbcea30b3 · 2024-06-27T23:17:25.000+02:00
Signed-off-by: Charles-Edouard Brétéché &lt;charles.edouard@nirmata.com&gt;
diff --git a/go.mod b/go.mod
@@ -3,6 +3,7 @@ module github.com/jmespath-community/go-jmespath
 go 1.18
 
 require (
+	github.com/google/go-cmp v0.5.8
 	github.com/spf13/cobra v1.8.0
 	github.com/stretchr/testify v1.9.0
 	golang.org/x/exp v0.0.0-20230314191032-db074128a8ec
diff --git a/go.sum b/go.sum
@@ -1,6 +1,8 @@
 github.com/cpuguy83/go-md2man/v2 v2.0.3/go.mod h1:tgQtvFlXSQOSOSIRvRPT7W67SCa46tRHOmNcaadrF8o=
 github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
+github.com/google/go-cmp v0.5.8 h1:e6P7q2lk1O+qJJb4BtCQXlK8vWEO8V1ZeuEdJNOqZyg=
+github.com/google/go-cmp v0.5.8/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
 github.com/inconshreveable/mousetrap v1.1.0 h1:wN+x4NVGpMsO7ErUn/mUI3vEoE6Jt13X2s0bqwp9tc8=
 github.com/inconshreveable/mousetrap v1.1.0/go.mod h1:vpF70FUmC8bwa3OWnCshd2FqLfsEA9PFc4w1p2J65bw=
 github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
diff --git a/pkg/util/util.go b/pkg/util/util.go
@@ -5,6 +5,7 @@ import (
 	"math"
 	"reflect"
 
+	"github.com/google/go-cmp/cmp"
 	"golang.org/x/exp/constraints"
 )
 
@@ -51,7 +52,8 @@ func IsFalse(value interface{}) bool {
 // It will take two arbitrary objects and recursively determine
 // if they are equal.
 func ObjsEqual(left interface{}, right interface{}) bool {
-	return reflect.DeepEqual(left, right)
+	return cmp.Equal(left, right)
+	// return reflect.DeepEqual(left, right)
 }
 
 // SliceParam refers to a single part of a slice.

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@ import (`
`5`	`5`	`"math"`
`6`	`6`	`"reflect"`
`7`	`7`
	`8`	`+ "github.com/google/go-cmp/cmp"`
`8`	`9`	`"golang.org/x/exp/constraints"`
`9`	`10`	`)`
`10`	`11`
`@@ -51,7 +52,8 @@ func IsFalse(value interface{}) bool {`
`51`	`52`	`// It will take two arbitrary objects and recursively determine`
`52`	`53`	`// if they are equal.`
`53`	`54`	`func ObjsEqual(left interface{}, right interface{}) bool {`
`54`		`- return reflect.DeepEqual(left, right)`
	`55`	`+ return cmp.Equal(left, right)`
	`56`	`+ // return reflect.DeepEqual(left, right)`
`55`	`57`	`}`
`56`	`58`
`57`	`59`	`// SliceParam refers to a single part of a slice.`