JSON Literal unquoted string

[SamMousa]

The spec does not allow for this:

[?abc == `def`]

However the JMESPath.org implementation explicitly supports this case: https://github.com/jmespath/jmespath.js/blob/master/jmespath.js#L443

https://github.com/jmespath/jmespath.php/blob/master/src/Lexer.php#L432

Note that the JMESPath.org implementation is wrong here, but it might be nice to list this in the compatibility notes.

We currently are in a difficult spot:

1. We switched to community typescript for client side
2. We're still on JMESPath.org PHP implementation for server side

Reasonably the PHP implementation will not change their behavior (and become inconsistent with their own implementation).
Would you consider adding a PHP implementation? (Where I will fork the JMESPath.org implementation, modernize it and make it compliant with the community spec?)

[springcomp]

Hi @SamMousa good catch !

That is, I think one of only two areas where we do differently in JmesPath Community than in JmesPath.org.
We are convinced we are doing the right thing.

That being said, it’s worth nothing that the behaviour you call out was once part of an early spec draft:

• JEP12 has the legacy behaviour, which is being deprecated by
• JEP12a

Indeed, the Python library has a switch so that users can opt-in to this legacy behaviour (I added the switch but kept behaviour because it was already there in the original version – I have not added support for legacy behaviour in other ports I have contributed to).

I agree that this should be called out a bit more explicitly.
We are thinking re-designing the website and that should be part of it.

I would love to welcome more library ports under the JmesPath Community umbrella, although that is by no means mandatory.
A compliant PHP version would be of great value I think, because we need more eyes and viewpoints on design decisions.

Please, let me know what you need.

If you were to fork the PHP original version, I would suggest you add a switch so that users of the existing library can still opt-in to the legacy behaviour in case they rely on old expressions. This could help them migrate to the new library.

[SamMousa]

I'm rebuilding the PHP library.

• Already fully rebuilt the lexer
• Modern PHP 8.4 required, use enum instead of string constants.
• Strict types
• Upgrade to PHPUnit 12
• Automated releases via CI

I can add the switch for the legacy behavior. (Or create a different class for people who want the old behavior)
Could you set me up a new repo for the PHP library?

[springcomp]

Could you set me up a new repo for the PHP library?

@SamMousa Welcome to JMESPath Community!
I have sent you an invite and will set you up as owner of the php-jmespath repository.