Empty JSON literals should return an empty string

Author: mtdowling

src/Lexer.php

@@ -68,25 +68,20 @@ public function tokenize($input)
                 switch ($token['type']) {
                     case 'quoted_identifier':
                         $token['value'] = $this->decodeJson(
-                            $token['value'],
-                            $offset,
-                            $input
+                            $token['value'], $offset, $input
                         );
                         break;
                     case 'number':
                         $token['value'] = (int) $token['value'];
                         break;
                     case 'literal':
-                        $token['value'] = $this->takeLiteral(
-                            $token['value'],
-                            $offset,
-                            $input
+                        $token['value'] = $this->literal(
+                            $token['value'], $offset, $input
                         );
                         break;
                 }
                 $tokens[] = $token;
             }
-
             $offset += strlen($match[0]);
         }
 
@@ -99,15 +94,11 @@ public function tokenize($input)
         return $tokens;
     }
 
-    private function takeLiteral($value, $offset, $input)
+    private function literal($value, $offset, $input)
     {
         static $valid = '/(true|false|null)|(^[\["{])|(^\-?[0-9]*(\.[0-9]+)?([e|E][+|\-][0-9]+)?$)/';
         $value = str_replace('\\`', '`', ltrim(substr($value, 1, -1)));
 
-        if ($value === '') {
-            throw $this->throwSyntax('Empty JSON literal', $offset, $input);
-        }
-
         return preg_match($valid, $value)
             ? $this->decodeJson($value, $offset, $input)
             : $this->decodeJson('"' . $value . '"', $offset, $input);

tests/LexerTest.php

@@ -25,22 +25,6 @@ public function testValidatesClosedQuotes()
         }
     }
 
-    public function testValidatesLiteralValuesAreSet()
-    {
-        $l = new Lexer();
-        try {
-            $l->tokenize('``');
-            $this->fail('Did not throw');
-        } catch (SyntaxErrorException $e) {
-            $expected = <<<EOT
-Syntax error at character 0
-``
-^
-EOT;
-            $this->assertContains($expected, $e->getMessage());
-        }
-    }
-
     public function testValidatesLiteralValuesAreClosed()
     {
         $l = new Lexer();