Merge pull request #56 from geophilusd/cleanup

Add frozen_string_literal to all files and some static code cleanup

Author: mullermp

Gemfile

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 source 'https://rubygems.org'
 
 gem 'rake', require: false

Rakefile

@@ -1,6 +1,7 @@
+# frozen_string_literal: true
 $GEM_ROOT = File.dirname(__FILE__)
 
-$: << File.join($GEM_ROOT, 'lib')
+$LOAD_PATH << File.join($GEM_ROOT, 'lib')
 
 $VERSION = ENV['VERSION'] || File.read(File.join($GEM_ROOT, 'VERSION'))
 $GITHUB_ACCESS_TOKEN = ENV['JMESPATH_GITHUB_ACCESS_TOKEN']

bin/jmespath.rb

@@ -1,6 +1,7 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
-$:.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 
 require 'jmespath'
 require 'json'

gemfiles/json-latest.gemfile

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 eval_gemfile(File.expand_path('../../Gemfile', __FILE__))
 
 gem 'json'

gemfiles/json-old.gemfile

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 eval_gemfile(File.expand_path('../../Gemfile', __FILE__))
 
 gem 'json', '< 2.0'

gemfiles/json-pure.gemfile

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 eval_gemfile(File.expand_path('../../Gemfile', __FILE__))
 
 gem 'json_pure', require: 'json/pure'

gemfiles/no-deps.gemfile

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 eval_gemfile(File.expand_path('../../Gemfile', __FILE__))
 
 # no dependency on `json` gem

jmespath.gemspec

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Gem::Specification.new do |spec|
   spec.name          = 'jmespath'
   spec.version       = File.read(File.expand_path('../VERSION', __FILE__)).strip
@@ -8,5 +9,5 @@ Gem::Specification.new do |spec|
   spec.homepage      = 'http://github.com/trevorrowe/jmespath.rb'
   spec.license       = 'Apache-2.0'
   spec.require_paths = ['lib']
-  spec.files         = Dir['lib/**/*.rb'] + %w[LICENSE.txt VERSION]
+  spec.files         = Dir['lib/**/*.rb'] + %w(LICENSE.txt VERSION)
 end

lib/jmespath.rb

@@ -1,9 +1,9 @@
+# frozen_string_literal: true
 require 'json'
 require 'stringio'
 require 'pathname'
 
 module JMESPath
-
   require 'jmespath/caching_parser'
   require 'jmespath/errors'
   require 'jmespath/lexer'
@@ -16,26 +16,24 @@ module JMESPath
   require 'jmespath/version'
 
   class << self
-
     # @param [String] expression A valid
     #   [JMESPath](https://github.com/boto/jmespath) expression.
     # @param [Hash] data
     # @return [Mixed,nil] Returns the matched values. Returns `nil` if the
     #   expression does not resolve inside `data`.
     def search(expression, data, runtime_options = {})
       data = case data
-        when Hash, Struct then data # check for most common case first
-        when Pathname then load_json(data)
-        when IO, StringIO then JSON.parse(data.read)
-        else data
+             when Hash, Struct then data # check for most common case first
+             when Pathname then load_json(data)
+             when IO, StringIO then JSON.parse(data.read)
+             else data
         end
       Runtime.new(runtime_options).search(expression, data)
     end
 
     # @api private
     def load_json(path)
-      JSON.parse(File.open(path, 'r', encoding: 'UTF-8') { |f| f.read })
+      JSON.parse(File.open(path, 'r', encoding: 'UTF-8', &:read))
     end
-
   end
 end

lib/jmespath/caching_parser.rb

@@ -1,8 +1,8 @@
+# frozen_string_literal: true
 require 'thread'
 
 module JMESPath
   class CachingParser
-
     def initialize(options = {})
       @parser = options[:parser] || Parser.new(options)
       @mutex = Mutex.new
@@ -25,6 +25,5 @@ def cache_expression(expression)
         @cache[expression] = @parser.parse(expression)
       end
     end
-
   end
 end