Merge branch 'master' of https://github.com/jmh530/mir-algorithm

Author: jmh530

README.md

@@ -85,9 +85,3 @@ void main()
 ```
 
 [![Open on run.dlang.io](https://img.shields.io/badge/run.dlang.io-open-blue.svg)](https://run.dlang.io/is/67Gi6X)
-
-### Our sponsors
-
-[<img src="https://raw.githubusercontent.com/libmir/mir-algorithm/master/images/symmetry.png" height="80" />](http://symmetryinvestments.com/) 	&nbsp; 	&nbsp;	&nbsp;	&nbsp;
-[<img src="https://raw.githubusercontent.com/libmir/mir-algorithm/master/images/kaleidic.jpeg" height="80" />](https://github.com/kaleidicassociates)
-

images/symmetry.png

@@ -20,8 +20,10 @@ $(T2 find, Finds backward index.)
 $(T2 findIndex, Finds index.)
 $(T2 fold, Accumulates all elements (different parameter order than `reduce`).)
 $(T2 isSymmetric, Checks if the matrix is symmetric.)
+$(T2 maxElement, Returns the maximum.)
 $(T2 maxIndex, Finds index of the maximum.)
 $(T2 maxPos, Finds backward index of the maximum.)
+$(T2 minElement, Returns the minimum.)
 $(T2 minIndex, Finds index of the minimum.)
 $(T2 minmaxIndex, Finds indices of the minimum and the maximum.)
 $(T2 minmaxPos, Finds backward indices of the minimum and the maximum.)
@@ -119,7 +121,7 @@ private struct BitSliceAccelerator(Field, I = typeof(Field.init[size_t.init]))
     import mir.ndslice.field: BitField;
 
     ///
-    alias U = typeof(I + 1u);
+    alias U = typeof(I.init + 1u);
     /// body bits chunks
     static if (isIterator!Field)
         Slice!Field bodyChunks;
@@ -4432,3 +4434,86 @@ unittest
     auto z4 = y.minIndex;
     auto z5 = y.maxIndex;
 }
+
+/++
+Returns the minimal(maximal) element of a multidimensional slice.
+
+Params:
+    pred = A predicate.
+
+See_also:
+    $(LREF minIndex),
+    $(LREF maxElement),
+    $(LREF maxIndex),
+    $(LREF maxPos).
++/
+template minElement(alias pred = "a < b")
+{
+    import mir.functional: naryFun;
+    static if (__traits(isSame, naryFun!pred, pred))
+    /++
+    Params:
+        slice = ndslice.
+    Returns:
+        Minimal(maximal) element of a multidimensional slice
+    +/
+    @fmamath DeepElementType!(Slice!(Iterator, N, kind)) minElement(Iterator, size_t N, SliceKind kind)(Slice!(Iterator, N, kind) slice)
+    {
+        return slice[slice.minIndex!pred];
+    }
+    else
+        alias minElement = .minElement!(naryFun!pred);
+}
+
+/// ditto
+template maxElement(alias pred = "a < b")
+{
+    import mir.functional: naryFun, reverseArgs;
+    alias maxElement = minElement!(reverseArgs!(naryFun!pred));
+}
+
+///
+@safe pure nothrow
+version(mir_test)
+unittest
+{
+    import mir.ndslice.slice: sliced;
+    auto s = [
+        2, 6, 4, -3,
+        0, -4, -3, 3,
+        -3, -2, 7, 8,
+        ].sliced(3, 4);
+
+    assert(s.minElement == -4);
+    assert(s.maxElement == 8);
+}
+
+///
+@safe pure nothrow
+version(mir_test)
+unittest
+{
+    import mir.ndslice.slice: sliced;
+    auto s = [
+        -8, 6, 4, -3,
+        0, -4, -3, 3,
+        -3, -2, 7, 8,
+        ].sliced(3, 4);
+
+    assert(s.minElement == -8);
+}
+
+@safe pure nothrow
+version(mir_test)
+unittest
+{
+    import mir.ndslice.slice: sliced;
+    auto s = [
+            0, 1, 2, 3,
+            4, 5, 6, 7,
+            8, 9, 10, 11
+            ].sliced(3, 4);
+
+    assert(s.minElement == 0);
+    assert(s.maxElement == 11);
+}

source/mir/algorithm/iteration.d

@@ -38,6 +38,9 @@ struct Decimal(uint size64)
     void toString(C = char, W)(ref scope W w, NumericSpec spec = NumericSpec.init) const scope
         if(isSomeChar!C && isMutable!C)
     {
+        scope C[] _buffer;
+        if (false) w.put(_buffer);
+        () @trusted {
         assert(spec.format == NumericSpec.Format.exponent || spec.format == NumericSpec.Format.human);
         import mir.utility: _expect;
         // handle special values
@@ -212,6 +215,7 @@ struct Decimal(uint size64)
         auto expLength = printSignedToTail(exponent, buffer0[$ - N - 16 .. $ - 16], '+');
         buffer[$ - ++expLength] = spec.exponentChar;
         w.put(buffer[$ - expLength .. $]);
+    } ();
     }
 
 @safe:
@@ -422,7 +426,7 @@ struct Decimal(uint size64)
     }
 
     ///
-    ref opOpAssign(string op, size_t rhsMaxSize64)(ref const Decimal!rhsMaxSize64 rhs) @safe pure return
+    ref opOpAssign(string op, size_t rhsMaxSize64)(ref const Decimal!rhsMaxSize64 rhs) @trusted pure return
         if (op == "+" || op == "-")
     {
         import mir.utility: max;
@@ -450,7 +454,7 @@ struct Decimal(uint size64)
 
 ///
 version(mir_bignum_test)
-@safe pure nothrow @nogc
+@trusted pure nothrow @nogc
 unittest
 {
     import mir.test: should;

source/mir/bignum/decimal.d

@@ -963,7 +963,7 @@ UInt!(size + size_t.sizeof * 8)
     extendedMul(size_t size)(UInt!size a, size_t b)
     @safe pure nothrow @nogc
 {
-    size_t overflow = a.view *= b;
+    size_t overflow = a.view.opOpAssign!"*"(b);
     auto ret = a.toSize!(size + size_t.sizeof * 8);
     ret.data[$ - 1] = overflow;
     return ret;
@@ -1060,6 +1060,7 @@ UInt!(size + size_t.sizeof * 8)
 {
     auto ret = extendedMul(a, b);
     auto view = ret.view;
-    view.coefficients[$ - 1] += view.topLeastSignificantPart(a.data.length) += c.view;
+    view.coefficients[$ - 1] +=
+        view.topLeastSignificantPart(a.data.length).opOpAssign!"+"(c.view);
     return ret;
 }

source/mir/bignum/fixed.d

@@ -637,7 +637,7 @@ struct Fp(uint size)
 
 ///
 Fp!(coefficientizeA + coefficientizeB) extendedMul(bool noSpecial = false, uint coefficientizeA, uint coefficientizeB)(Fp!coefficientizeA a, Fp!coefficientizeB b)
-    @safe pure nothrow @nogc
+    @trusted pure nothrow @nogc
 {
     import mir.bignum.fixed: extendedMul;
     import mir.checkedint: adds;

source/mir/bignum/fp.d

@@ -263,7 +263,7 @@ struct BigInt(uint size64)
     }
 
     ///
-    BigInt copy() @property
+    BigInt copy() @property @trusted
     {
         BigInt ret = void;
         ret.sign = sign;
@@ -479,7 +479,7 @@ struct BigInt(uint size64)
 
     ///ditto
     ref powMod()(scope BigUIntView!(const size_t) exponent, scope ref const BigInt modulus)
-        @safe pure nothrow @nogc return scope
+        @trusted pure nothrow @nogc return scope
     {
         pragma(inline, false);
 
@@ -654,7 +654,7 @@ struct BigInt(uint size64)
         remainder or quotient from the truncated division
     +/
     ref opOpAssign(string op : "*", size_t rhsSize64)(scope const ref BigInt!rhsSize64 rhs)
-        @safe pure nothrow @nogc return
+        @trusted pure nothrow @nogc return
     {
         BigInt!(size64 + rhsSize64) c = void;
         c.multiply(this, rhs);

source/mir/bignum/integer.d

@@ -288,7 +288,7 @@ private template bigSize(T)
     }
 }
 
-@optStrategy("minsize")
+@optStrategy("minsize") @trusted
 private T algorithmM(T)(scope const size_t[] coefficients, long exponent)
     if ((is(T == float) || is(T == double) || is(T == real)))
     in (coefficients.length)

source/mir/bignum/internal/dec2float.d

@@ -88,7 +88,7 @@ unittest
 }
 
 /// Concatenated string results
-string text(string separator = "", Args...)(auto scope ref const Args args)
+string text(string separator = "", Args...)(auto ref scope const Args args)
     if (Args.length > 0)
 {
     import mir.utility: _expect;
@@ -607,7 +607,7 @@ void printElement(C = char, EscapeFormat escapeFormat = EscapeFormat.ion, W, T)(
 /++
 Multiargument overload.
 +/
-void print(C = char, W, Args...)(scope ref W w, auto scope ref const Args args)
+void print(C = char, W, Args...)(scope ref W w, auto ref scope const Args args)
     if (isSomeChar!C && Args.length > 1)
 {
     foreach(i, ref c; args)

source/mir/format.d

@@ -843,7 +843,7 @@ struct Spline(F, size_t N = 1, X = F)
         this._data = shape.rcslice!(F[2 ^^ N]);
     }
 
-    package static auto pickDataSubslice(D)(auto scope ref D data, size_t index) @trusted
+    package static auto pickDataSubslice(D)(auto ref scope D data, size_t index) @trusted
     {
         auto strides = data.strides;
         foreach (i; Iota!(strides.length))