forked from fastmachinelearning/hls4ml
-
Notifications
You must be signed in to change notification settings - Fork 1
QONNX Resize node support
#8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nghielme
wants to merge
1
commit into
jmitrevs:qonnx-1p0
Choose a base branch
from
nghielme:qonnx-resize
base: qonnx-1p0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| from hls4ml.model.layers import Resize | ||
| from hls4ml.model.optimizer import OptimizerPass | ||
|
|
||
| def register_match_quantizer_resize(backend): | ||
| backend.register_pass('match_quantizer_resize', MatchQuantizerResize) | ||
|
|
||
| class MatchQuantizerResize(OptimizerPass): | ||
| def match(self, node): | ||
| if isinstance(node, Resize) and node.get_input_variable().type.precision != node.get_output_variable().type.precision: | ||
| return True | ||
| else: | ||
| return False | ||
|
|
||
| def transform(self, model, node): | ||
| node.get_input_variable().type.precision = node.get_output_variable().type.precision | ||
| return True | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| from hls4ml.model.layers import Constant, Resize | ||
| from hls4ml.model.optimizer import OptimizerPass | ||
|
|
||
| class ResizeConstant(OptimizerPass): | ||
| """ | ||
| To compute the output shape of resize is necessary to access the scales, that | ||
| are stored as initilizer, later on converted as constant inputs. | ||
| ONNX has the output shape come as an input, not a parameter. This removes | ||
| the Constant input from new shape input, other than computing the output | ||
| shape for the resize node. | ||
| """ | ||
| def match(self, node): | ||
| is_match = isinstance(node, Resize) and len(node.inputs) > 1 and node.get_input_node(node.inputs[-1]) | ||
| return is_match | ||
|
|
||
| def transform(self, model, node): | ||
| """ | ||
| Remove Constant from new shape input. Note, input shape node is already used on initialize | ||
| """ | ||
| scales_node = node.get_input_node(node.inputs[-1]) | ||
| node.inputs[-1] = '' | ||
| scales_values = scales_node.get_attr('value') | ||
| node.set_attr('out_width', int(node.get_attr('in_width') * scales_values[1])) | ||
| node.set_attr('out_height', int(node.get_attr('in_height') * scales_values[2])) | ||
| if not isinstance(scales_node, Constant): | ||
| raise RuntimeError("Nonconstant shape inputs are not currently supported") | ||
| model.remove_node(scales_node, rewire=False) | ||
| return True |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need a second optimizer that does the work meant to be done by infer-precision
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd generally agree but this is for the specific implementation of resize nearest for vivado/vitis. Other type of resize algorithm may require different type of type inference