Download distributed query results if > 100#730
Merged
Conversation
javuto
added
osctrl-admin
Contributor
There was a problem hiding this comment.
Pull Request Overview
Implements download functionality for distributed query results when they exceed 100 entries, optimizing UI performance by preventing large datasets from being displayed in tables. This feature is only available when UI optimization is enabled.
- Adds conditional download link display for result sets > 100 entries
- Implements new download endpoint for exporting full query logs as JSON
- Enhances result display with table formatting for better readability
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cmd/admin/templates/queries-logs.html | Adds download link UI and improved table rendering for query results |
| cmd/admin/main.go | Registers new download endpoint conditionally when UI optimization is enabled |
| cmd/admin/handlers/json-logs.go | Implements download handler and adds download URL field to response structure |
Comments suppressed due to low confidence (1)
cmd/admin/handlers/json-logs.go:1
- The condition 'downloadUrl && downloadUrl !== ""' is redundant. Since downloadUrl is assigned from json.download with a fallback to empty string, checking just 'downloadUrl' would be sufficient.
package handlers
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of #728 with a download link for on-demand query results if they are over a max number (100 entries). UI optimization must be enabled (
OPTIMIZE_UI=true).