Replies: 1 comment
-
|
thanks a lot @Samira-El ! Thanks for these changes! They will definitely make things easier to work with. Also, BigQuery has a free tier that should be enough for testing this tap. I'm happy to help you setting that up if that would be useful to you |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Hey @jmriego, I made a PR earlier to revamp CI and move away from CircleCI since we no longer want to use CCI at Wise, and while doing it I had to make pylint happy by making few changes. One of these changes is this: https://github.com/transferwise/pipelinewise-target-bigquery/pull/30/files#diff-ff318a6d5029dba063770c4d125983107cb7c55c06190a9173cbc9e24a5df202L204
I don't have a bigquery instance to test if this is a breaking change or not, but I also noticed that this dictionary
csv_files_to_loadis not being used anywhere, it's declared then a temp file gets created for every stream and that's it.Do you mind looking into it?
Beta Was this translation helpful? Give feedback.
All reactions