Skip to content

Commit a79e60f

Browse files
guparanjnbrunet
authored andcommitted
[bindings] FIX FileRepository binding (doLowerCaseOnWin32 removal) (sofa-framework#150)
1 parent 041eb25 commit a79e60f

File tree

3 files changed

+2
-8
lines changed

3 files changed

+2
-8
lines changed

bindings/Sofa/src/SofaPython3/Sofa/Helper/System/Binding_FileRepository.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ void moduleAddFileRepository(py::module &m) {
8282
file_repository.def_static(
8383
"relativeToPath",
8484
&sofa::helper::system::FileRepository::relativeToPath,
85-
py::arg("path").none(false), py::arg("refPath").none(false), py::arg("doLowerCaseOnWin32") = true,
85+
py::arg("path").none(false), py::arg("refPath").none(false),
8686
doc::FileRepository::relativeToPath
8787
);
8888

bindings/Sofa/src/SofaPython3/Sofa/Helper/System/Binding_FileRepository_doc.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,6 @@ static auto relativeToPath =
8282
R"(
8383
Returns a string such as refPath + string = path if path contains refPath.
8484
Otherwise returns path.
85-
On WIN32 the implementation was also returning the path in lower case. This behavior is now
86-
deprecated and should be remove the 2018-05-01. Until this date new implementation can be
87-
used by setting doLowerCaseOnWin32=false;
8885
)";
8986

9087
static auto getPathsJoined =

docs/sphinx-stubs/Sofa/Helper/System/__init__.pyi

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -96,13 +96,10 @@ class FileRepository():
9696
Print the list of path to std::cout.
9797
"""
9898
@staticmethod
99-
def relativeToPath(path: str, refPath: str, doLowerCaseOnWin32: bool = True) -> str:
99+
def relativeToPath(path: str, refPath: str) -> str:
100100
"""
101101
Returns a string such as refPath + string = path if path contains refPath.
102102
Otherwise returns path.
103-
On WIN32 the implementation was also returning the path in lower case. This behavior is now
104-
deprecated and should be remove the 2018-05-01. Until this date new implementation can be
105-
used by setting doLowerCaseOnWin32=false;
106103
"""
107104
def removePath(self, path: str) -> None:
108105
"""

0 commit comments

Comments
 (0)