chore: improve docker + compose

The following docker fixes are in place:
 - transitions to using npm in docker.
 - removes extraneous comments and environmental variables in dockerfile.

The following compose fixes are in place:
 - adds a networking layer
 - uses the correct mysql 8.4 auth plugin call
 - removes the extraneous UTF8 variables
 - removes the deprecated version tag

Author: jniles

.dockerignore

@@ -2,16 +2,19 @@
 node_modules
 .git
 
-# ignore loggin utilities
+# ignore logging utilities
 npm-debug.log
 yarn-error.log
 
 # ignore documentation
 *.md
+CNAME
 
 # ignore unnecessary folders
 docs
 temp
-test
+test*
+results
 sh
 bin
+

Dockerfile

@@ -1,43 +1,41 @@
-# define base image
-FROM node:lts-slim
+FROM node:lts
 
-# download all the missing dependencies for chromium, plus chromium itself
+# Install missing dependencies for chromium
+# These are all needed to make sure the browser can properly render all
+# the requiredd page
 RUN apt-get update && apt-get install -y \
   ca-certificates fonts-liberation gconf-service \
   libappindicator1 libasound2 libatk-bridge2.0-0 libatk1.0-0 libc6 libcairo2  \
   libcups2 libdbus-1-3 libexpat1 libfontconfig1 libgbm1 libgcc1 libgconf-2-4 \
   libgdk-pixbuf2.0-0 libglib2.0-0 libgtk-3-0 libnspr4 libnss3 libpango-1.0-0 \
   libpangocairo-1.0-0 libstdc++6 libx11-6 libx11-xcb1 libxcb1 libxcomposite1 \
   libxcursor1 libxdamage1 libxext6 libxfixes3 libxi6 libxrandr2 libxrender1 \
-  libxss1 libxtst6 lsb-release libxshmfence1 chromium -y
+  libxss1 libxtst6 lsb-release libxshmfence1 chromium -y \
+  && rm -rf /var/lib/apt/lists/*
 
-# ENV NODE_ENV=production
-ENV YARN_VERSION 1.22.17
-#ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD 1
-RUN yarn policies set-version $YARN_VERSION
-#ENV CHROME_BIN /usr/bin/chromium
-#ENV PUPPETEER_EXECUTABLE_PATH /usr/bin/chromium
-
-# define working directory inside the container
+# Set working directory
 WORKDIR /usr/src/app
 
-# Copy all the source code from host machine to the container project directory
+# Copy source code
 COPY . .
 
-# install all the dependencies
-RUN yarn --frozen-lockfile && yarn build
+# Install dependencies
+RUN npm install && \
+   NODE_ENV=production npm run build && \
+   npm install --omit=dev
 
-# yarn build creates the bin/ folder
+# Copy environment file to bin folder
 COPY .env bin/
 
-# change directory to the bin diretory
+# Change directory to bin
 WORKDIR /usr/src/app/bin/
 
-# make sure the node user is the owner of all the underlying files.
+# Set ownership
 RUN chown -R node:node *
 
-# ensure this container runs as the user "node"
+# Switch to non-root user
 USER node
 
-# define the start up command of the container to run the server
-CMD ["node", "server/app.js"]
+# Define startup command
+CMD ["NODE_ENV=production", "node", "server/app.js"]
+

docker-compose.yml

@@ -1,5 +1,3 @@
-version: '3'
-
 services:
   bhima:
     build: .
@@ -13,14 +11,15 @@ services:
     depends_on:
       - mysql
       - redis
+    networks:
+      - backend
+
   mysql:
     image: mysql:8
-    restart: always
+    restart: unless-stopped
     command:
-      - --default-authentication-plugin=mysql_native_password
+      - --mysql-native-password=ON
       - --sql-mode=STRICT_ALL_TABLES,NO_UNSIGNED_SUBTRACTION
-      - --character-set-server=utf8mb4
-      - --collation-server=utf8mb4_unicode_ci
     volumes:
       - mysqldata:/var/lib/mysql/
       - "./temp/docker-build.sql:/docker-entrypoint-initdb.d/bhima.sql"
@@ -29,9 +28,18 @@ services:
       - MYSQL_USER=$DB_USER
       - MYSQL_PASSWORD=$DB_PASS
       - MYSQL_DATABASE=$DB_NAME
+    networks:
+      - backend
+
   redis:
     image: redis:latest
-    restart: always
+    restart: unless-stopped
+    networks:
+      - backend
+
+networks:
+  backend:
 
 volumes:
   mysqldata:
+