Address various missed protocol changes in the 12.50 update (#43)

Author: jo3bingham

TibiaAPI/GlobalSuppressions.cs

@@ -4,11 +4,6 @@
 // Project-level suppressions either have no target or are given 
 // a specific target and scoped to a namespace, type, member, etc.
 
-[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Performance", "CA1812:Avoid uninstantiated internal classes", Justification = "<Pending>", Scope = "type", Target = "~T:OXGaming.TibiaAPI.Network.LoginData")]
-[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Performance", "CA1812:Avoid uninstantiated internal classes", Justification = "<Pending>", Scope = "type", Target = "~T:OXGaming.TibiaAPI.Network.Session")]
-[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Performance", "CA1812:Avoid uninstantiated internal classes", Justification = "<Pending>", Scope = "type", Target = "~T:OXGaming.TibiaAPI.Network.PlayData")]
-[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Performance", "CA1812:Avoid uninstantiated internal classes", Justification = "<Pending>", Scope = "type", Target = "~T:OXGaming.TibiaAPI.Network.World")]
-[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Performance", "CA1812:Avoid uninstantiated internal classes", Justification = "<Pending>", Scope = "type", Target = "~T:OXGaming.TibiaAPI.Network.Character")]
 [assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Naming", "CA1716:Identifiers should not match keywords", Justification = "<Pending>", Scope = "type", Target = "~T:OXGaming.TibiaAPI.Network.ClientPackets.Stop")]
 [assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Globalization", "CA1305:Specify IFormatProvider", Justification = "<Pending>", Scope = "member", Target = "~M:OXGaming.TibiaAPI.Network.Communication.ParseClientMessage(OXGaming.TibiaAPI.Client,OXGaming.TibiaAPI.Network.NetworkMessage,OXGaming.TibiaAPI.Network.NetworkMessage)")]
 [assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1056:Uri properties should not be strings", Justification = "<Pending>", Scope = "member", Target = "~P:OXGaming.TibiaAPI.Network.ServerPackets.LoginSuccess.StoreBaseUrl")]

TibiaAPI/Network/ServerPackets/EditText.cs

@@ -15,6 +15,8 @@ public class EditText : ServerPacket
 
         public ushort MaxTextLength { get; set; }
 
+        public byte Unknown { get; set; }
+
         public EditText(Client client)
         {
             Client = client;
@@ -28,6 +30,10 @@ public override void ParseFromNetworkMessage(NetworkMessage message)
             MaxTextLength = message.ReadUInt16();
             Text = message.ReadString();
             Author = message.ReadString();
+            if (Client.VersionNumber >= 125010109)
+            {
+                Unknown = message.ReadByte();
+            }
             Date = message.ReadString();
         }
 
@@ -39,6 +45,10 @@ public override void AppendToNetworkMessage(NetworkMessage message)
             message.Write(MaxTextLength);
             message.Write(Text);
             message.Write(Author);
+            if (Client.VersionNumber >= 125010109)
+            {
+                message.Write(Unknown);
+            }
             message.Write(Date);
         }
     }

TibiaAPI/Network/ServerPackets/MarketEnter.cs

@@ -22,7 +22,11 @@ public MarketEnter(Client client)
 
         public override void ParseFromNetworkMessage(NetworkMessage message)
         {
-            AccountBalance = message.ReadInt64();
+            if (Client.VersionNumber < 125000000)
+            {
+                AccountBalance = message.ReadInt64();
+            }
+
             ActiveOffers = message.ReadByte();
 
             DepotObjects.Capacity = message.ReadUInt16();
@@ -37,7 +41,12 @@ public override void ParseFromNetworkMessage(NetworkMessage message)
         public override void AppendToNetworkMessage(NetworkMessage message)
         {
             message.Write((byte)ServerPacketType.MarketEnter);
-            message.Write(AccountBalance);
+
+            if (Client.VersionNumber < 125000000)
+            {
+                message.Write(AccountBalance);
+            }
+
             message.Write(ActiveOffers);
 
             var count = Math.Min(DepotObjects.Count, ushort.MaxValue);

TibiaAPI/Network/ServerPackets/Talk.cs

@@ -31,7 +31,7 @@ public override void ParseFromNetworkMessage(NetworkMessage message)
         {
             StatementId = message.ReadUInt32();
             SpeakerName = message.ReadString();
-            if (Client.VersionNumber >= 125010109)
+            if (Client.VersionNumber >= 125010109 && StatementId != 0)
             {
                 IsTraded = message.ReadBool();
             }
@@ -94,7 +94,7 @@ public override void AppendToNetworkMessage(NetworkMessage message)
             message.Write((byte)ServerPacketType.Talk);
             message.Write(StatementId);
             message.Write(SpeakerName);
-            if (Client.VersionNumber >= 125010109)
+            if (Client.VersionNumber >= 125010109 && StatementId != 0)
             {
                 message.Write(IsTraded);
             }