I've started to implement the IoT XEPs for XMPP-FTW. Some initial feedback based on a first reading. Potentially more to come.
- Example 2 - stanza 3
- I don't think
result='true' is required here
- Example 2 - stanza 4
- A simple
<iq type='result' /> should be enough here
- Example 3 - stanza 2
- A simple
<iq type='result' /> should be enough here
Example 4 - stanza 2
- Why not use standard XMPP error responses, e.g.
<iq type='error'><error type='auth'>.<not-allowed xmlns='urn:ietf:params:xml:ns:xmpp-stanzas' /></error></iq>
- Example 7 - as above for results
- Example 8 - stanza 4
<iq type='result'/> should be enough here
- Example 9 - stanza 4 : as above
- Example 10 - stanza 3+4
- Utilise standard XMPP errors here
- Example 13
- stanza 1 : potentially should be set
- stanza 2 : just
<iq type='result' />
- Example 16 - stanza 2
- Example 17 - stanza 2 - as above
nodeId attributes could probably be replaced with just id as the data is already in a <node/> element
Hopefully I'll be able to provide some (more) useful feedback
I've started to implement the IoT XEPs for XMPP-FTW. Some initial feedback based on a first reading. Potentially more to come.
result='true'is required here<iq type='result' />should be enough here<iq type='result' />should be enough hereExample 4 - stanza 2
<iq type='error'><error type='auth'>.<not-allowed xmlns='urn:ietf:params:xml:ns:xmpp-stanzas' /></error></iq><iq type='result'/>should be enough here<iq type='result' /><iq type='result'/>nodeIdattributes could probably be replaced with justidas the data is already in a<node/>elementHopefully I'll be able to provide some (more) useful feedback