Skip to content

Commit 0fbe900

Browse files
author
joaosaffran
committed
format
1 parent 987901c commit 0fbe900

File tree

3 files changed

+22
-20
lines changed

3 files changed

+22
-20
lines changed

llvm/include/llvm/BinaryFormat/DXContainer.h

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ struct ShaderHash {
6666
void swapBytes() { sys::swapByteOrder(Flags); }
6767
};
6868

69-
7069
struct ContainerVersion {
7170
uint16_t Major;
7271
uint16_t Minor;
@@ -552,17 +551,17 @@ static_assert(sizeof(ProgramSignatureElement) == 32,
552551

553552
struct RootSignatureValidations {
554553

555-
static Expected<uint32_t> validateRootFlag(uint32_t Flags) {
556-
if ((Flags & ~0x80000fff) != 0)
557-
return llvm::make_error<object::GenericBinaryError>("Invalid flag");
558-
return Flags;
559-
}
554+
static Expected<uint32_t> validateRootFlag(uint32_t Flags) {
555+
if ((Flags & ~0x80000fff) != 0)
556+
return llvm::make_error<object::GenericBinaryError>("Invalid flag");
557+
return Flags;
558+
}
560559

561-
static Expected<uint32_t> validateVersion(uint32_t Version) {
562-
if (Version < 1 || Version > 2)
563-
return llvm::make_error<object::GenericBinaryError>("Invalid Version");
564-
return Version;
565-
}
560+
static Expected<uint32_t> validateVersion(uint32_t Version) {
561+
if (Version < 1 || Version > 2)
562+
return llvm::make_error<object::GenericBinaryError>("Invalid Version");
563+
return Version;
564+
}
566565
};
567566

568567
} // namespace dxbc

llvm/lib/Object/DXContainer.cpp

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -248,17 +248,18 @@ void DXContainer::PartIterator::updateIteratorImpl(const uint32_t Offset) {
248248
Error DirectX::RootSignature::parse(StringRef Data) {
249249
const char *Current = Data.begin();
250250

251-
252251
// Root Signature headers expects 6 integers to be present.
253252
if (Data.size() < 6 * sizeof(uint32_t)) {
254253
return parseFailed("Invalid data. Too small.");
255254
}
256255

257-
uint32_t VValue = support::endian::read<uint32_t, llvm::endianness::little>(Current);
256+
uint32_t VValue =
257+
support::endian::read<uint32_t, llvm::endianness::little>(Current);
258258
Current += sizeof(uint32_t);
259259

260-
Expected<uint32_t> MaybeVersion = dxbc::RootSignatureValidations::validateVersion(VValue);
261-
if(Error E = MaybeVersion.takeError())
260+
Expected<uint32_t> MaybeVersion =
261+
dxbc::RootSignatureValidations::validateVersion(VValue);
262+
if (Error E = MaybeVersion.takeError())
262263
return E;
263264
Version = MaybeVersion.get();
264265

@@ -278,11 +279,13 @@ Error DirectX::RootSignature::parse(StringRef Data) {
278279
support::endian::read<uint32_t, llvm::endianness::little>(Current);
279280
Current += sizeof(uint32_t);
280281

281-
uint32_t FValue = support::endian::read<uint32_t, llvm::endianness::little>(Current);
282+
uint32_t FValue =
283+
support::endian::read<uint32_t, llvm::endianness::little>(Current);
282284
Current += sizeof(uint32_t);
283285

284-
Expected<uint32_t> MaybeFlag = dxbc::RootSignatureValidations::validateRootFlag(FValue);
285-
if(Error E = MaybeFlag.takeError())
286+
Expected<uint32_t> MaybeFlag =
287+
dxbc::RootSignatureValidations::validateRootFlag(FValue);
288+
if (Error E = MaybeFlag.takeError())
286289
return E;
287290
Flags = MaybeFlag.get();
288291

llvm/unittests/Object/DXContainerTest.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -868,7 +868,7 @@ TEST(RootSignature, ParseRootFlags) {
868868
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
869869
0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00,
870870
};
871-
EXPECT_THAT_EXPECTED(DXContainer::create(getMemoryBuffer<68>(Buffer)),
871+
EXPECT_THAT_EXPECTED(DXContainer::create(getMemoryBuffer<68>(Buffer)),
872872
FailedWithMessage("Invalid Version"));
873873
}
874874
{
@@ -881,7 +881,7 @@ TEST(RootSignature, ParseRootFlags) {
881881
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
882882
0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0xFF,
883883
};
884-
EXPECT_THAT_EXPECTED(DXContainer::create(getMemoryBuffer<68>(Buffer)),
884+
EXPECT_THAT_EXPECTED(DXContainer::create(getMemoryBuffer<68>(Buffer)),
885885
FailedWithMessage("Invalid flag"));
886886
}
887887
}

0 commit comments

Comments
 (0)