[lldb] Re-skip PipeTest on windows for now

labath · joaosaffran · commit 82ac9aa82d21 · 2025-03-03T20:25:32.000Z
The tests are flaky because the read/write calls return sooner than they should (and llvm#128719 does not fix them). Skip them until we figure the best way to fix this.
diff --git a/lldb/unittests/Host/PipeTest.cpp b/lldb/unittests/Host/PipeTest.cpp
@@ -59,6 +59,8 @@ TEST_F(PipeTest, OpenAsReader) {
 }
 #endif
 
+// Tests flaky on Windows
+#ifndef _WIN32
 TEST_F(PipeTest, WriteWithTimeout) {
   Pipe pipe;
   ASSERT_THAT_ERROR(pipe.CreateNew(false).ToError(), llvm::Succeeded());
@@ -197,3 +199,4 @@ TEST_F(PipeTest, ReadWithTimeout) {
                        llvm::HasValue(hello_world.size()));
   EXPECT_EQ(llvm::StringRef(buf, hello_world.size()), hello_world);
 }
+#endif /*ifndef _WIN32*/

Original file line number	Diff line number	Diff line change
`@@ -59,6 +59,8 @@ TEST_F(PipeTest, OpenAsReader) {`
`59`	`59`	`}`
`60`	`60`	`#endif`
`61`	`61`
	`62`	`+// Tests flaky on Windows`
	`63`	`+#ifndef _WIN32`
`62`	`64`	`TEST_F(PipeTest, WriteWithTimeout) {`
`63`	`65`	`Pipe pipe;`
`64`	`66`	`ASSERT_THAT_ERROR(pipe.CreateNew(false).ToError(), llvm::Succeeded());`
`@@ -197,3 +199,4 @@ TEST_F(PipeTest, ReadWithTimeout) {`
`197`	`199`	`llvm::HasValue(hello_world.size()));`
`198`	`200`	`EXPECT_EQ(llvm::StringRef(buf, hello_world.size()), hello_world);`
`199`	`201`	`}`
	`202`	`+#endif /ifndef _WIN32/`