Skip to content

Commit 6be65cd

Browse files
committed
Merge branch 'next'
2 parents 01e8ea1 + d562764 commit 6be65cd

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

README.md

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
## 🎬 Prereqs
22

3-
- SvelteKit installed (`npx sv create [project_name]`)
3+
- SvelteKit: `npx sv create [project_name]`
4+
- (Or Svelte: `npm create vite@latest`)
45

56
## 🗜️ Setup
6-
1. Install [sv-arcgis](https://www.npmjs.com/package/sv-arcgis) `npm i sv-arcgis`
7-
2. Run sv-arcgis `npx sv-arcgis`
8-
3. ⚠️ Follow instructions in terminal
7+
8+
1. Install [sv-arcgis](https://www.npmjs.com/package/sv-arcgis) `npx sv-arcgis`
9+
2. ⚠️ Follow instructions in terminal
910

1011
## 📕 Notes
1112

@@ -15,10 +16,10 @@
1516

1617
## 🗺️ Roadmap
1718

18-
- Option for / intergrate OAuth2 https://developers.arcgis.com/documentation/security-and-authentication/user-authentication/arcgis-apis/
19-
- Update to use determine if Svelte Vite app? (Demo would need to be different)
20-
- Create tests (see https://www.youtube.com/watch?v=Xk8yaN9_PZA)
2119
- Create CI / CD (w/ tests)
20+
- Create tests (see https://www.youtube.com/watch?v=Xk8yaN9_PZA)
21+
- Option for / intergrate OAuth2 https://developers.arcgis.com/documentation/security-and-authentication/user-authentication/arcgis-apis/
22+
- [x] Update to work Svelte / Vite app (not just Kit)? (Demo would need to be different)
2223

2324
## 🙏 Help
2425

bin/sv-arcgis-setup.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -759,7 +759,7 @@ if (demo.DEMO === true) {
759759
// Update root page
760760
const rootRouteDir = isSvelte ? path.join(process.cwd(), 'src') : path.join(process.cwd(), 'src', 'routes');
761761
const rootPagePath = isSvelte ? path.join(rootRouteDir, 'App.svelte') : path.join(rootRouteDir, '+page.svelte');
762-
const rootPageUpdate = isSvelte ? \`import ArcGIS from './lib/ArcGIS.svelte';\` : \`<p>Visit the <a href="arcgis">arcgis demo page</a> and view console.log output</p>\`;
762+
const rootPageUpdate = isSvelte ? \n\`import ArcGIS from './lib/ArcGIS.svelte';\` : \`<p>Visit the <a href="arcgis">arcgis demo page</a> and view console.log output</p>\`;
763763
764764
// Read existing root page content and append the demo link
765765
if (fs.existsSync(rootPagePath) && isSvelteKit) {

0 commit comments

Comments
 (0)