Skip to content

Commit 4ed9017

Browse files
add altNames in any case (good practice)
1 parent 84025db commit 4ed9017

File tree

1 file changed

+7
-11
lines changed

1 file changed

+7
-11
lines changed

lib/ca.js

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ CA.prototype.loadCA = function () {
161161

162162
CA.prototype.generateServerCertificateKeys = function (hosts, cb) {
163163
if (typeof(hosts) === "string") hosts = [hosts];
164-
var mainHost = hosts.shift();
164+
var mainHost = hosts[0];
165165
var keysServer = pki.rsa.generateKeyPair(1024);
166166
var certServer = pki.createCertificate();
167167
certServer.publicKey = keysServer.publicKey;
@@ -176,16 +176,12 @@ CA.prototype.generateServerCertificateKeys = function (hosts, cb) {
176176
})
177177
certServer.setSubject(attrsServer);
178178
certServer.setIssuer(this.CAcert.issuer.attributes);
179-
var extensions = ServerExtensions;
180-
if (hosts.length) {
181-
extensions = ServerExtensions.concat([{
182-
name: 'subjectAltName',
183-
altNames: hosts.map(function(host) {
184-
return {type: 2, value: host};
185-
})
186-
}]);
187-
}
188-
certServer.setExtensions(extensions);
179+
certServer.setExtensions(ServerExtensions.concat([{
180+
name: 'subjectAltName',
181+
altNames: hosts.map(function(host) {
182+
return {type: 2, value: host};
183+
})
184+
}]));
189185
certServer.sign(this.CAkeys.privateKey, Forge.md.sha256.create());
190186
var certPem = pki.certificateToPem(certServer);
191187
var keyPrivatePem = pki.privateKeyToPem(keysServer.privateKey)

0 commit comments

Comments
 (0)