promisify native modules

Author: joeferraro

RNCookieManagerIOS/RNCookieManagerIOS.m

@@ -9,7 +9,10 @@ @implementation RNCookieManagerIOS
 
 RCT_EXPORT_MODULE()
 
-RCT_EXPORT_METHOD(set:(NSDictionary *)props callback:(RCTResponseSenderBlock)callback) {
+RCT_EXPORT_METHOD(set,
+    props:(NSDictionary *)props,
+    resolver:(RCTPromiseResolveBlock)resolve,
+    rejecter:(RCTPromiseRejectBlock)reject) {
     NSString *name = [RCTConvert NSString:props[@"name"]];
     NSString *value = [RCTConvert NSString:props[@"value"]];
     NSString *domain = [RCTConvert NSString:props[@"domain"]];
@@ -33,16 +36,23 @@ @implementation RNCookieManagerIOS
     NSHTTPCookie *cookie = [NSHTTPCookie cookieWithProperties:cookieProperties];
     [[NSHTTPCookieStorage sharedHTTPCookieStorage] setCookie:cookie];
 
-    callback(@[[NSNull null]]);
+    resolve();
 }
 
-RCT_EXPORT_METHOD(setFromResponse:(NSURL *)url value:(NSDictionary *)value callback:(RCTResponseSenderBlock)callback) {
-  NSArray *cookies = [NSHTTPCookie cookiesWithResponseHeaderFields:value forURL:url];
-  [[NSHTTPCookieStorage sharedHTTPCookieStorage] setCookies:cookies forURL:url mainDocumentURL:NULL];
-    callback(@[[NSNull null]]);
+RCT_EXPORT_METHOD(setFromResponse,
+    url:(NSURL *)url,
+    value:(NSDictionary *)value,
+    resolver:(RCTPromiseResolveBlock)resolve,
+    rejecter:(RCTPromiseRejectBlock)reject) {
+    NSArray *cookies = [NSHTTPCookie cookiesWithResponseHeaderFields:value forURL:url];
+    [[NSHTTPCookieStorage sharedHTTPCookieStorage] setCookies:cookies forURL:url mainDocumentURL:NULL];
+    resolve();
 }
 
-RCT_EXPORT_METHOD(getFromResponse:(NSURL *)url callback:(RCTResponseSenderBlock)callback) {
+RCT_EXPORT_METHOD(getFromResponse,
+    url:(NSURL *)url,
+    resolver:(RCTPromiseResolveBlock)resolve,
+    rejecter:(RCTPromiseRejectBlock)reject) {
     NSURLRequest *request = [NSURLRequest requestWithURL:url];
     [NSURLConnection sendAsynchronousRequest:request  queue:[[NSOperationQueue alloc] init]
                            completionHandler:^(NSURLResponse *response, NSData *data, NSError *error) {
@@ -57,38 +67,48 @@ @implementation RNCookieManagerIOS
             NSLog(@"cookie: name=%@, value=%@", cookie.name, cookie.value);
             [[NSHTTPCookieStorage sharedHTTPCookieStorage] setCookie:cookie];
         }
-        callback(@[[NSNull null], dics]);
+        resolve(dics);
     }];
 }
 
-RCT_EXPORT_METHOD(get:(NSURL *)url callback:(RCTResponseSenderBlock)callback) {
+RCT_EXPORT_METHOD(get,
+    url:(NSURL *) url,
+    resolver:(RCTPromiseResolveBlock)resolve,
+    rejecter:(RCTPromiseRejectBlock)reject) {
     NSMutableDictionary *cookies = [NSMutableDictionary dictionary];
     for (NSHTTPCookie *c in [[NSHTTPCookieStorage sharedHTTPCookieStorage] cookiesForURL:url]) {
         [cookies setObject:c.value forKey:c.name];
     }
-    callback(@[[NSNull null], cookies]);
+    resolve(cookies);
 }
 
-RCT_EXPORT_METHOD(clearAll:(RCTResponseSenderBlock)callback) {
+RCT_EXPORT_METHOD(clearAll,
+    resolver:(RCTPromiseResolveBlock)resolve,
+    rejecter:(RCTPromiseRejectBlock)reject) {
     NSHTTPCookieStorage *cookieStorage = [NSHTTPCookieStorage sharedHTTPCookieStorage];
     for (NSHTTPCookie *c in cookieStorage.cookies) {
         [cookieStorage deleteCookie:c];
     }
-    callback(@[[NSNull null]]);
+    resolve();
 }
 
-RCT_EXPORT_METHOD(clearByName:(NSString *)name callback:(RCTResponseSenderBlock)callback) {
+RCT_EXPORT_METHOD(clearByName,
+    name:(NSString *) name,
+    resolver:(RCTPromiseResolveBlock)resolve,
+    rejecter:(RCTPromiseRejectBlock)reject) {
     NSHTTPCookieStorage *cookieStorage = [NSHTTPCookieStorage sharedHTTPCookieStorage];
     for (NSHTTPCookie *c in cookieStorage.cookies) {
       if ([[c name] isEqualToString:name]) {
         [cookieStorage deleteCookie:c];
       }
     }
-    callback(@[[NSNull null]]);
+    resolve();
 }
 
 // TODO: return a better formatted list of cookies per domain
-RCT_EXPORT_METHOD(getAll:(RCTResponseSenderBlock)callback) {
+RCT_EXPORT_METHOD(getAll,
+    resolver:(RCTPromiseResolveBlock)resolve,
+    rejecter:(RCTPromiseRejectBlock)reject) {
     NSHTTPCookieStorage *cookieStorage = [NSHTTPCookieStorage sharedHTTPCookieStorage];
     NSMutableDictionary *cookies = [NSMutableDictionary dictionary];
     for (NSHTTPCookie *c in cookieStorage.cookies) {
@@ -99,7 +119,7 @@ @implementation RNCookieManagerIOS
         [d setObject:c.path forKey:@"path"];
         [cookies setObject:d forKey:c.name];
     }
-    callback(@[[NSNull null], cookies]);
+    resolve(cookies);
 }
 
 @end

android/src/main/java/com/psykar/cookiemanager/CookieManagerModule.java

@@ -8,6 +8,7 @@
 import com.facebook.react.bridge.Callback;
 import com.facebook.react.bridge.Arguments;
 import com.facebook.react.bridge.WritableMap;
+import com.facebook.react.bridge.Promise;
 
 import java.io.IOException;
 import java.net.URISyntaxException;
@@ -32,32 +33,32 @@ public String getName() {
     }
 
     @ReactMethod
-    public void set(ReadableMap cookie, final Callback callback) throws Exception {
+    public void set(ReadableMap cookie, final Promise promise) throws Exception {
         throw new Exception("Cannot call on android, try setFromResponse");
     }
 
     @ReactMethod
-    public void setFromResponse(String url, String value, final Callback callback) throws URISyntaxException, IOException {
+    public void setFromResponse(String url, String value, final Promise promise) throws URISyntaxException, IOException {
         Map headers = new HashMap<String, List<String>>();
         // Pretend this is a header
         headers.put("Set-cookie", Collections.singletonList(value));
         URI uri = new URI(url);
         this.cookieHandler.put(uri, headers);
-        callback.invoke(null, null);
+        promise.resolve(null);
     }
 
     @ReactMethod
-    public void getFromResponse(String url, Callback callback) throws URISyntaxException, IOException {
-        get(url, callback);
+    public void getFromResponse(String url, Promise promise) throws URISyntaxException, IOException {
+        promise.resolve(url, promise)
     }
 
     @ReactMethod
-    public void getAll(Callback callback) throws Exception {
+    public void getAll(Promise promise) throws Exception {
         throw new Exception("Cannot get all cookies on android, try getCookieHeader(url)");
     }
 
     @ReactMethod
-    public void get(String url, Callback callback) throws URISyntaxException, IOException {
+    public void get(String url, Promise promise) throws URISyntaxException, IOException {
         URI uri = new URI(url);
 
         Map<String, List<String>> cookieMap = this.cookieHandler.get(uri, new HashMap());
@@ -73,14 +74,14 @@ public void get(String url, Callback callback) throws URISyntaxException, IOExce
                 }
             }
         }
-        callback.invoke(null, map);
+        promise.resolve(map);
     }
 
     @ReactMethod
-    public void clearAll(final Callback callback) {
+    public void clearAll(final Promise promise) {
         this.cookieHandler.clearCookies(new Callback() {
             public void invoke(Object... args) {
-                callback.invoke(null, null);
+                promise.resolve(null);
             }
         });
     }