This repository was archived by the owner on Jan 24, 2020. It is now read-only.
Commit 5600ae5
[Android] Let npm take care of versioning (#46)
From [build.gradle](https://github.com/Microsoft/react-native-code-push/blob/master/android/app/build.gradle#L24):
dependencies {
compile "com.facebook.react:react-native:0.16.+"
}
This means that when adding the react-native-code-push module to an app and building it, Gradle will fetch React Native 0.16 from Maven, even if the app is using say RN 0.34. We stopped releasing the React Native Android artifacts to Maven - they are distributed via npm along with the JS code. For example I installed RN 0.34 from npm, it will have the 0.34 Android artifacts in `node_modules` and [Gradle will use those to build the app](https://github.com/facebook/react-native/blob/9ee815f6b52e0c2417c04e5a05e1e31df26daed2/local-cli/generator-android/templates/src/build.gradle#L21).
All React Native Android modules should be using `compile 'com.facebook.react:react-native:+'`, see for example [react-native-push-notification](https://github.com/zo0r/react-native-push-notification/blob/master/android/build.gradle) and [react-native-maps](https://github.com/airbnb/react-native-maps/blob/master/android/build.gradle#L56).1 parent 9f8ffe5 commit 5600ae5
1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
| 33 | + | |
34 | 34 | | |
0 commit comments