Skip to content
This repository was archived by the owner on Jan 24, 2020. It is now read-only.

Commit 88246da

Browse files
committed
fix objective c module errors
1 parent 10451d7 commit 88246da

File tree

1 file changed

+19
-24
lines changed

1 file changed

+19
-24
lines changed

RNCookieManagerIOS/RNCookieManagerIOS.m

Lines changed: 19 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,8 @@ @implementation RNCookieManagerIOS
99

1010
RCT_EXPORT_MODULE()
1111

12-
RCT_REMAP_METHOD(set,
13-
props:(NSDictionary *)props,
14-
resolver:(RCTPromiseResolveBlock)resolve,
12+
RCT_EXPORT_METHOD(set:(NSDictionary *)props
13+
resolver:(RCTPromiseResolveBlock)resolve
1514
rejecter:(RCTPromiseRejectBlock)reject) {
1615
NSString *name = [RCTConvert NSString:props[@"name"]];
1716
NSString *value = [RCTConvert NSString:props[@"value"]];
@@ -36,22 +35,20 @@ @implementation RNCookieManagerIOS
3635
NSHTTPCookie *cookie = [NSHTTPCookie cookieWithProperties:cookieProperties];
3736
[[NSHTTPCookieStorage sharedHTTPCookieStorage] setCookie:cookie];
3837

39-
resolve();
38+
resolve(nil);
4039
}
4140

42-
RCT_REMAP_METHOD(setFromResponse,
43-
url:(NSURL *)url,
44-
value:(NSDictionary *)value,
45-
resolver:(RCTPromiseResolveBlock)resolve,
41+
RCT_EXPORT_METHOD(setFromResponse:(NSURL *)url
42+
value:(NSDictionary *)value
43+
resolver:(RCTPromiseResolveBlock)resolve
4644
rejecter:(RCTPromiseRejectBlock)reject) {
4745
NSArray *cookies = [NSHTTPCookie cookiesWithResponseHeaderFields:value forURL:url];
4846
[[NSHTTPCookieStorage sharedHTTPCookieStorage] setCookies:cookies forURL:url mainDocumentURL:NULL];
49-
resolve();
47+
resolve(nil);
5048
}
5149

52-
RCT_REMAP_METHOD(getFromResponse,
53-
url:(NSURL *)url,
54-
resolver:(RCTPromiseResolveBlock)resolve,
50+
RCT_EXPORT_METHOD(getFromResponse:(NSURL *)url
51+
resolver:(RCTPromiseResolveBlock)resolve
5552
rejecter:(RCTPromiseRejectBlock)reject) {
5653
NSURLRequest *request = [NSURLRequest requestWithURL:url];
5754
[NSURLConnection sendAsynchronousRequest:request queue:[[NSOperationQueue alloc] init]
@@ -71,9 +68,8 @@ @implementation RNCookieManagerIOS
7168
}];
7269
}
7370

74-
RCT_REMAP_METHOD(get,
75-
url:(NSURL *) url,
76-
resolver:(RCTPromiseResolveBlock)resolve,
71+
RCT_EXPORT_METHOD(get:(NSURL *) url
72+
resolver:(RCTPromiseResolveBlock)resolve
7773
rejecter:(RCTPromiseRejectBlock)reject) {
7874
NSMutableDictionary *cookies = [NSMutableDictionary dictionary];
7975
for (NSHTTPCookie *c in [[NSHTTPCookieStorage sharedHTTPCookieStorage] cookiesForURL:url]) {
@@ -82,32 +78,31 @@ @implementation RNCookieManagerIOS
8278
resolve(cookies);
8379
}
8480

85-
RCT_REMAP_METHOD(clearAll,
86-
resolver:(RCTPromiseResolveBlock)resolve,
81+
RCT_EXPORT_METHOD(clearAll:
82+
resolver:(RCTPromiseResolveBlock)resolve
8783
rejecter:(RCTPromiseRejectBlock)reject) {
8884
NSHTTPCookieStorage *cookieStorage = [NSHTTPCookieStorage sharedHTTPCookieStorage];
8985
for (NSHTTPCookie *c in cookieStorage.cookies) {
9086
[cookieStorage deleteCookie:c];
9187
}
92-
resolve();
88+
resolve(nil);
9389
}
9490

95-
RCT_REMAP_METHOD(clearByName,
96-
name:(NSString *) name,
97-
resolver:(RCTPromiseResolveBlock)resolve,
91+
RCT_EXPORT_METHOD(clearByName:(NSString *) name
92+
resolver:(RCTPromiseResolveBlock)resolve
9893
rejecter:(RCTPromiseRejectBlock)reject) {
9994
NSHTTPCookieStorage *cookieStorage = [NSHTTPCookieStorage sharedHTTPCookieStorage];
10095
for (NSHTTPCookie *c in cookieStorage.cookies) {
10196
if ([[c name] isEqualToString:name]) {
10297
[cookieStorage deleteCookie:c];
10398
}
10499
}
105-
resolve();
100+
resolve(nil);
106101
}
107102

108103
// TODO: return a better formatted list of cookies per domain
109-
RCT_REMAP_METHOD(getAll,
110-
resolver:(RCTPromiseResolveBlock)resolve,
104+
RCT_EXPORT_METHOD(getAll:
105+
resolver:(RCTPromiseResolveBlock)resolve
111106
rejecter:(RCTPromiseRejectBlock)reject) {
112107
NSHTTPCookieStorage *cookieStorage = [NSHTTPCookieStorage sharedHTTPCookieStorage];
113108
NSMutableDictionary *cookies = [NSMutableDictionary dictionary];

0 commit comments

Comments
 (0)